Commit Graph
4949 Commits
Author SHA1 Message Date
Kristoffer Dalby 47b91487d0 policy/v2: check grant and nodeAttrs user references on write
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 18:28:23 +00:00
Kristoffer Dalby 595851828e cli: validate offline policy set like policy check 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 8364c98da5 types: reject non-boolean values for boolean settings 2026-10-28 18:28:23 +00:00
Kristoffer Dalby bbc67f800d oidc: send the change from the user update in the callback 2026-10-28 18:28:23 +00:00
Kristoffer Dalby e25d937c84 state: refresh the NodeStore copies of a user in UpdateUser 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 148fc208f9 types: drop a stored OIDC email the login no longer vouches for 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 5d7c1a7d14 state: write every user column in UpdateUser 2026-10-28 18:28:23 +00:00
Kristoffer Dalby 6bdbdc92a5 oidc: refuse logins whose subject the provider identifier would alter 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 93e01c1aee state: announce a node online only after it was offline
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby dacdfd8aaa change: do not echo a node's own report back to it
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby efe89581dc mapper: add device_id to the NextDNS query
SaaS sends the node's stable ID with the other device metadata.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 917c6968f1 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 50c4ed8f67 mapper: test that a hidden peer's policy change still sends filters 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 24e3a8d526 state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 4b0f458e11 mapper: stop an older initial map removing peers newer streams hold
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby cb9af8a5e6 mapper: bound how long one node can block a batcher worker
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby ee3a5600c7 mapper: send nothing while any stream awaits its initial map
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 568d14afc0 mapper: cap concurrent map sessions per node
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468's mapper commit.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 179af840da change: coalesce policy recomputes that carry an origin node
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby b1c142d9c9 state: say a taken name is already taken 2026-10-28 18:28:22 +00:00
Kristoffer Dalby e66084195b db: succeed on a repeated revoke of an auth key
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 85f4c3f654 auth: answer a logout that deletes an ephemeral node as authorised 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 90df03543f cli: show a node's own ephemeral flag instead of its key's 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 095bd610b1 gen/client/v1: regenerate for the node ephemeral flag 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 8f2ca0d01e db, state: keep the ephemeral flag a node was created with
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 50fe50f4f9 db, types: add a nodes column for the ephemeral flag
The migration fills it from the key each node references.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 04dc8e27c6 db: remove unused RenameNode 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 186f78988b state: bump duplicate node names loaded from the database 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 999970edd4 state: cut a label so its -N suffix fits in 63 bytes 2026-10-28 18:28:22 +00:00
Kristoffer Dalby eeea38c627 state: treat extra DNS record names as taken node names 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 568f27bd84 state: save the name NodeStore picks for a new node
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby b08c224f59 db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby bebe7da8c4 hscontrol: arm the ephemeral GC at pre-auth key registration 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 27efd57a36 hscontrol: skip garbage collecting a node that is no longer ephemeral 2026-10-28 18:28:22 +00:00
Kristoffer Dalby 88e8dae2ee db: wrap the sequential IP allocator so freed addresses are reused 2026-10-28 18:28:22 +00:00
Kristoffer Dalby f60e4c3f7f state: test that a persist racing a delete cannot resurrect the node
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby e8edef2625 noise: stop serving metrics inside the tunnel
Any machine key reached it, bypassing metrics_listen_addr. No client
asks for it.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 68e5bfd755 hscontrol: bound client-chosen text in request logs
Clip at the sinks: handler errors, the request line, SSH local_user.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby e785afd35a mapper: show an expired peer online, without endpoints or DERP
A connected expired node shows online to its peers. Neither its map
entry nor endpoint, DERP or disco patches carry the paths to reach it.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 82d2090511 mapper: trim the Hostinfo sent to peers and to the node itself
As on Tailscale SaaS, the node's own entry keeps Hostname, RequestTags,
RoutableIPs and Services; peers get Hostname, OS, Services without
peerapi-dns-proxy, SSH host keys and AppConnector, and resend on those.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby fd70994523 mapper: keep an expired node authorised in its own entry
Tailscale SaaS sends an expired node MachineAuthorized and no Expired
flag; its past KeyExpiry already moves the client to NeedsLogin.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby ad1b6b5931 .github: regenerate integration test workflow 2026-10-28 18:28:22 +00:00
Kristoffer Dalby f7c630fdf9 state: apply requested tags on a key login that owns them
A requested tag the key's user owns directly, or the key's tags own one
hop away, replaces the key's tags instead of refusing the login.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 9dfd78e42e state: auto-approve routes after an admin tag change
The new tags may approve announced routes. Approval runs once the policy
manager knows the new owner, as after a registration.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 8fb3d320a5 state: drop auto-approved routes when they are withdrawn
Only routes auto-approval alone granted go; approvals from before the
upgrade stay, as do routes an admin set.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 32a78cde83 db, types: add a column for auto-approved routes
It starts empty: the current policy cannot tell which earlier approvals
were automatic, so all of them stay as an admin's.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby 98380c2be4 state: auto-approve on registration only when the node key rotates
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby dde74266d9 auth: store a client's earlier expiry and expire a tagged node at logout
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby bebc563035 auth, state: answer an expired node's same-key login with NodeKeyExpired
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-28 18:28:22 +00:00
Kristoffer Dalby d3b4e321f3 state: forget a node's SSH check approvals when it is expired 2026-10-28 18:28:22 +00:00