Commit Graph
4830 Commits
Author SHA1 Message Date
Kristoffer Dalby 5555a52eca servertest: require a map on each stream an expiry replay opens
The cached netmap outlives a stream, so a refused re-poll passed.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 9e20ec77e1 servertest: compare filter and SSH rules in expiry replays
Changed-or-not alone let empty rules pass for SaaS's new ones.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby d8db2b6eff servertest: recapture ephemeral, expiry and pending login golden data
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby de68d0b464 servertest: judge ephemeral collection apart from the poll that saw it
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 995029798e hscontrol: compare API replay fields per object
One aggregate per field hid a partial fix. Device users are compared,
and headscale's oauthClientId resolves to the SaaS label.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 95f21ce1f2 hscontrol: check API replay outcomes apart from status
A listed status hid a call flipping between allowed and refused, and
validate refusals SaaS answers with 200 went unchecked.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 635c41f8fe servertest: recapture v2 OAuth and policy API golden data
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby f9e54092db servertest, policy/v2: replay tag owner chain joins through registration
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 3992c1a729 servertest: recapture re-authentication golden data
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 5df10d2019 servertest: fail on skip entries no lifecycle replay reads
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 97c2b06327 servertest: check route continuity in every streamed step
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 6d4fe414cd servertest: fail step checks that never hold
A match on the last sample before the deadline no longer passes.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 5747160177 servertest: keep the address family in filter comparisons
A rule missing one family of a peer's addresses compared equal.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby a7819639fa servertest: check peer visibility, routes and addresses apart
A listed difference in one no longer hides the others; the exit route
entries now key the AllowedIPs check alone.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby aadf17797f policy/v2: name the destination in sshTests failure breakdowns
A failure reported against the wrong dst alias no longer passes.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 9a5577cd6a servertest: check peers and filters apart after a via source loss
The user node's filter already matches SaaS and is now asserted.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 6e749b9fc7 policy/v2: check the SSH login 0 mapping apart from the rules
Its skip entries no longer hide rule count, order or principals.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby b9ac6da8b2 policy/v2: add grant port list refusal capture
Grant and ACL refusals share one check-keyed refused/message check.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 83306e62d4 prek: exempt grant captures from the large file check
They keep a netmap per node and stay as recorded.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby 483489942c servertest, state: add map delivery golden data
A retag through the API, a running peer's DERP, disco, hostname and
port, down and up gaps around policy pushes; peers, filters and frames
per node.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby b7d1f1ca30 servertest: add via HA failover golden data
One route on a non-via router and a via pair through crashes and
returns, the via group down, expiry, approval loss, withdraw,
re-advertise and delete; route owner and peers per viewer per step.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 1648492cd7 servertest: join replayed routers with their routes
A route update sent after the join could be overtaken by the stream's
first request and dropped; the probe joined with the routes set.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby c5a057f350 servertest, hscontrol: add ephemeral, expiry, pending login golden data
Ephemeral devices through logout, deletes, re-auth and collection;
expired routers and nodes, a client's own expiry and logout; a login
waiting across restarts, replayed exchange by exchange.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby dc52fe1b66 servertest: add login flag, endpoint, disco rotation and expiry helpers
WithLoginFlags and WithEndpoints shape what a client sends; RotateDisco
logs in again on a new disco key and leaves an auth URL waiting;
SetExpirySooner asks for an earlier key expiry.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby f27833fd8a hscontrol, servertest: add v2 OAuth and policy API golden data
OAuth clients, tokens, keys and tag writes by principal, and policy
writes over a baseline, replayed through v1 and v2; a deleted parent
client's key joins real clients.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 7c6458605e policy/v2, servertest: add via port captures
A port-limited ACL entry beside a via grant, and a via tag with no
advertiser. Via HA replays now compare router filters by address.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 9a38d78828 policy/v2, servertest: add multi-route router captures
A seven-route router and an exit node under six policies; replayed
through policy, peer map and map stream. Peer map now checked against
SaaS peers.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 6bc3d28365 policy/v2, mapper: add nextdns attr captures
SaaS accepts malformed nextdns profiles and keeps them in the CapMap;
its resolver skips them. DoH addresses compare per node: path, query,
ID.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby b14e4536f6 policy/v2: add user token captures
SaaS answers for unknown users, a short name and a bare "@" at every
site. Each capture also runs under headscale-only user rows, at boot and
runtime; SaaS nodes must not change and overlay nodes get nothing.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 0a446ce7c3 policy/v2, servertest: add via source loss captures
Repeated via destinations, a user via source, and an empty one.
A rename that empties the via source must reach open streams as v67.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 3a48ee0803 policy/v2, servertest: add validation matrix and grant shape captures
SaaS answers for sshTests sources, tests semantics, failure reports,
duplicate destinations, empty and allow-all policies, and refusals.
ACL and SSH compat checks are keyed per check; differences listed.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 2ba2b2ed07 policy/v2: recapture tester rows with failure detail
Re-runs keep SaaS's error data and validate answer. Tester compat checks
verdict, message, failure breakdown and node labels.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 8eed149b79 servertest: check refused policies leave the live policy unchanged
Posts every policy SaaS refused through v2; filter, SSH, body and ETag
must stay as before. Policies headscale accepts are skip entries.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby f7447194f0 policy/v2: build tester nodes from the capture topology
The fixed node list had other addresses than the captures, so address
and range tests ran against nodes SaaS never saw.
2026-10-28 19:06:02 +00:00
Kristoffer Dalby 89b4c6dfde policy/v2: compare compat captures through the policy manager
ACL, grant and SSH captures now also check FilterForNode and SSHPolicy,
which add the global merge and caches the per-node compile skips.
2026-10-28 19:06:01 +00:00
Kristoffer Dalby d34cb46d02 servertest: pin the Terraform provider version
0.29.3 validates ACLs at plan time through acl/validate, which
headscale lacks, so a floating constraint broke the Terraform tests.
2026-10-28 19:05:48 +00:00
Kristoffer Dalby e1a3bdca00 oidc: keep email_verified with the address it came with
Fixes ANT-2026-MX8FKG4K
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 38125d1043 db, state: let only the delete that removed a node free its addresses
Fixes ANT-2026-NWTIBB02
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 8126f8727a state: drop registration locks once unused
The lock is taken before any credential check, so client-chosen machine
keys grew the map forever. Ref-count entries; delete at zero.

Fixes ANT-2026-ZC18AF82
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 592762ea33 types, auth, noise: let one request wait on each auth session
One verdict per session, so one waiter: the newest. A displaced one
returns at once (register error, SSH re-delegate), not at session end.

Fixes ANT-2026-NM50ZP4N
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 4fdf546861 auth: check the follow-up's machine key before it waits
A session has one verdict; another machine holding the URL could take
it.

Fixes ANT-2026-NM50ZP4N
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 670c232cec noise: time out stalled bodies and idle tunnels
The hijack drops the outer server's deadlines; any machine key gets a
tunnel.

Fixes ANT-2026-K903ZEUA
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 3c277949c7 auth, state: keep announced routes out of pending registrations
Routes are the one long list; the first MapRequest reports them.
A relogin keeps the node's own routes until then.

Fixes ANT-2026-RQS7JAPP
2026-10-28 14:25:41 +00:00
Kristoffer Dalby c87672bcf6 state: bound client reports of nodes loaded at startup
Rows stored before the bounds would still fan out unbounded endpoints.

Fixes ANT-2026-RQS7JAPP
Fixes ANT-2026-5B6KE87K
Fixes ANT-2026-KFCFFM34
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 76509000bc types, noise: bound the Hostinfo and endpoints a client reports
Cut lists and hostname at decode, refuse >64 KiB of non-route Hostinfo.
The body limit counted wire bytes, not what the cache, NodeStore and
peers keep.

Fixes ANT-2026-RQS7JAPP
Fixes ANT-2026-5B6KE87K
Fixes ANT-2026-KFCFFM34
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 7259ef6edd hscontrol: refuse a key expiry that cannot be encoded
handleRegister, the OIDC auth path and SetNodeExpiry refuse it. Expiries
are stored in UTC, which SQLite can read back, and loaded in UTC, as
PostgreSQL returns the server's zone. The v1 API answers 400.

Fixes ANT-2026-QMCAFJ1Q
2026-10-28 14:25:41 +00:00
Kristoffer Dalby 159deeec41 mapper: skip peers whose key expiry cannot be encoded
json.Marshal refuses a year outside [0,9999], so one stored expiry
failed every map with that node. TailNode and key patches send UTC, the
builder drops what fails and the boot scan names the node.

Fixes ANT-2026-QMCAFJ1Q
2026-10-28 14:25:41 +00:00
Kristoffer Dalby f2a51a8f11 .github: regenerate integration test workflow 2026-10-28 14:25:41 +00:00
Kristoffer Dalby eeb0ef0901 state: give another user's key on a tagged machine a new device
Only a key that speaks for a tagged node re-authenticates it: a tagged
key, or one of the user it was tagged from. Another user's key or login
adds that user's own device, or only wakes the node under its node key.

Fixes ANT-2026-AWGRB7O1
2026-10-28 14:25:32 +00:00
Kristoffer Dalby c262792660 state: need a valid pre-auth key to re-register an expired tagged node
Fixes ANT-2026-LYVGXVSW
2026-10-28 14:22:20 +00:00