Commit Graph
4862 Commits
Author SHA1 Message Date
Kristoffer Dalby 5a2f3c6ad3 policy/v2: parse the compiled filter once per tests run
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-28 14:37:16 +00:00
Kristoffer Dalby 8ebe643826 policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 14:37:15 +00:00
Kristoffer Dalby 54257c9231 policy/v2: label sshTests failures with the dst alias
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-28 14:37:14 +00:00
Kristoffer Dalby f85060946a policy/v2: bound the tests and sshTests failure report
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-28 14:37:13 +00:00
Kristoffer Dalby ea2f9c5bf4 policy/v2: refuse autogroup:member as an sshTests destination
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-28 14:37:13 +00:00
Kristoffer Dalby 94c410e1db policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-28 14:37:12 +00:00
Kristoffer Dalby 7ef3d56a50 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-28 14:37:11 +00:00
Kristoffer Dalby 98c2e56794 policy/v2: write an ACL's repeated destination once
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-28 14:37:10 +00:00
Kristoffer Dalby 6f30e2ddbe policy/v2: write a single-address via destination bare
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-28 14:37:09 +00:00
Kristoffer Dalby 524ccc46aa db: keep only the current policy
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-28 14:37:08 +00:00
Kristoffer Dalby 6c06fcc919 state: install a written policy only after it is stored
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-28 14:37:07 +00:00
Kristoffer Dalby 89b37fde7d policy/v2: refuse an empty policy
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-28 14:37:06 +00:00
Kristoffer Dalby df7eb934a0 policy/v2: resolve tag owners one hop deep
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-28 14:37:05 +00:00
Kristoffer Dalby a0548e01e0 policy/v2: evaluate sshTests sources through the nodes they cover
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-28 14:37:04 +00:00
Kristoffer Dalby 8caa41cd32 policy/v2: resolve each group once per policy compile
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-28 14:37:03 +00:00
Kristoffer Dalby 89ba8b7dd2 policy/v2: compile SSH rules once and share them across nodes
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-28 14:37:02 +00:00
Kristoffer Dalby 45308ec596 policy/v2: merge rules sharing a source slice without rejoining it
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-28 14:37:01 +00:00
Kristoffer Dalby f235907f96 policy/v2: resolve an ACL's sources once for all its destinations
An ACL compiles to one grant per destination, and each resolved and
rendered the same sources. ViaRoutesForPeer only needs one grant per
ACL.
2026-10-28 14:37:00 +00:00
Kristoffer Dalby e934cc02d7 policy/v2: bound via route steering by the peer's routes
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-28 14:36:59 +00:00
Kristoffer Dalby f6a1ed0300 policy/v2: refresh clients when a user change drops the last via grant
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-28 14:36:58 +00:00
Kristoffer Dalby 38613d7217 state: serialise policy reloads
Load and install the stored policy as one step, so an older
reload cannot install its document over a newer one.
2026-10-28 14:36:57 +00:00
Kristoffer Dalby bba5fd6c94 policy/v2: recapture SSH data captures
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-28 14:31:42 +00:00
Kristoffer Dalby 45948f2feb hscontrol, servertest: add key list scope golden data
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-28 14:31:41 +00:00
Kristoffer Dalby a16a38f527 servertest: add user role dispatch golden data
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby b4e2c0e93f servertest, state: add node name golden data
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby b7fdc48a14 policy/v2, servertest: add policy generation golden data
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby 659ac74d19 servertest: add hidden peer and route announcement golden data
What a node hears of peers it cannot see, and what a router's peers hear
of routes it announces; presence, removals, peers and routes per step.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby fbce1be506 servertest: count map frames per client
Counts ControlTime events, so frames that leave the netmap as it was,
or that a delta client applies in place, still show.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby 6f9eecc80e servertest: recapture map delivery golden data
The probe now bounds snapshot reads and keeps feature refusals as data.
SaaS now sends appc and sshd laptop's unchanged entry on the restore.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby 71c668fc6b servertest: wait for each replayed join before the next
Polls start in the background, so a later router could come online
first and keep the global primary SaaS gave the first.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby f87985073e servertest: count deleted nodes in replayed peer views
Only nodes still in State resolved to an alias, so a client that kept
a deleted peer passed the peers and route owner checks.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby edc64bf7b8 servertest: recapture via HA failover golden data
The probe now bounds its reads and stops when a step loses data.
Route owners and peers match the first capture at every step.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby 48455b7812 hscontrol, servertest: fail on any unread pending login or expiry entry
Each map serves one capture, so a misspelled capture name never went
stale.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby 47538563c7 servertest: require a map on each stream an expiry replay opens
The cached netmap outlives a stream, so a refused re-poll passed.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby efc8c696e2 servertest: compare filter and SSH rules in expiry replays
Changed-or-not alone let empty rules pass for SaaS's new ones.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby 855e14c4a7 servertest: recapture ephemeral, expiry and pending login golden data
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
2026-10-28 14:30:13 +00:00
Kristoffer Dalby ef496217b6 servertest: judge ephemeral collection apart from the poll that saw it
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
2026-10-28 14:30:13 +00:00
Kristoffer Dalby 4ee0fff157 hscontrol: compare API replay fields per object
One aggregate per field hid a partial fix. Device users are compared,
and headscale's oauthClientId resolves to the SaaS label.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby 8adb93a3ef hscontrol: check API replay outcomes apart from status
A listed status hid a call flipping between allowed and refused, and
validate refusals SaaS answers with 200 went unchecked.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby b9f7317252 servertest: recapture v2 OAuth and policy API golden data
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby 74ed6cbf11 servertest, policy/v2: replay tag owner chain joins through registration
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-28 14:29:59 +00:00
Kristoffer Dalby 070ac5893f servertest: recapture re-authentication golden data
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
2026-10-28 14:29:37 +00:00
Kristoffer Dalby 759cf73108 servertest: fail on skip entries no lifecycle replay reads
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby 52faf0e692 servertest: check route continuity in every streamed step
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby 464656d6b3 servertest: fail step checks that never hold
A match on the last sample before the deadline no longer passes.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby 54cbc3aad8 servertest: keep the address family in filter comparisons
A rule missing one family of a peer's addresses compared equal.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby dca6017598 servertest: check peer visibility, routes and addresses apart
A listed difference in one no longer hides the others; the exit route
entries now key the AllowedIPs check alone.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby 0e93c4775f policy/v2: name the destination in sshTests failure breakdowns
A failure reported against the wrong dst alias no longer passes.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby 0b8869ce31 servertest: check peers and filters apart after a via source loss
The user node's filter already matches SaaS and is now asserted.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby 2c6c7f070f policy/v2: check the SSH login 0 mapping apart from the rules
Its skip entries no longer hide rule count, order or principals.
2026-10-28 14:29:34 +00:00