Kristoffer Dalby
63ccb1dad7
policy/v2: refuse address ranges as sshTests sources
...
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
7a5f548ec3
policy/v2: map login 0 to no local user in SSH rules
...
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
9e79b08fa6
policy/v2: write an ACL's repeated destination once
...
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
0708870b6c
policy/v2: write a single-address via destination bare
...
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
c4bf1cb46f
db: keep only the current policy
...
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
7123c4b593
state: install a written policy only after it is stored
...
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
f3b2d6b798
policy/v2: refuse an empty policy
...
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8dee772bea
policy/v2: resolve tag owners one hop deep
...
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
23014255b2
policy/v2: evaluate sshTests sources through the nodes they cover
...
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
b6edf6f0cf
policy/v2: resolve each group once per policy compile
...
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
80a9a9084b
policy/v2: compile SSH rules once and share them across nodes
...
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
65006bff41
policy/v2: merge rules sharing a source slice without rejoining it
...
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
eb9c14b5f2
policy/v2: treat an ACL as one grant in ViaRoutesForPeer
...
Ports never steer routes, and one grant per destination
matched the sources once per destination.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
0aff3656e2
policy/v2: bound via route steering by the peer's routes
...
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
60f0b20d76
policy/v2: refresh clients when a user change drops the last via grant
...
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
60991f3d01
state: serialise policy reloads
...
Load and install the stored policy as one step, so an older
reload cannot install its document over a newer one.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
82ffc3d313
integration: keep HA cable-pull routers off each other's routes
...
A router holding the other's route for its docker subnet in table 52
cannot be reattached: docker resolves the gateway through tailscale0.
Replaces the phase 4a wait that covered one case of it.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
8967c7e91c
mapper: count only the batcher's goroutines in lifecycle tests
...
runtime.NumGoroutine deltas moved when goroutines left by earlier
tests exited mid-test. Label the batcher's goroutines and count those.
2026-10-30 14:55:36 +00:00
Kristoffer Dalby
4106bc816c
policy/v2: recapture SSH data captures
...
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
d41d1cc718
hscontrol, servertest: add key list scope golden data
...
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
9746de8e4b
servertest: add user role dispatch golden data
...
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
47a014fad4
servertest, state: add node name golden data
...
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
486ec799b9
policy/v2, servertest: add policy generation golden data
...
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
7e7049a825
servertest: add hidden peer and route announcement golden data
...
What a node hears of peers it cannot see, and what a router's peers hear
of routes it announces; presence, removals, peers and routes per step.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
2b7b2475fd
servertest: count map frames per client
...
Counts ControlTime events, so frames that leave the netmap as it was,
or that a delta client applies in place, still show.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
b75921a495
servertest: recapture map delivery golden data
...
The probe now bounds snapshot reads and keeps feature refusals as data.
SaaS now sends appc and sshd laptop's unchanged entry on the restore.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
ad6ed08b4e
servertest: wait for each replayed join before the next
...
Polls start in the background, so a later router could come online
first and keep the global primary SaaS gave the first.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
5511cd6afc
servertest: count deleted nodes in replayed peer views
...
Only nodes still in State resolved to an alias, so a client that kept
a deleted peer passed the peers and route owner checks.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
31a6200e00
servertest: recapture via HA failover golden data
...
The probe now bounds its reads and stops when a step loses data.
Route owners and peers match the first capture at every step.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
c9128927b6
hscontrol, servertest: fail on any unread pending login or expiry entry
...
Each map serves one capture, so a misspelled capture name never went
stale.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
e6da798e8c
servertest: require a map on each stream an expiry replay opens
...
The cached netmap outlives a stream, so a refused re-poll passed.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
0169c6576b
servertest: compare filter and SSH rules in expiry replays
...
Changed-or-not alone let empty rules pass for SaaS's new ones.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
80cf7d5c0e
servertest: recapture ephemeral, expiry and pending login golden data
...
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
6e30fa1c5e
servertest: judge ephemeral collection apart from the poll that saw it
...
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
0a9f7f49d6
hscontrol: compare API replay fields per object
...
One aggregate per field hid a partial fix. Device users are compared,
and headscale's oauthClientId resolves to the SaaS label.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
3b170f04f1
hscontrol: check API replay outcomes apart from status
...
A listed status hid a call flipping between allowed and refused, and
validate refusals SaaS answers with 200 went unchecked.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
1525c185ac
servertest: recapture v2 OAuth and policy API golden data
...
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
da312948d9
servertest, policy/v2: replay tag owner chain joins through registration
...
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
90125c8a23
servertest: recapture re-authentication golden data
...
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
7cdecd4e78
servertest: fail on skip entries no lifecycle replay reads
...
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
f49add10bb
servertest: check route continuity in every streamed step
...
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
a391107369
servertest: fail step checks that never hold
...
A match on the last sample before the deadline no longer passes.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
6e303d0027
servertest: keep the address family in filter comparisons
...
A rule missing one family of a peer's addresses compared equal.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
6c6648b4e5
servertest: check peer visibility, routes and addresses apart
...
A listed difference in one no longer hides the others; the exit route
entries now key the AllowedIPs check alone.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
755346921b
policy/v2: name the destination in sshTests failure breakdowns
...
A failure reported against the wrong dst alias no longer passes.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
4348f6b545
servertest: check peers and filters apart after a via source loss
...
The user node's filter already matches SaaS and is now asserted.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
26dbc55750
policy/v2: check the SSH login 0 mapping apart from the rules
...
Its skip entries no longer hide rule count, order or principals.
2026-10-30 14:55:35 +00:00
Kristoffer Dalby
629eb158a3
policy/v2: add grant port list refusal capture
...
Grant and ACL refusals share one check-keyed refused/message check.
2026-10-30 14:55:34 +00:00
Kristoffer Dalby
8d01364b00
prek: exempt grant captures from the large file check
...
They keep a netmap per node and stay as recorded.
2026-10-30 14:55:34 +00:00
Kristoffer Dalby
4912ec1231
servertest, state: add map delivery golden data
...
A retag through the API, a running peer's DERP, disco, hostname and
port, down and up gaps around policy pushes; peers, filters and frames
per node.
2026-10-30 14:55:34 +00:00
Kristoffer Dalby