Kristoffer Dalby
649b0de5bc
hscontrol: compare a tag-limited token's untagged child client
...
SaaS lets a tag:ci token create an untagged all-scope client whose token
takes tag:prod and mints a tag:prod key. Headscale refuses the client,
so the step that mints its token and key is not replayed.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
cae755878a
hscontrol: compare a zero-length policy write
...
SaaS takes an empty POST /acl as a reset to its allow-all default, while
its validate refuses the same body. Headscale's v1 and v2 refuse both.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
6413c4a81b
servertest: compare a single-use key presented by three devices
...
SaaS converts two live devices that keep their node key with one
single-use key, spends it only on a third with a new node key, and
keeps key expiry on for a same-key conversion. Headscale spends it once.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
e13a595f3d
policy/v2, servertest: compare router peers in tailnet overlap captures
...
SaaS gives each router every device as a peer, whatever the policy
links, and the devices do not list the router back.
Headscale peers a router only with what its policy links.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
f3944e3d98
policy/v2: add deny test captures that pass while access remains
...
SaaS passes a tests deny when one node of the dst alias, or one member
of a group source, is blocked, though another still gets in. Headscale
fails the dst case; it passes the group case as SaaS does.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
5f1c166140
policy/v2, servertest: add group source split across rules captures
...
SaaS judges a tests or sshTests group source by one rule naming the
group: per-member rules fail a true accept and pass a false deny.
Headscale checks each member through its own rules.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
78c415fa5b
policy/v2, servertest: add bare IPv6 sshTests destination capture
...
SaaS fails an accept to a bare IPv6 dst, checking the source at
::ffff:100.64.0.0, which no device holds; the IPv4 twin passes.
Headscale checks the source's own addresses and accepts.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
10f228f50b
mapper: read tracked peers under workMu in batcher tests
...
A full map replaces the set with Clear then Store; an unlocked read
between them failed TestOlderInitialMapLeavesNewerStreamsPeers.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
96c06ae937
docs: describe what OAuth scopes and tags limit
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
6498ed7324
api/v2: require a token to hold a device's current tags to retag it
...
SetNodeTags replaces the tag set, so the tags it removes need the grant
too. A tag outside the grant answers 400, as on Tailscale SaaS.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
e68372fe61
api/v2: name the token's tags in the token answer
...
Only a token that can assign tags names them, as Tailscale's answer
does.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
b17306c9b9
api/v2: send empty route lists under fields=all
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
bde86a8c26
gen/client/v2: regenerate for the device's join key
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
a5e40f474b
api/v2: name the join key in a device's oauthClientId
...
For a key a token made, Tailscale names the token's client, which is
not recorded, so the field is left out.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
26b6ba3384
api/v2: show a tagged device's creator as its user
...
A tagged device shows the login that made the key it joined with.
Its owner stays its tags.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
6d10faa73c
gen/client/v2: regenerate for the key list without all=true
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
24d6ad8939
api/v2: list token-made auth keys to a token without all=true
...
Keys an OAuth token makes are marked so. No listing holds an invalid
key.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
590c50d481
db, types: add a credentials column for keys a token made
...
No released version made keys from tokens, so existing rows stay false.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
792a75decc
api/v2: show userId on admin-made tagged keys
...
An admin key's user is recorded as the creator of the tagged keys it
makes. A tagged key re-registers a machine by its tags, whoever made it.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
5454da3b34
api/v2: return a device name as its FQDN
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
70d96ccd8f
api/v2: refuse an unknown keyType
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
e13ed03e70
api/v2: ignore unknown properties in request bodies
...
Tailscale's API ignores them.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
d84dabcbda
db: keep at most 1000 access tokens per OAuth client
...
Minting needs only the client secret, whatever its scopes, and
added one row per mint. Each mint now ends tokens past the newest 1000.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
6ec4e4c9ca
api/v2: check the createKey scope before reading the body
...
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
bae4f57215
api/v2: stop echoing request values in error responses
...
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
b0d625c3ff
api/v2: bound every request body
...
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
8a73d68c21
api/v2: keep a tagged all-scope client's tokens inside its tags
...
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
5803ddedd3
debug: refuse requests addressed to unknown host names
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
eeb02858d9
types: accept only lowercase hex in auth IDs
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
f0ecba2bd7
oidc: show requested tags on the registration confirmation page
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
c27a13eed8
oidc: show on the confirmation page whether the device is registered
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
1f1e75c56f
oidc: approve SSH checks on the confirmation page, not in the callback
...
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
4563650475
policy/v2: match no user for a bare "@" token
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
4d539834e5
policy/v2: match no one for an ambiguous user outside policy writes
...
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
7c9a167a65
policy/v2: prefer the user owning an email over a username match
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
6082a81e93
policy/v2: check grant and nodeAttrs user references on write
...
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
c8ebb83bdb
cli: validate offline policy set like policy check
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
e2048f15f5
types: reject non-boolean values for boolean settings
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
21706d8d54
oidc: send the change from the user update in the callback
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
7888c07c2f
state: refresh the NodeStore copies of a user in UpdateUser
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
e66fb356e8
types: drop a stored OIDC email the login no longer vouches for
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
8593547c9d
state: write every user column in UpdateUser
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
ffc668d48e
oidc: refuse logins whose subject the provider identifier would alter
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
b22dd41b51
state: announce a node online only after it was offline
...
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
719f6ea01d
change: do not echo a node's own report back to it
...
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
dc734e08e1
mapper: add device_id to the NextDNS query
...
SaaS sends the node's stable ID with the other device metadata.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
d81f6169da
policy/v2: warn once at load about malformed nextdns attrs
...
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
29ec14baeb
mapper: test that a hidden peer's policy change still sends filters
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
7c7db6fe28
state, change: send a deleted node's removal only to its peers
...
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-30 14:55:37 +00:00
Kristoffer Dalby
8e5608fe3b
mapper: stop an older initial map removing peers newer streams hold
...
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-30 14:55:37 +00:00