Commit Graph
4958 Commits
Author SHA1 Message Date
Kristoffer Dalby 6aac892e7b db: keep at most 1000 access tokens per OAuth client
Minting needs only the client secret, whatever its scopes, and
added one row per mint. Each mint now ends tokens past the newest 1000.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 4d82a3e06e api/v2: check the createKey scope before reading the body
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 697fa25712 api/v2: stop echoing request values in error responses
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 0598db4f33 api/v2: bound every request body
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 2d6293b106 api/v2: keep a tagged all-scope client's tokens inside its tags
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 89c15dd642 debug: refuse requests addressed to unknown host names 2026-10-27 21:32:34 +00:00
Kristoffer Dalby fa13cb9789 types: accept only lowercase hex in auth IDs 2026-10-27 21:32:34 +00:00
Kristoffer Dalby a7fb8ecb44 oidc: show requested tags on the registration confirmation page 2026-10-27 21:32:34 +00:00
Kristoffer Dalby b6ec88c5e9 oidc: show on the confirmation page whether the device is registered 2026-10-27 21:32:34 +00:00
Kristoffer Dalby c945cdea05 oidc: approve SSH checks on the confirmation page, not in the callback
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 56b1421b06 policy/v2: match no user for a bare "@" token 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 17664e3adc policy/v2: match no one for an ambiguous user outside policy writes
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby bf5007add8 policy/v2: prefer the user owning an email over a username match 2026-10-27 21:32:34 +00:00
Kristoffer Dalby fc560108a2 policy/v2: check grant and nodeAttrs user references on write
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby c8c2b451d8 cli: validate offline policy set like policy check 2026-10-27 21:32:34 +00:00
Kristoffer Dalby dc86639c00 types: reject non-boolean values for boolean settings 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 48e6fc0c73 oidc: send the change from the user update in the callback 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 12f6b6f10f state: refresh the NodeStore copies of a user in UpdateUser 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 8014416648 types: drop a stored OIDC email the login no longer vouches for 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 17c4778b30 state: write every user column in UpdateUser 2026-10-27 21:32:34 +00:00
Kristoffer Dalby d435721dc1 oidc: refuse logins whose subject the provider identifier would alter 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 837ec60e00 oidc: keep email_verified with the address it came with 2026-10-27 21:32:33 +00:00
Kristoffer Dalby be787616e7 state: announce a node online only after it was offline
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 814c2109c3 change: do not echo a node's own report back to it
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 4ed4cb539a mapper: add device_id to the NextDNS query
SaaS sends the node's stable ID with the other device metadata.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby bb6da35417 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby edf448bf0d mapper: test that a hidden peer's policy change still sends filters 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 0cee52ebdb state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby b9886dbf18 mapper: stop an older initial map removing peers newer streams hold
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 52d1a8a191 mapper: bound how long one node can block a batcher worker
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 8a80db4d28 mapper: send nothing while any stream awaits its initial map
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby c3d845cdf0 mapper: cap concurrent map sessions per node
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468's mapper commit.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 8f21991adc change: coalesce policy recomputes that carry an origin node
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 9fb4ea34ab state: say a taken name is already taken 2026-10-27 21:32:33 +00:00
Kristoffer Dalby ece4ed281c db: succeed on a repeated revoke of an auth key
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 294c2ff5bd auth: answer a logout that deletes an ephemeral node as authorised 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 1059cc63a7 cli: show a node's own ephemeral flag instead of its key's 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 2820dba360 gen/client/v1: regenerate for the node ephemeral flag 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 458acd000e db, state: keep the ephemeral flag a node was created with
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 4df99062de db, types: add a nodes column for the ephemeral flag
The migration fills it from the key each node references.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby f28cc6556e db: remove unused RenameNode 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 316a3c238e state: bump duplicate node names loaded from the database 2026-10-27 21:32:33 +00:00
Kristoffer Dalby f64a1f163d state: cut a label so its -N suffix fits in 63 bytes 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 6dc4745dc7 state: treat extra DNS record names as taken node names 2026-10-27 21:32:33 +00:00
Kristoffer Dalby c565a0b9cf state: save the name NodeStore picks for a new node
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 02e3e8ac7a db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby ef3576fa02 hscontrol: arm the ephemeral GC at pre-auth key registration 2026-10-27 21:32:33 +00:00
Kristoffer Dalby b0ac330175 hscontrol: skip garbage collecting a node that is no longer ephemeral 2026-10-27 21:32:33 +00:00
Kristoffer Dalby f06a75e3bb db: wrap the sequential IP allocator so freed addresses are reused 2026-10-27 21:32:33 +00:00
Kristoffer Dalby d21a7eb766 state: test that a persist racing a delete cannot resurrect the node
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-27 21:32:33 +00:00