Kristoffer Dalby
6dc4745dc7
state: treat extra DNS record names as taken node names
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
c565a0b9cf
state: save the name NodeStore picks for a new node
...
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
02e3e8ac7a
db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
...
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
ef3576fa02
hscontrol: arm the ephemeral GC at pre-auth key registration
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
b0ac330175
hscontrol: skip garbage collecting a node that is no longer ephemeral
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
f06a75e3bb
db: wrap the sequential IP allocator so freed addresses are reused
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
d21a7eb766
state: test that a persist racing a delete cannot resurrect the node
...
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
29e43eac1f
db, state: let only the delete that removed a node free its addresses
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
97351a392f
state: drop registration locks once unused
...
The lock is taken before any credential check, so client-chosen machine
keys grew the map forever. Ref-count entries; delete at zero.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
d2749d9726
types, auth, noise: let one request wait on each auth session
...
One verdict per session, so one waiter: the newest. A displaced one
returns at once (register error, SSH re-delegate), not at session end.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
71150e7990
auth: check the follow-up's machine key before it waits
...
A session has one verdict; another machine holding the URL could take
it.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
62897a7f36
noise: stop serving metrics inside the tunnel
...
Any machine key reached it, bypassing metrics_listen_addr. No client
asks for it.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
f28192a9d4
noise: time out stalled bodies and idle tunnels
...
The hijack drops the outer server's deadlines; any machine key gets a
tunnel.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
0069b8dd38
hscontrol: bound client-chosen text in request logs
...
Clip at the sinks: handler errors, the request line, SSH local_user.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
bddc7ce44b
auth, state: keep announced routes out of pending registrations
...
Routes are the one long list; the first MapRequest reports them.
A relogin keeps the node's own routes until then.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
717fa70da4
state: bound client reports of nodes loaded at startup
...
Rows stored before the bounds would still fan out unbounded endpoints.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
c0f1f48483
types, noise: bound the Hostinfo and endpoints a client reports
...
Cut lists and hostname at decode, refuse >64 KiB of non-route Hostinfo.
The body limit counted wire bytes, not what the cache, NodeStore and
peers keep.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
11cff1da0b
mapper: show an expired peer online, without endpoints or DERP
...
A connected expired node shows online to its peers. Neither its map
entry nor endpoint, DERP or disco patches carry the paths to reach it.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
b67228a31a
mapper: trim the Hostinfo sent to peers and to the node itself
...
As on Tailscale SaaS, the node's own entry keeps Hostname, RequestTags,
RoutableIPs and Services; peers get Hostname, OS, Services without
peerapi-dns-proxy, SSH host keys and AppConnector, and resend on those.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
0fdbe12e9e
mapper: keep an expired node authorised in its own entry
...
Tailscale SaaS sends an expired node MachineAuthorized and no Expired
flag; its past KeyExpiry already moves the client to NeedsLogin.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
92b0acb322
hscontrol: refuse a key expiry that cannot be encoded
...
handleRegister, the OIDC auth path and SetNodeExpiry refuse it. Expiries
are stored in UTC, which SQLite can read back, and loaded in UTC, as
PostgreSQL returns the server's zone. The v1 API answers 400.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
36bb3ccb25
mapper: skip peers whose key expiry cannot be encoded
...
json.Marshal refuses a year outside [0,9999], so one stored expiry
failed every map with that node. TailNode and key patches send UTC, the
builder drops what fails and the boot scan names the node.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
0bd2c73546
state: apply requested tags on a key login that owns them
...
A requested tag the key's user owns directly, or the key's tags own one
hop away, replaces the key's tags instead of refusing the login.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
ef1dabcb61
state: auto-approve routes after an admin tag change
...
The new tags may approve announced routes. Approval runs once the policy
manager knows the new owner, as after a registration.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
7f415ec531
state: drop auto-approved routes when they are withdrawn
...
Only routes auto-approval alone granted go; approvals from before the
upgrade stay, as do routes an admin set.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
e7fba93c54
db, types: add a column for auto-approved routes
...
It starts empty: the current policy cannot tell which earlier approvals
were automatic, so all of them stay as an admin's.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
627d4e5014
state: auto-approve on registration only when the node key rotates
...
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
17aa4194bd
auth: store a client's earlier expiry and expire a tagged node at logout
...
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
6a96fa4ca9
auth, state: answer an expired node's same-key login with NodeKeyExpired
...
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
32553a1e72
state: forget a node's SSH check approvals when it is expired
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
c8ed1971ab
state: honour SSH check approvals only while the source keeps its owner
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
5e382e2a89
state: give another user's key on a tagged machine a new device
...
Only a key that speaks for a tagged node re-authenticates it: a tagged
key, or one of the user it was tagged from, which takes it back with a
new node key. Another user's key or login adds that user's own device.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
817f8e0057
state: let a pre-auth key that is no longer valid only wake its node
...
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
573349e3b5
state: need a valid pre-auth key to re-register an expired tagged node
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
cc36764a4b
state: serialise registrations presenting an unused single-use key
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
d47d94be0a
state: auto-approve routes in the NodeStore writer, not on reload
...
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
64f606e2ab
state: undo a failed re-registration without reverting newer writes
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
7c8fcd2393
state: write node rows from the NodeStore under persistMu
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
8bd19d56a5
state: apply map requests only under the node key that authorised them
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
a9ad49f9a6
policy: offer exit routes only to viewers whose rules reach the internet
...
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
701138104c
mapper: send a router all of its own routes
...
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
5d8a8f993c
policy: reduce merged destination prefixes to the node's own addresses
...
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
2abcf2b44a
api, policy/v2: refuse route prefixes with host bits
...
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
04b0938240
state: never serve a single address inside the node ranges
...
Such a route names a node, not a subnet: it stays approved and listed
but no viewer gets it. Via inclusions skip the election, so the rule
sits on everything RoutesForPeer returns.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
3a29d86098
policy, state: log only the routes auto-approval adds
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
02ff84e89f
poll: hold the map session's node as a view
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
05307fe7ad
policy/matcher, types: compare a node's routes to matchers as ranges
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
f61a7cfafe
policy/matcher: binary-search ranges in overlap checks
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
ae6cd03310
policy: look up approved routes in a set when auto-approving
...
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby
6d03e39830
types, state: reduce a node's routes against the matchers once
...
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-27 21:32:33 +00:00