Kristoffer Dalby
79636f3893
api/v2: check the createKey scope before reading the body
...
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
8af7222816
api/v2: stop echoing request values in error responses
...
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
2e837a9072
api/v2: bound every request body
...
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
141d7813c1
api/v2: keep a tagged all-scope client's tokens inside its tags
...
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
3c1b256bb1
debug: refuse requests addressed to unknown host names
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
fb69559d13
types: accept only lowercase hex in auth IDs
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
bcaf3f4366
oidc: show requested tags on the registration confirmation page
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
8c045591f3
oidc: show on the confirmation page whether the device is registered
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
d849a3367a
oidc: approve SSH checks on the confirmation page, not in the callback
...
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
1ca9665a87
policy/v2: match no user for a bare "@" token
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
d77ea33f7d
policy/v2: match no one for an ambiguous user outside policy writes
...
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
1901a56201
policy/v2: prefer the user owning an email over a username match
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
4f154a6e81
policy/v2: check grant and nodeAttrs user references on write
...
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
723daf42b1
cli: validate offline policy set like policy check
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
d40350daf1
types: reject non-boolean values for boolean settings
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
63871fef3a
oidc: send the change from the user update in the callback
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
e652da8744
state: refresh the NodeStore copies of a user in UpdateUser
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
005879dc5d
types: drop a stored OIDC email the login no longer vouches for
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
941b8cba61
state: write every user column in UpdateUser
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
6ba1867b4d
oidc: refuse logins whose subject the provider identifier would alter
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
0acd84382b
state: announce a node online only after it was offline
...
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
d1ab26388c
change: do not echo a node's own report back to it
...
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby
6519e35698
mapper: add device_id to the NextDNS query
...
SaaS sends the node's stable ID with the other device metadata.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby
9bf533b626
policy/v2: warn once at load about malformed nextdns attrs
...
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby
61f4eb037d
mapper: test that a hidden peer's policy change still sends filters
2026-10-28 14:42:25 +00:00
Kristoffer Dalby
ce9e3211b5
state, change: send a deleted node's removal only to its peers
...
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby
5ef53d7c1d
mapper: stop an older initial map removing peers newer streams hold
...
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby
9e3034053c
mapper: bound how long one node can block a batcher worker
...
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby
c5f1021226
mapper: send nothing while any stream awaits its initial map
...
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby
de3e63e258
mapper: cap concurrent map sessions per node
...
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468 's mapper commit.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby
79cc581409
change: coalesce policy recomputes that carry an origin node
...
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby
9bf7916153
state: say a taken name is already taken
2026-10-28 14:42:24 +00:00
Kristoffer Dalby
96d9c361dc
db: succeed on a repeated revoke of an auth key
...
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby
28296e6b84
auth: answer a logout that deletes an ephemeral node as authorised
2026-10-28 14:42:23 +00:00
Kristoffer Dalby
1f79dddc55
cli: show a node's own ephemeral flag instead of its key's
2026-10-28 14:42:23 +00:00
Kristoffer Dalby
84c2081409
gen/client/v1: regenerate for the node ephemeral flag
2026-10-28 14:42:23 +00:00
Kristoffer Dalby
3392597804
db, state: keep the ephemeral flag a node was created with
...
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby
67ad240d3a
db, types: add a nodes column for the ephemeral flag
...
The migration fills it from the key each node references.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby
c403bba5dd
db: remove unused RenameNode
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
eee5f18401
state: bump duplicate node names loaded from the database
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
af41728ecf
state: cut a label so its -N suffix fits in 63 bytes
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
267ab2f4db
state: treat extra DNS record names as taken node names
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
f271fc482d
state: save the name NodeStore picks for a new node
...
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
81ce6cb486
db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
...
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-28 14:42:22 +00:00
Kristoffer Dalby
71d7e9030e
hscontrol: arm the ephemeral GC at pre-auth key registration
2026-10-28 14:42:21 +00:00
Kristoffer Dalby
63986bdb1a
hscontrol: skip garbage collecting a node that is no longer ephemeral
2026-10-28 14:42:21 +00:00
Kristoffer Dalby
39341d6c4a
db: wrap the sequential IP allocator so freed addresses are reused
2026-10-28 14:42:21 +00:00
Kristoffer Dalby
9199cc8a06
state: test that a persist racing a delete cannot resurrect the node
...
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-28 14:42:21 +00:00
Kristoffer Dalby
5705538f2e
noise: stop serving metrics inside the tunnel
...
Any machine key reached it, bypassing metrics_listen_addr. No client
asks for it.
2026-10-28 14:42:21 +00:00
Kristoffer Dalby
8660eb476f
hscontrol: bound client-chosen text in request logs
...
Clip at the sinks: handler errors, the request line, SSH local_user.
2026-10-28 14:42:06 +00:00