Kristoffer Dalby
7aa0ebfc24
policy/v2: write a single-address via destination bare
...
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
53ab9284ee
db: keep only the current policy
...
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
21ae79091a
state: install a written policy only after it is stored
...
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
13a4c22af0
policy/v2: refuse an empty policy
...
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
b102973c77
policy/v2: resolve tag owners one hop deep
...
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
b166f80914
policy/v2: evaluate sshTests sources through the nodes they cover
...
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
381594e768
policy/v2: resolve each group once per policy compile
...
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
b8a772f51f
policy/v2: compile SSH rules once and share them across nodes
...
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
75e0071527
policy/v2: merge rules sharing a source slice without rejoining it
...
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
f0c298bf96
policy/v2: resolve an ACL's sources once for all its destinations
...
An ACL compiles to one grant per destination, and each resolved and
rendered the same sources. ViaRoutesForPeer only needs one grant per
ACL.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
44e1e3fdef
policy/v2: bound via route steering by the peer's routes
...
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
d8f1651ab8
policy/v2: refresh clients when a user change drops the last via grant
...
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
4bb43e15f0
state: serialise policy reloads
...
Load and install the stored policy as one step, so an older
reload cannot install its document over a newer one.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby
5952ea12c0
integration: keep HA cable-pull routers off each other's routes
...
A router holding the other's route for its docker subnet in table 52
cannot be reattached: docker resolves the gateway through tailscale0.
Replaces the phase 4a wait that covered one case of it.
2026-10-28 16:35:03 +00:00
Kristoffer Dalby
bba5fd6c94
policy/v2: recapture SSH data captures
...
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-28 14:31:42 +00:00
Kristoffer Dalby
45948f2feb
hscontrol, servertest: add key list scope golden data
...
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-28 14:31:41 +00:00
Kristoffer Dalby
a16a38f527
servertest: add user role dispatch golden data
...
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby
b4e2c0e93f
servertest, state: add node name golden data
...
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-28 14:31:40 +00:00
Kristoffer Dalby
b7fdc48a14
policy/v2, servertest: add policy generation golden data
...
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby
659ac74d19
servertest: add hidden peer and route announcement golden data
...
What a node hears of peers it cannot see, and what a router's peers hear
of routes it announces; presence, removals, peers and routes per step.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby
fbce1be506
servertest: count map frames per client
...
Counts ControlTime events, so frames that leave the netmap as it was,
or that a delta client applies in place, still show.
2026-10-28 14:30:16 +00:00
Kristoffer Dalby
6f9eecc80e
servertest: recapture map delivery golden data
...
The probe now bounds snapshot reads and keeps feature refusals as data.
SaaS now sends appc and sshd laptop's unchanged entry on the restore.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby
71c668fc6b
servertest: wait for each replayed join before the next
...
Polls start in the background, so a later router could come online
first and keep the global primary SaaS gave the first.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby
f87985073e
servertest: count deleted nodes in replayed peer views
...
Only nodes still in State resolved to an alias, so a client that kept
a deleted peer passed the peers and route owner checks.
2026-10-28 14:30:15 +00:00
Kristoffer Dalby
edc64bf7b8
servertest: recapture via HA failover golden data
...
The probe now bounds its reads and stops when a step loses data.
Route owners and peers match the first capture at every step.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby
48455b7812
hscontrol, servertest: fail on any unread pending login or expiry entry
...
Each map serves one capture, so a misspelled capture name never went
stale.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby
47538563c7
servertest: require a map on each stream an expiry replay opens
...
The cached netmap outlives a stream, so a refused re-poll passed.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby
efc8c696e2
servertest: compare filter and SSH rules in expiry replays
...
Changed-or-not alone let empty rules pass for SaaS's new ones.
2026-10-28 14:30:14 +00:00
Kristoffer Dalby
855e14c4a7
servertest: recapture ephemeral, expiry and pending login golden data
...
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
2026-10-28 14:30:13 +00:00
Kristoffer Dalby
ef496217b6
servertest: judge ephemeral collection apart from the poll that saw it
...
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
2026-10-28 14:30:13 +00:00
Kristoffer Dalby
4ee0fff157
hscontrol: compare API replay fields per object
...
One aggregate per field hid a partial fix. Device users are compared,
and headscale's oauthClientId resolves to the SaaS label.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby
8adb93a3ef
hscontrol: check API replay outcomes apart from status
...
A listed status hid a call flipping between allowed and refused, and
validate refusals SaaS answers with 200 went unchecked.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby
b9f7317252
servertest: recapture v2 OAuth and policy API golden data
...
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
2026-10-28 14:30:12 +00:00
Kristoffer Dalby
74ed6cbf11
servertest, policy/v2: replay tag owner chain joins through registration
...
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-28 14:29:59 +00:00
Kristoffer Dalby
070ac5893f
servertest: recapture re-authentication golden data
...
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
2026-10-28 14:29:37 +00:00
Kristoffer Dalby
759cf73108
servertest: fail on skip entries no lifecycle replay reads
...
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby
52faf0e692
servertest: check route continuity in every streamed step
...
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby
464656d6b3
servertest: fail step checks that never hold
...
A match on the last sample before the deadline no longer passes.
2026-10-28 14:29:36 +00:00
Kristoffer Dalby
54cbc3aad8
servertest: keep the address family in filter comparisons
...
A rule missing one family of a peer's addresses compared equal.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby
dca6017598
servertest: check peer visibility, routes and addresses apart
...
A listed difference in one no longer hides the others; the exit route
entries now key the AllowedIPs check alone.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby
0e93c4775f
policy/v2: name the destination in sshTests failure breakdowns
...
A failure reported against the wrong dst alias no longer passes.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby
0b8869ce31
servertest: check peers and filters apart after a via source loss
...
The user node's filter already matches SaaS and is now asserted.
2026-10-28 14:29:35 +00:00
Kristoffer Dalby
2c6c7f070f
policy/v2: check the SSH login 0 mapping apart from the rules
...
Its skip entries no longer hide rule count, order or principals.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby
2b2149dc80
policy/v2: add grant port list refusal capture
...
Grant and ACL refusals share one check-keyed refused/message check.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby
d1b144e9a3
prek: exempt grant captures from the large file check
...
They keep a netmap per node and stay as recorded.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby
9f87fbd4f3
servertest, state: add map delivery golden data
...
A retag through the API, a running peer's DERP, disco, hostname and
port, down and up gaps around policy pushes; peers, filters and frames
per node.
2026-10-28 14:29:34 +00:00
Kristoffer Dalby
40324335cd
servertest: add via HA failover golden data
...
One route on a non-via router and a via pair through crashes and
returns, the via group down, expiry, approval loss, withdraw,
re-advertise and delete; route owner and peers per viewer per step.
2026-10-28 14:29:33 +00:00
Kristoffer Dalby
58c8abbf52
servertest: join replayed routers with their routes
...
A route update sent after the join could be overtaken by the stream's
first request and dropped; the probe joined with the routes set.
2026-10-28 14:29:33 +00:00
Kristoffer Dalby
9447314d95
servertest, hscontrol: add ephemeral, expiry, pending login golden data
...
Ephemeral devices through logout, deletes, re-auth and collection;
expired routers and nodes, a client's own expiry and logout; a login
waiting across restarts, replayed exchange by exchange.
2026-10-28 14:29:33 +00:00
Kristoffer Dalby
38e0e0e016
servertest: add login flag, endpoint, disco rotation and expiry helpers
...
WithLoginFlags and WithEndpoints shape what a client sends; RotateDisco
logs in again on a new disco key and leaves an auth URL waiting;
SetExpirySooner asks for an earlier key expiry.
2026-10-28 14:29:32 +00:00
Kristoffer Dalby