Kristoffer Dalby
8a42537196
servertest: compare open streams after an admin role change
...
SaaS sends a role change to no open stream: a node sees it only on its
next stream, so peers disagree and a demotion keeps access. Headscale
pushes the change to every connected node at once.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
ef06071aad
policy/v2, servertest: compare rules after a device is deleted
...
SaaS keeps a deleted device's addresses in other nodes' filter and SSH
rules until a later policy push. Headscale drops them with the device.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
2cfe29058c
servertest: compare unchanged router entries sent on announce
...
SaaS sends a router's unchanged entry to its peers after some route
announcements and not others, with no change to explain which.
Headscale sends it on every announced route change.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
8540926393
hscontrol: compare a waiting login when key expiry is turned off
...
SaaS answers a waiting login once an admin turns the device's key expiry
off, with the client's newest node key and no login. Headscale keeps
the login waiting.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
6d7042183b
hscontrol: compare a tag-limited token's untagged child client
...
SaaS lets a tag:ci token create an untagged all-scope client whose token
takes tag:prod and mints a tag:prod key. Headscale refuses the client,
so the step that mints its token and key is not replayed.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
58c0457506
hscontrol: compare a zero-length policy write
...
SaaS takes an empty POST /acl as a reset to its allow-all default, while
its validate refuses the same body. Headscale's v1 and v2 refuse both.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
72d8c843f1
servertest: compare a single-use key presented by three devices
...
SaaS converts two live devices that keep their node key with one
single-use key, spends it only on a third with a new node key, and
keeps key expiry on for a same-key conversion. Headscale spends it once.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
ccb36d2aed
policy/v2, servertest: compare router peers in tailnet overlap captures
...
SaaS gives each router every device as a peer, whatever the policy
links, and the devices do not list the router back.
Headscale peers a router only with what its policy links.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
d4ccdef066
policy/v2: add deny test captures that pass while access remains
...
SaaS passes a tests deny when one node of the dst alias, or one member
of a group source, is blocked, though another still gets in. Headscale
fails the dst case; it passes the group case as SaaS does.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
ff37b57718
policy/v2, servertest: add group source split across rules captures
...
SaaS judges a tests or sshTests group source by one rule naming the
group: per-member rules fail a true accept and pass a false deny.
Headscale checks each member through its own rules.
2026-10-28 14:42:57 +00:00
Kristoffer Dalby
09471a7219
policy/v2, servertest: add bare IPv6 sshTests destination capture
...
SaaS fails an accept to a bare IPv6 dst, checking the source at
::ffff:100.64.0.0, which no device holds; the IPv4 twin passes.
Headscale checks the source's own addresses and accepts.
2026-10-28 14:42:56 +00:00
Kristoffer Dalby
6a903f90ad
gen/client/v2: regenerate for the acl/validate endpoint
2026-10-28 14:42:31 +00:00
Kristoffer Dalby
3256b9b9cf
api/v2: add the acl/validate endpoint
...
It checks a policy as a write would, without storing it. As on
Tailscale, a refused policy answers 200 with its reason; only an empty
body is a 400.
2026-10-28 14:42:31 +00:00
Kristoffer Dalby
01ef5c0d67
docs: describe what OAuth scopes and tags limit
2026-10-28 14:42:31 +00:00
Kristoffer Dalby
81925d9d48
api/v2: require a token to hold a device's current tags to retag it
...
SetNodeTags replaces the tag set, so the tags it removes need the grant
too. A tag outside the grant answers 400, as on Tailscale SaaS.
2026-10-28 14:42:31 +00:00
Kristoffer Dalby
92dd36a432
api/v2: name the token's tags in the token answer
...
Only a token that can assign tags names them, as Tailscale's answer
does.
2026-10-28 14:42:30 +00:00
Kristoffer Dalby
8d4adb66e3
api/v2: send empty route lists under fields=all
2026-10-28 14:42:30 +00:00
Kristoffer Dalby
2fbbb5081a
gen/client/v2: regenerate for the device's join key
2026-10-28 14:42:30 +00:00
Kristoffer Dalby
412ef2726b
api/v2: name the join key in a device's oauthClientId
...
For a key a token made, Tailscale names the token's client, which is
not recorded, so the field is left out.
2026-10-28 14:42:30 +00:00
Kristoffer Dalby
1af4a51b74
api/v2: show a tagged device's creator as its user
...
A tagged device shows the login that made the key it joined with.
Its owner stays its tags.
2026-10-28 14:42:30 +00:00
Kristoffer Dalby
6b2d622d04
gen/client/v2: regenerate for the key list without all=true
2026-10-28 14:42:30 +00:00
Kristoffer Dalby
e5d14fd2d2
api/v2: list token-made auth keys to a token without all=true
...
Keys an OAuth token makes are marked so. No listing holds an invalid
key.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
8b7fc0e7fa
db, types: add a credentials column for keys a token made
...
No released version made keys from tokens, so existing rows stay false.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
3768aaf323
api/v2: show userId on admin-made tagged keys
...
An admin key's user is recorded as the creator of the tagged keys it
makes. A tagged key re-registers a machine by its tags, whoever made it.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
fb5802c878
api/v2: return a device name as its FQDN
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
9e0c609b12
api/v2: refuse an unknown keyType
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
6360b4958c
api/v2: ignore unknown properties in request bodies
...
Tailscale's API ignores them.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
fe2b83bf94
db: keep at most 1000 access tokens per OAuth client
...
Minting needs only the client secret, whatever its scopes, and
added one row per mint. Each mint now ends tokens past the newest 1000.
2026-10-28 14:42:29 +00:00
Kristoffer Dalby
79636f3893
api/v2: check the createKey scope before reading the body
...
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
8af7222816
api/v2: stop echoing request values in error responses
...
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
2e837a9072
api/v2: bound every request body
...
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
141d7813c1
api/v2: keep a tagged all-scope client's tokens inside its tags
...
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
3c1b256bb1
debug: refuse requests addressed to unknown host names
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
fb69559d13
types: accept only lowercase hex in auth IDs
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
bcaf3f4366
oidc: show requested tags on the registration confirmation page
2026-10-28 14:42:28 +00:00
Kristoffer Dalby
8c045591f3
oidc: show on the confirmation page whether the device is registered
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
d849a3367a
oidc: approve SSH checks on the confirmation page, not in the callback
...
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
1ca9665a87
policy/v2: match no user for a bare "@" token
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
d77ea33f7d
policy/v2: match no one for an ambiguous user outside policy writes
...
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
1901a56201
policy/v2: prefer the user owning an email over a username match
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
4f154a6e81
policy/v2: check grant and nodeAttrs user references on write
...
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
723daf42b1
cli: validate offline policy set like policy check
2026-10-28 14:42:27 +00:00
Kristoffer Dalby
d40350daf1
types: reject non-boolean values for boolean settings
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
63871fef3a
oidc: send the change from the user update in the callback
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
e652da8744
state: refresh the NodeStore copies of a user in UpdateUser
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
005879dc5d
types: drop a stored OIDC email the login no longer vouches for
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
941b8cba61
state: write every user column in UpdateUser
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
6ba1867b4d
oidc: refuse logins whose subject the provider identifier would alter
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
0acd84382b
state: announce a node online only after it was offline
...
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 14:42:26 +00:00
Kristoffer Dalby
d1ab26388c
change: do not echo a node's own report back to it
...
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 14:42:25 +00:00