Commit Graph
4935 Commits
Author SHA1 Message Date
Kristoffer Dalby 96f187b0a0 state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 13790344ec mapper: stop an older initial map removing peers newer streams hold
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby d01cf2ee0d mapper: bound how long one node can block a batcher worker
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby e6c41753a3 mapper: send nothing while any stream awaits its initial map
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 36a42548a0 mapper: cap concurrent map sessions per node
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468's mapper commit.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby ed40c31c87 change: coalesce policy recomputes that carry an origin node
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 6a5ea877f4 state: say a taken name is already taken 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 37655ae586 db: succeed on a repeated revoke of an auth key
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 9ad6fd24b2 auth: answer a logout that deletes an ephemeral node as authorised 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 3dfea48020 cli: show a node's own ephemeral flag instead of its key's 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 5ce9c82ffa gen/client/v1: regenerate for the node ephemeral flag 2026-10-28 16:35:22 +00:00
Kristoffer Dalby d6a657aaeb db, state: keep the ephemeral flag a node was created with
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 799a301c2d db, types: add a nodes column for the ephemeral flag
The migration fills it from the key each node references.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 2d3de03f1d db: remove unused RenameNode 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 47507b2c9a state: bump duplicate node names loaded from the database 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 15b628f8dc state: cut a label so its -N suffix fits in 63 bytes 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 5e50859d58 state: treat extra DNS record names as taken node names 2026-10-28 16:35:22 +00:00
Kristoffer Dalby e69970b5e2 state: save the name NodeStore picks for a new node
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby f26853dc7f db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 044b6b61fb hscontrol: arm the ephemeral GC at pre-auth key registration 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 43af1db6a0 hscontrol: skip garbage collecting a node that is no longer ephemeral 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 8eb706fb78 db: wrap the sequential IP allocator so freed addresses are reused 2026-10-28 16:35:22 +00:00
Kristoffer Dalby 14a3749f78 state: test that a persist racing a delete cannot resurrect the node
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 6cab9ac7f7 noise: stop serving metrics inside the tunnel
Any machine key reached it, bypassing metrics_listen_addr. No client
asks for it.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 9db5e423e5 hscontrol: bound client-chosen text in request logs
Clip at the sinks: handler errors, the request line, SSH local_user.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 089a0ed13e mapper: show an expired peer online, without endpoints or DERP
A connected expired node shows online to its peers. Neither its map
entry nor endpoint, DERP or disco patches carry the paths to reach it.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 0ab509ee7b mapper: trim the Hostinfo sent to peers and to the node itself
As on Tailscale SaaS, the node's own entry keeps Hostname, RequestTags,
RoutableIPs and Services; peers get Hostname, OS, Services without
peerapi-dns-proxy, SSH host keys and AppConnector, and resend on those.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby dabfb3c7b4 mapper: keep an expired node authorised in its own entry
Tailscale SaaS sends an expired node MachineAuthorized and no Expired
flag; its past KeyExpiry already moves the client to NeedsLogin.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 71556e5a30 .github: regenerate integration test workflow 2026-10-28 16:35:22 +00:00
Kristoffer Dalby d1da9982f4 state: apply requested tags on a key login that owns them
A requested tag the key's user owns directly, or the key's tags own one
hop away, replaces the key's tags instead of refusing the login.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 9cfd05fe5a state: auto-approve routes after an admin tag change
The new tags may approve announced routes. Approval runs once the policy
manager knows the new owner, as after a registration.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 8ebc2f41bf state: drop auto-approved routes when they are withdrawn
Only routes auto-approval alone granted go; approvals from before the
upgrade stay, as do routes an admin set.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby bd12059446 db, types: add a column for auto-approved routes
It starts empty: the current policy cannot tell which earlier approvals
were automatic, so all of them stay as an admin's.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 437a607ef3 state: auto-approve on registration only when the node key rotates
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 033e3de65c auth: store a client's earlier expiry and expire a tagged node at logout
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 8e4159a336 auth, state: answer an expired node's same-key login with NodeKeyExpired
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 549a09b4e5 state: forget a node's SSH check approvals when it is expired 2026-10-28 16:35:22 +00:00
Kristoffer Dalby eb426183d2 state: honour SSH check approvals only while the source keeps its owner 2026-10-28 16:35:22 +00:00
Kristoffer Dalby aa8bb46b4e state: let a pre-auth key that is no longer valid only wake its node
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby 62c63ff62b state: serialise registrations presenting an unused single-use key 2026-10-28 16:35:21 +00:00
Kristoffer Dalby f52d2216a6 state: auto-approve routes in the NodeStore writer, not on reload
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 12acbb2ffb state: undo a failed re-registration without reverting newer writes 2026-10-28 16:35:21 +00:00
Kristoffer Dalby c2a4183c03 state: write node rows from the NodeStore under persistMu 2026-10-28 16:35:21 +00:00
Kristoffer Dalby 96d68fcbc4 state: apply map requests only under the node key that authorised them 2026-10-28 16:35:21 +00:00
Kristoffer Dalby 4c98552b2d policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby aca11eae02 mapper: send a router all of its own routes
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 87de37fc7a policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 12fb9fae43 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 16:35:21 +00:00
Kristoffer Dalby 1c8d768a21 policy, state: log only the routes auto-approval adds 2026-10-28 16:35:21 +00:00
Kristoffer Dalby cb10a23c61 poll: hold the map session's node as a view 2026-10-28 16:35:21 +00:00