public/headscale
1
0 Fork 0
mirror of https://github.com/juanfont/headscale.git synced 2026-11-04 04:34:07 +09:00
Code Issues Packages Projects Releases Wiki Activity
4,859 Commits 106 Branches 177 Tags
99af4aa8a5741d3dc2c5d172858fae911e54035f
Commit Graph
4859 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Kristoffer Dalby 99af4aa8a5 servertest: compare filter and SSH rules in expiry replays 
Changed-or-not alone let empty rules pass for SaaS's new ones.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 44c6810b10 servertest: recapture ephemeral, expiry and pending login golden data 
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 1d48f67534 servertest: judge ephemeral collection apart from the poll that saw it 
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 77f0fc921d hscontrol: compare API replay fields per object 
One aggregate per field hid a partial fix. Device users are compared,
and headscale's oauthClientId resolves to the SaaS label.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby b69a7e3df7 hscontrol: check API replay outcomes apart from status 
A listed status hid a call flipping between allowed and refused, and
validate refusals SaaS answers with 200 went unchecked.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby bd5ae1e0fb servertest: recapture v2 OAuth and policy API golden data 
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby a21d725853 servertest, policy/v2: replay tag owner chain joins through registration 
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 8e3270b180 servertest: recapture re-authentication golden data 
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 70eb9366be servertest: fail on skip entries no lifecycle replay reads 
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby cb3a5446f7 servertest: check route continuity in every streamed step 
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 4c7d88c08e servertest: fail step checks that never hold 
A match on the last sample before the deadline no longer passes.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 95f6116a87 servertest: keep the address family in filter comparisons 
A rule missing one family of a peer's addresses compared equal.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 6bbf6b7b94 servertest: check peer visibility, routes and addresses apart 
A listed difference in one no longer hides the others; the exit route
entries now key the AllowedIPs check alone.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 2747f111b9 policy/v2: name the destination in sshTests failure breakdowns 
A failure reported against the wrong dst alias no longer passes.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 4cbee05d67 servertest: check peers and filters apart after a via source loss 
The user node's filter already matches SaaS and is now asserted.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 765f4d8cf2 policy/v2: check the SSH login 0 mapping apart from the rules 
Its skip entries no longer hide rule count, order or principals.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 63130fb8e5 policy/v2: add grant port list refusal capture 
Grant and ACL refusals share one check-keyed refused/message check.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby f70d25579b prek: exempt grant captures from the large file check 
They keep a netmap per node and stay as recorded.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 46b84d47fe servertest, state: add map delivery golden data 
A retag through the API, a running peer's DERP, disco, hostname and
port, down and up gaps around policy pushes; peers, filters and frames
per node.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby ea474ee06c servertest: add via HA failover golden data 
One route on a non-via router and a via pair through crashes and
returns, the via group down, expiry, approval loss, withdraw,
re-advertise and delete; route owner and peers per viewer per step.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby b15b15fdd3 servertest: join replayed routers with their routes 
A route update sent after the join could be overtaken by the stream's
first request and dropped; the probe joined with the routes set.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby c9dbfb1bef servertest, hscontrol: add ephemeral, expiry, pending login golden data 
Ephemeral devices through logout, deletes, re-auth and collection;
expired routers and nodes, a client's own expiry and logout; a login
waiting across restarts, replayed exchange by exchange.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby ee82df334e servertest: add login flag, endpoint, disco rotation and expiry helpers 
WithLoginFlags and WithEndpoints shape what a client sends; RotateDisco
logs in again on a new disco key and leaves an auth URL waiting;
SetExpirySooner asks for an earlier key expiry.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby ca9874617b hscontrol, servertest: add v2 OAuth and policy API golden data 
OAuth clients, tokens, keys and tag writes by principal, and policy
writes over a baseline, replayed through v1 and v2; a deleted parent
client's key joins real clients.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby aa4721b3be policy/v2, servertest: add via port captures 
A port-limited ACL entry beside a via grant, and a via tag with no
advertiser. Via HA replays now compare router filters by address.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 1449dc8c4f policy/v2, servertest: add multi-route router captures 
A seven-route router and an exit node under six policies; replayed
through policy, peer map and map stream. Peer map now checked against
SaaS peers.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 80472006c4 policy/v2, mapper: add nextdns attr captures 
SaaS accepts malformed nextdns profiles and keeps them in the CapMap;
its resolver skips them. DoH addresses compare per node: path, query,
ID.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 7b86005350 policy/v2: add user token captures 
SaaS answers for unknown users, a short name and a bare "@" at every
site. Each capture also runs under headscale-only user rows, at boot and
runtime; SaaS nodes must not change and overlay nodes get nothing.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 3342e60fd4 policy/v2, servertest: add via source loss captures 
Repeated via destinations, a user via source, and an empty one.
A rename that empties the via source must reach open streams as v67.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 389f0e137d policy/v2, servertest: add validation matrix and grant shape captures 
SaaS answers for sshTests sources, tests semantics, failure reports,
duplicate destinations, empty and allow-all policies, and refusals.
ACL and SSH compat checks are keyed per check; differences listed.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby c69c47409a policy/v2: recapture tester rows with failure detail 
Re-runs keep SaaS's error data and validate answer. Tester compat checks
verdict, message, failure breakdown and node labels.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 1915feafd5 servertest: check refused policies leave the live policy unchanged 
Posts every policy SaaS refused through v2; filter, SSH, body and ETag
must stay as before. Policies headscale accepts are skip entries.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby b2b2bb0e38 policy/v2: build tester nodes from the capture topology 
The fixed node list had other addresses than the captures, so address
and range tests ran against nodes SaaS never saw.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 79001007ea policy/v2: compare compat captures through the policy manager 
ACL, grant and SSH captures now also check FilterForNode and SSHPolicy,
which add the global merge and caches the per-node compile skips.
 2026-11-02 16:09:00 +01:00
Kristoffer Dalby 7721d8c299 hscontrol: keep a re-keyed node from its stale ephemeral GC timer 
Re-registering with a permanent key left the timer armed, and the poll
path only cancels for ephemeral nodes. Recheck when the timer fires.
 2026-10-30 17:05:36 +01:00
Igor SerganovandClaude Opus 5.5 1ff8e368b6 hscontrol: arm ephemeral GC when a node registers with an auth key 
The ephemeral garbage collector was only armed when a long-poll
session ended, or for every ephemeral node at startup. A client that
registered and went away before its first long-poll reached Connect,
for example a pod killed right after login, never ended a session,
so no deletion timer was armed. The node then stayed until headscale
restarted, well past node.ephemeral.inactivity_timeout.

Schedule the GC right after the auth-key registration, before the
error check: a failed policy refresh still returns the saved node. The
existing Cancel in serveLongPoll stops the timer once the node
connects. A timer that fires while a session is live is still skipped
by the ActiveSessions check.

TestEphemeralGCDoesNotDeleteReconnectedNode now checks that
registration arms the timer and cancels it before replaying its
sessions. Otherwise the 50ms timer could fire while the test's Connect
was still waiting for a NodeStore flush.

TestFailedReconnectDoesNotCancelEphemeralGC and
TestDeleteNodeCancelsEphemeralGC ran with a zero inactivity timeout,
so the registration timer deleted the node at once, and the delete
cancelled the timer the tests armed themselves. They now use 5s, which
outlasts the tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-30 17:05:36 +01:00
Igor Serganov 704f1cafd3 db: release the IPv4 address when IPv6 allocation fails in Next 
IPAllocator.Next took the allocator mutex once per address family.
When the IPv6 allocation failed, the IPv4 address had already been
added to usedIPs and prev4 had moved past it, so the address stayed
reserved until headscale restarted even though no node held it.

Allocate both families under a single critical section, and on an
IPv6 failure remove the IPv4 address from usedIPs and restore prev4.
 2026-10-30 17:05:25 +01:00
Igor Serganov 2088f1d2a6 db: make the ephemeral GC safe to close twice 
A second Close panicked on the closed cancel channel.
 2026-10-30 17:05:14 +01:00
github-actions[bot] 4472cd8b83 Update VOUCHED list 
https://github.com/juanfont/headscale/issues/3629#issuecomment-6525293776
 2026-10-30 15:35:25 +01:00
Kristoffer Dalby 526daf0841 policy/v2: resolve an ACL's sources once, not once per destination 
An ACL compiles to one grant per destination, and each resolved and
merged the same sources again. A wide CI-style ACL took 3s and 674MB
per compile; 88ms and 23MB now.
 2026-10-30 14:36:19 +01:00
Kristoffer Dalby 8e45958341 CHANGELOG: align the 0.29.x sections with the releases 
0.29.7 now matches what ships; 0.30.0 drops entries 0.29.7 already
released. #3398 never shipped in 0.29.3, #3236 missed 0.29.0.
 2026-10-30 10:35:22 +01:00
Kristoffer Dalby 545ace5673 hscontrol: remove unused OIDC user change result 2026-10-29 20:51:50 +01:00
Kristoffer Dalby c0925962c2 hscontrol: bound pending authentication without evicting sessions 2026-10-29 20:51:50 +01:00
Kristoffer Dalby a9508935b9 CHANGELOG: document SSH acceptEnv fix 
Updates #3559
 2026-10-29 20:51:36 +01:00
Kristoffer Dalby 52842f4c0d integration: guard SSH acceptEnv forwarding 
Updates #3559
 2026-10-29 20:51:36 +01:00
arkie 8cf43952af types: emit SSH environment capability by default 
Fixes #3559
 2026-10-29 20:51:36 +01:00
Kristoffer Dalby beb1214926 release: reject dirty sources and build artifacts 
Fixes #3583
 2026-10-29 15:39:30 +01:00
Kristoffer Dalby c285eff776 CHANGELOG: list the oss-scanner findings for 0.29.7 
Move the #3603 entries to 0.29.7 and link the pull request.
 2026-10-29 14:00:02 +01:00
Kristoffer Dalby 729464091e testcapture: refuse golden captures that name no tool commit 
It walks every testdata folder, so a new folder is covered too. Captures
taken since tscap refuses such builds are listed until taken again.
 2026-10-29 14:00:02 +01:00
Kristoffer Dalby 208043c88d oidc: keep email_verified with the address it came with 
Fixes ANT-2026-MX8FKG4K
 2026-10-29 14:00:02 +01:00