Commit Graph
4936 Commits
Author SHA1 Message Date
Kristoffer Dalby 9bf533b626 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby 61f4eb037d mapper: test that a hidden peer's policy change still sends filters 2026-10-28 14:42:25 +00:00
Kristoffer Dalby ce9e3211b5 state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-28 14:42:25 +00:00
Kristoffer Dalby 5ef53d7c1d mapper: stop an older initial map removing peers newer streams hold
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby 9e3034053c mapper: bound how long one node can block a batcher worker
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby c5f1021226 mapper: send nothing while any stream awaits its initial map
Sent to the ready streams alone, a change counted as delivered and
never reached the new stream; the worker retries it once the map is out.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby de3e63e258 mapper: cap concurrent map sessions per node
A node chose how many map streams it held, each pinning a session.
The fifth replaces the oldest; same shape as #3468's mapper commit.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby 79cc581409 change: coalesce policy recomputes that carry an origin node
The recompute render ignores the origin and always carries the node's
own entry, so a burst of tag writes cost every node one per write.
2026-10-28 14:42:24 +00:00
Kristoffer Dalby 9bf7916153 state: say a taken name is already taken 2026-10-28 14:42:24 +00:00
Kristoffer Dalby 96d9c361dc db: succeed on a repeated revoke of an auth key
A repeated v2 DELETE of an auth key now answers 200, as Tailscale does.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby 28296e6b84 auth: answer a logout that deletes an ephemeral node as authorised 2026-10-28 14:42:23 +00:00
Kristoffer Dalby 1f79dddc55 cli: show a node's own ephemeral flag instead of its key's 2026-10-28 14:42:23 +00:00
Kristoffer Dalby 84c2081409 gen/client/v1: regenerate for the node ephemeral flag 2026-10-28 14:42:23 +00:00
Kristoffer Dalby 3392597804 db, state: keep the ephemeral flag a node was created with
The flag moves from the key to the node, so a login with another key no
longer changes it. A user claiming a tagged node still clears it. v1
nodes carry the flag.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby 67ad240d3a db, types: add a nodes column for the ephemeral flag
The migration fills it from the key each node references.
2026-10-28 14:42:23 +00:00
Kristoffer Dalby c403bba5dd db: remove unused RenameNode 2026-10-28 14:42:22 +00:00
Kristoffer Dalby eee5f18401 state: bump duplicate node names loaded from the database 2026-10-28 14:42:22 +00:00
Kristoffer Dalby af41728ecf state: cut a label so its -N suffix fits in 63 bytes 2026-10-28 14:42:22 +00:00
Kristoffer Dalby 267ab2f4db state: treat extra DNS record names as taken node names 2026-10-28 14:42:22 +00:00
Kristoffer Dalby f271fc482d state: save the name NodeStore picks for a new node
The row is committed before the name UPDATE, so a failed UPDATE still
returns the node and registration arms ephemeral cleanup.
2026-10-28 14:42:22 +00:00
Kristoffer Dalby 81ce6cb486 db, api/v1: revoke rather than delete an ephemeral pre-auth key in use
The v1 list now hides revoked keys, so keys revoked through v2 also drop
out of `headscale preauthkeys list`.
2026-10-28 14:42:22 +00:00
Kristoffer Dalby 71d7e9030e hscontrol: arm the ephemeral GC at pre-auth key registration 2026-10-28 14:42:21 +00:00
Kristoffer Dalby 63986bdb1a hscontrol: skip garbage collecting a node that is no longer ephemeral 2026-10-28 14:42:21 +00:00
Kristoffer Dalby 39341d6c4a db: wrap the sequential IP allocator so freed addresses are reused 2026-10-28 14:42:21 +00:00
Kristoffer Dalby 9199cc8a06 state: test that a persist racing a delete cannot resurrect the node
DeleteNode's early persistMu unlock is safe only while node persists
stay UPDATE-only; say so where the lock is declared.
2026-10-28 14:42:21 +00:00
Kristoffer Dalby 5705538f2e noise: stop serving metrics inside the tunnel
Any machine key reached it, bypassing metrics_listen_addr. No client
asks for it.
2026-10-28 14:42:21 +00:00
Kristoffer Dalby 8660eb476f hscontrol: bound client-chosen text in request logs
Clip at the sinks: handler errors, the request line, SSH local_user.
2026-10-28 14:42:06 +00:00
Kristoffer Dalby f320fe10e8 mapper: show an expired peer online, without endpoints or DERP
A connected expired node shows online to its peers. Neither its map
entry nor endpoint, DERP or disco patches carry the paths to reach it.
2026-10-28 14:42:05 +00:00
Kristoffer Dalby 3a9a1a6a4c mapper: trim the Hostinfo sent to peers and to the node itself
As on Tailscale SaaS, the node's own entry keeps Hostname, RequestTags,
RoutableIPs and Services; peers get Hostname, OS, Services without
peerapi-dns-proxy, SSH host keys and AppConnector, and resend on those.
2026-10-28 14:42:05 +00:00
Kristoffer Dalby 9a496270c4 mapper: keep an expired node authorised in its own entry
Tailscale SaaS sends an expired node MachineAuthorized and no Expired
flag; its past KeyExpiry already moves the client to NeedsLogin.
2026-10-28 14:42:04 +00:00
Kristoffer Dalby 389e8d9c9c .github: regenerate integration test workflow 2026-10-28 14:42:04 +00:00
Kristoffer Dalby 15732cc071 state: apply requested tags on a key login that owns them
A requested tag the key's user owns directly, or the key's tags own one
hop away, replaces the key's tags instead of refusing the login.
2026-10-28 14:42:03 +00:00
Kristoffer Dalby 2a96a02d7b state: auto-approve routes after an admin tag change
The new tags may approve announced routes. Approval runs once the policy
manager knows the new owner, as after a registration.
2026-10-28 14:42:03 +00:00
Kristoffer Dalby e481fe49d3 state: drop auto-approved routes when they are withdrawn
Only routes auto-approval alone granted go; approvals from before the
upgrade stay, as do routes an admin set.
2026-10-28 14:42:02 +00:00
Kristoffer Dalby 070fe4c9bd db, types: add a column for auto-approved routes
It starts empty: the current policy cannot tell which earlier approvals
were automatic, so all of them stay as an admin's.
2026-10-28 14:42:02 +00:00
Kristoffer Dalby 3c0f6e8120 state: auto-approve on registration only when the node key rotates
Registration runs the approval itself, once the policy manager knows the
node's owner, for a new node key or a change to the announced routes.
2026-10-28 14:42:01 +00:00
Kristoffer Dalby 822c8779a5 auth: store a client's earlier expiry and expire a tagged node at logout
A client may bring its expiry forward, which turns expiry on for a node
without one, but still cannot push it back. Logout expires tagged nodes
too.
2026-10-28 14:42:00 +00:00
Kristoffer Dalby 309cfbb342 auth, state: answer an expired node's same-key login with NodeKeyExpired
The client then rotates its node key and logs in again, so no key is
judged under the expired one. The machine stays authorised.
2026-10-28 14:41:47 +00:00
Kristoffer Dalby 7625a5ec90 state: forget a node's SSH check approvals when it is expired 2026-10-28 14:41:46 +00:00
Kristoffer Dalby e43ee22b01 state: honour SSH check approvals only while the source keeps its owner 2026-10-28 14:41:02 +00:00
Kristoffer Dalby bf1ff1665b state: let a pre-auth key that is no longer valid only wake its node
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-28 14:40:49 +00:00
Kristoffer Dalby c1e4c56848 state: serialise registrations presenting an unused single-use key 2026-10-28 14:40:32 +00:00
Kristoffer Dalby a0893b43ff state: auto-approve routes in the NodeStore writer, not on reload
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 14:39:41 +00:00
Kristoffer Dalby 69c69d35e2 state: undo a failed re-registration without reverting newer writes 2026-10-28 14:39:40 +00:00
Kristoffer Dalby cff67806cb state: write node rows from the NodeStore under persistMu 2026-10-28 14:39:25 +00:00
Kristoffer Dalby 3cf284917d state: apply map requests only under the node key that authorised them 2026-10-28 14:38:12 +00:00
Kristoffer Dalby b36f9d443f policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 14:38:11 +00:00
Kristoffer Dalby a188777784 mapper: send a router all of its own routes
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 013ec0b59f policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 14:38:10 +00:00
Kristoffer Dalby 306a3d0f25 api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 14:38:09 +00:00