Kristoffer Dalby
a02a4e6c2e
state: honour SSH check approvals only while the source keeps its owner
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
ed0dd703f9
.github: regenerate integration test workflow
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
1c17be4dd8
state: give another user's key on a tagged machine a new device
...
Only a key that speaks for a tagged node re-authenticates it: a tagged
key, or one of the user it was tagged from, which takes it back with a
new node key. Another user's key or login adds that user's own device.
2026-10-28 07:15:54 +00:00
Kristoffer Dalby
c48767eed6
state: let a pre-auth key that is no longer valid only wake its node
...
A login that keeps its node key leaves a live node's expiry alone, even
with a valid key, and a wake-up is not refused for the tags it requests.
2026-10-28 00:52:20 +00:00
Kristoffer Dalby
6c42055047
state: need a valid pre-auth key to re-register an expired tagged node
2026-10-28 00:52:20 +00:00
Kristoffer Dalby
fd8b0e0a5c
state: serialise registrations presenting an unused single-use key
2026-10-28 00:52:20 +00:00
Kristoffer Dalby
54e2474146
state: auto-approve routes in the NodeStore writer, not on reload
...
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-28 00:52:20 +00:00
Kristoffer Dalby
2205b30d9c
state: undo a failed re-registration without reverting newer writes
2026-10-28 00:52:20 +00:00
Kristoffer Dalby
88b340afe7
state: write node rows from the NodeStore under persistMu
2026-10-28 00:51:40 +00:00
Kristoffer Dalby
96520f367a
state: apply map requests only under the node key that authorised them
2026-10-28 00:51:40 +00:00
Kristoffer Dalby
850c5d3fbb
policy: offer exit routes only to viewers whose rules reach the internet
...
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-28 00:51:40 +00:00
Kristoffer Dalby
690fe40616
mapper: send a router all of its own routes
...
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-28 00:51:40 +00:00
Kristoffer Dalby
780c9406ae
policy: reduce merged destination prefixes to the node's own addresses
...
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-28 00:51:40 +00:00
Kristoffer Dalby
2cb84b2905
api, policy/v2: refuse route prefixes with host bits
...
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
9d5d397c1d
state: never serve a single address inside the node ranges
...
Such a route names a node, not a subnet: it stays approved and listed
but no viewer gets it. Via inclusions skip the election, so the rule
sits on everything RoutesForPeer returns.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
144629e11e
policy, state: log only the routes auto-approval adds
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
ee1a3085c0
poll: hold the map session's node as a view
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
1dcd8ff4cd
policy/matcher, types: compare a node's routes to matchers as ranges
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
3a13b2e40a
policy/matcher: binary-search ranges in overlap checks
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
90f873ee66
policy: look up approved routes in a set when auto-approving
...
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
21fd9f1366
types, state: reduce a node's routes against the matchers once
...
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
2d2bfe8fd2
types: derive subnet and exit routes in one pass
...
Emit each approved route once, in announcement order.
Skip derivation when no routes are approved.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
4d007eb5e9
state: skip route comparison for writes that leave routes alone
...
Reuse immutable route inputs when classifying NodeStore writes.
Only derive routes when an announcement or approval changes.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
4cafc80fbd
state, policy/v2: stop treating announced-only routes as policy changes
...
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
4d1e8aa0c1
policy/v2, state: elect primaries by oldest control session
...
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
e26c0059f3
types: add when a node's run of control sessions began
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
d59e14b197
state: keep a prefix mapped when no router is available
...
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
7daa08e94e
policy/v2, state: elect via primaries among online, healthy routers
...
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
fe42e17a30
state: withhold HA probe results only for routers tied to a deferred one
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
b95f19e0d8
state: keep probing a lone advertiser while it is unhealthy
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
1864e7a284
hscontrol, types: strip trailing slashes from server_url
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
857e3fe5be
db: bound the wait for a legacy hash verification slot
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
cbe5883e95
db: reload the credential row after a legacy hash verification
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
c827dc8fdc
db: disable GORM's prepared statement cache on SQLite
...
database.gorm.prepare_stmt is now ignored, with a startup warning.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
e6302ce9b6
policy/v2: refuse check SSH rules with tag sources
...
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
7fa1aa7d66
policy/v2: limit the destination and port pairs a policy declares
...
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
f2924f39e6
policy/v2: refuse a port list in a grant ip entry
...
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
a0ae68f22b
policy/v2: evaluate policy tests before taking the write lock
...
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
350aea66f4
policy/v2: index compiled SSH rules by source for sshTests
...
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
ea9f099657
policy/v2: parse the compiled filter once per tests run
...
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
643ed8bfc6
policy/v2: need every dst node for a tests accept, no range sources
...
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
bda2cb5076
policy/v2: label sshTests failures with the dst alias
...
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
649985954f
policy/v2: bound the tests and sshTests failure report
...
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
76bdf3adad
policy/v2: refuse autogroup:member as an sshTests destination
...
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-28 00:51:39 +00:00
Kristoffer Dalby
124efeeaa0
policy/v2: refuse address ranges as sshTests sources
...
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby
a70a567ab7
policy/v2: map login 0 to no local user in SSH rules
...
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-27 21:32:32 +00:00
Kristoffer Dalby
1eab82f7f5
policy/v2: write an ACL's repeated destination once
...
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby
b4b2322182
policy/v2: write a single-address via destination bare
...
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby
c294109190
db: keep only the current policy
...
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby
f24fad2ccc
state: install a written policy only after it is stored
...
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-27 21:32:32 +00:00