Commit Graph
4881 Commits
Author SHA1 Message Date
Kristoffer Dalby cc36764a4b state: serialise registrations presenting an unused single-use key 2026-10-27 21:32:33 +00:00
Kristoffer Dalby d47d94be0a state: auto-approve routes in the NodeStore writer, not on reload
Registration approval runs on the node the writer replaces. A policy
reload approves nothing, and a map request only when its announced
routes change, so neither re-grants a route an admin revoked.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 64f606e2ab state: undo a failed re-registration without reverting newer writes 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 7c8fcd2393 state: write node rows from the NodeStore under persistMu 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 8bd19d56a5 state: apply map requests only under the node key that authorised them 2026-10-27 21:32:33 +00:00
Kristoffer Dalby a9ad49f9a6 policy: offer exit routes only to viewers whose rules reach the internet
Every destination overlaps /0, so any rule offered a peer's exit routes.
They now need a rule to the internet, the test exit-node visibility
uses; via steering defers them to a regular grant only on that test.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 701138104c mapper: send a router all of its own routes
Its AllowedIPs held only the primaries the policy let it reach. It now
holds every approved route, and PrimaryRoutes the ones it serves.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 5d8a8f993c policy: reduce merged destination prefixes to the node's own addresses
Adjacent node addresses merge into one prefix, and each node's filter
kept all of it. A prefix made only of node addresses now shrinks to the
node's own; a prefix the policy wrote, or one the node routes, stays.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 2abcf2b44a api, policy/v2: refuse route prefixes with host bits
Routes are matched as written, so such a prefix never equals the one a
client announces. The approval APIs answer 400 and autoApprovers refuses
it at load and write, with Tailscale's text.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 04b0938240 state: never serve a single address inside the node ranges
Such a route names a node, not a subnet: it stays approved and listed
but no viewer gets it. Via inclusions skip the election, so the rule
sits on everything RoutesForPeer returns.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 3a29d86098 policy, state: log only the routes auto-approval adds 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 02ff84e89f poll: hold the map session's node as a view 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 05307fe7ad policy/matcher, types: compare a node's routes to matchers as ranges 2026-10-27 21:32:33 +00:00
Kristoffer Dalby f61a7cfafe policy/matcher: binary-search ranges in overlap checks 2026-10-27 21:32:33 +00:00
Kristoffer Dalby ae6cd03310 policy: look up approved routes in a set when auto-approving
Avoid scanning the growing approval list for every announcement.
Use the sorted current routes when identifying additions.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 6d03e39830 types, state: reduce a node's routes against the matchers once
Reuse matcher membership and approved subnets across the route list.
Preserve route order and HA co-router visibility.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 6ce2a4c9f7 types: derive subnet and exit routes in one pass
Emit each approved route once, in announcement order.
Skip derivation when no routes are approved.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 3c698721a2 state: skip route comparison for writes that leave routes alone
Reuse immutable route inputs when classifying NodeStore writes.
Only derive routes when an announcement or approval changes.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 60de984ada state, policy/v2: stop treating announced-only routes as policy changes
Policy evaluation reads only announced-and-approved routes.
Keep publishing Hostinfo updates without rebuilding peer adjacency.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 6f9b5ac737 policy/v2, state: elect primaries by oldest control session
A router that reconnects joins as a standby; one that kept its session
takes its routes back once available again, as on Tailscale. Both the
global and the via election use it, in place of anti-flap stickiness.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby ec28e29209 types: add when a node's run of control sessions began 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 1389857702 state: keep a prefix mapped when no router is available
Peers keep the routes of an offline or expired router, as on Tailscale.
The previous primary keeps the prefix, else the lowest-ID approver;
never one the prober declared unreachable.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby dbd7e8e986 policy/v2, state: elect via primaries among online, healthy routers
Availability tests expiry itself, not only the online flag.
A health change on a via target now triggers a peer recompute.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby e6f2615f3e state: withhold HA probe results only for routers tied to a deferred one 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 9e26630a1a state: keep probing a lone advertiser while it is unhealthy 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 33303570e3 hscontrol, types: strip trailing slashes from server_url 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 3da801b2b2 db: bound the wait for a legacy hash verification slot 2026-10-27 21:32:33 +00:00
Kristoffer Dalby f321e384d4 db: reload the credential row after a legacy hash verification 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 788216a2b8 db: disable GORM's prepared statement cache on SQLite
database.gorm.prepare_stmt is now ignored, with a startup warning.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 559a8f1c4d policy/v2: refuse check SSH rules with tag sources
A check asks the source's user to log in again, and a tagged node has
none. Tailscale SaaS refuses the rule; headscale accepted it.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 561c0c4aec policy/v2: limit the destination and port pairs a policy declares
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby e05f34b8f0 policy/v2: refuse a port list in a grant ip entry
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 1df5577519 policy/v2: evaluate policy tests before taking the write lock
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby d47a7845e3 policy/v2: index compiled SSH rules by source for sshTests
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby c483d2e601 policy/v2: parse the compiled filter once per tests run
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby b7c043e33e policy/v2: need every dst node for a tests accept, no range sources
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 95890f8e31 policy/v2: label sshTests failures with the dst alias
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 34da44b48a policy/v2: bound the tests and sshTests failure report
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby e6747324d2 policy/v2: refuse autogroup:member as an sshTests destination
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 124efeeaa0 policy/v2: refuse address ranges as sshTests sources
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby a70a567ab7 policy/v2: map login 0 to no local user in SSH rules
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 1eab82f7f5 policy/v2: write an ACL's repeated destination once
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby b4b2322182 policy/v2: write a single-address via destination bare
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby c294109190 db: keep only the current policy
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby f24fad2ccc state: install a written policy only after it is stored
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 3a57f3a6e3 policy/v2: refuse an empty policy
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 3e9dc82f20 policy/v2: resolve tag owners one hop deep
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby bd63cdd767 policy/v2: evaluate sshTests sources through the nodes they cover
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby 6d1f582fdf policy/v2: resolve each group once per policy compile
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-27 21:32:32 +00:00
Kristoffer Dalby b00456eb02 policy/v2: compile SSH rules once and share them across nodes
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-27 21:32:32 +00:00