Commit Graph
4978 Commits
Author SHA1 Message Date
Kristoffer Dalby db39e157af policy/v2, servertest: compare router peers in tailnet overlap captures
SaaS gives each router every device as a peer, whatever the policy
links, and the devices do not list the router back.
Headscale peers a router only with what its policy links.
2026-10-27 23:08:57 +00:00
Kristoffer Dalby c92c325424 policy/v2: add deny test captures that pass while access remains
SaaS passes a tests deny when one node of the dst alias, or one member
of a group source, is blocked, though another still gets in. Headscale
fails the dst case; it passes the group case as SaaS does.
2026-10-27 23:07:37 +00:00
Kristoffer Dalby 3b6d6ee69a policy/v2, servertest: add group source split across rules captures
SaaS judges a tests or sshTests group source by one rule naming the
group: per-member rules fail a true accept and pass a false deny.
Headscale checks each member through its own rules.
2026-10-27 23:06:50 +00:00
Kristoffer Dalby e9d9d4234a policy/v2, servertest: add bare IPv6 sshTests destination capture
SaaS fails an accept to a bare IPv6 dst, checking the source at
::ffff:100.64.0.0, which no device holds; the IPv4 twin passes.
Headscale checks the source's own addresses and accepts.
2026-10-27 23:05:40 +00:00
Kristoffer Dalby 934b1e80cf gen/client/v2: regenerate for the acl/validate endpoint 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 52c4f6b2c4 api/v2: add the acl/validate endpoint
It checks a policy as a write would, without storing it. As on
Tailscale, a refused policy answers 200 with its reason; only an empty
body is a 400.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby a3d9e01eff docs: describe what OAuth scopes and tags limit 2026-10-27 21:32:34 +00:00
Kristoffer Dalby c225f2263f api/v2: require a token to hold a device's current tags to retag it
SetNodeTags replaces the tag set, so the tags it removes need the grant
too. A tag outside the grant answers 400, as on Tailscale SaaS.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby e714dbe455 api/v2: name the token's tags in the token answer
Only a token that can assign tags names them, as Tailscale's answer
does.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 0450fd9240 api/v2: send empty route lists under fields=all 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 061755debe gen/client/v2: regenerate for the device's join key 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 6a1f415ab8 api/v2: name the join key in a device's oauthClientId
For a key a token made, Tailscale names the token's client, which is
not recorded, so the field is left out.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby e70c50536a api/v2: show a tagged device's creator as its user
A tagged device shows the login that made the key it joined with.
Its owner stays its tags.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 0c995da6af gen/client/v2: regenerate for the key list without all=true 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 03d3af0ae7 api/v2: list token-made auth keys to a token without all=true
Keys an OAuth token makes are marked so. No listing holds an invalid
key.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 8f4e63bf8e db, types: add a credentials column for keys a token made
No released version made keys from tokens, so existing rows stay false.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby a129c73838 api/v2: show userId on admin-made tagged keys
An admin key's user is recorded as the creator of the tagged keys it
makes. A tagged key re-registers a machine by its tags, whoever made it.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby a76f6b5166 api/v2: return a device name as its FQDN 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 6e82cbd5ad api/v2: refuse an unknown keyType 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 3bca54f6c4 api/v2: ignore unknown properties in request bodies
Tailscale's API ignores them.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 6aac892e7b db: keep at most 1000 access tokens per OAuth client
Minting needs only the client secret, whatever its scopes, and
added one row per mint. Each mint now ends tokens past the newest 1000.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 4d82a3e06e api/v2: check the createKey scope before reading the body
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 697fa25712 api/v2: stop echoing request values in error responses
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 0598db4f33 api/v2: bound every request body
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 2d6293b106 api/v2: keep a tagged all-scope client's tokens inside its tags
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 89c15dd642 debug: refuse requests addressed to unknown host names 2026-10-27 21:32:34 +00:00
Kristoffer Dalby fa13cb9789 types: accept only lowercase hex in auth IDs 2026-10-27 21:32:34 +00:00
Kristoffer Dalby a7fb8ecb44 oidc: show requested tags on the registration confirmation page 2026-10-27 21:32:34 +00:00
Kristoffer Dalby b6ec88c5e9 oidc: show on the confirmation page whether the device is registered 2026-10-27 21:32:34 +00:00
Kristoffer Dalby c945cdea05 oidc: approve SSH checks on the confirmation page, not in the callback
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby 56b1421b06 policy/v2: match no user for a bare "@" token 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 17664e3adc policy/v2: match no one for an ambiguous user outside policy writes
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby bf5007add8 policy/v2: prefer the user owning an email over a username match 2026-10-27 21:32:34 +00:00
Kristoffer Dalby fc560108a2 policy/v2: check grant and nodeAttrs user references on write
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-27 21:32:34 +00:00
Kristoffer Dalby c8c2b451d8 cli: validate offline policy set like policy check 2026-10-27 21:32:34 +00:00
Kristoffer Dalby dc86639c00 types: reject non-boolean values for boolean settings 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 48e6fc0c73 oidc: send the change from the user update in the callback 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 12f6b6f10f state: refresh the NodeStore copies of a user in UpdateUser 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 8014416648 types: drop a stored OIDC email the login no longer vouches for 2026-10-27 21:32:34 +00:00
Kristoffer Dalby 17c4778b30 state: write every user column in UpdateUser 2026-10-27 21:32:34 +00:00
Kristoffer Dalby d435721dc1 oidc: refuse logins whose subject the provider identifier would alter 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 837ec60e00 oidc: keep email_verified with the address it came with 2026-10-27 21:32:33 +00:00
Kristoffer Dalby be787616e7 state: announce a node online only after it was offline
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 814c2109c3 change: do not echo a node's own report back to it
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 4ed4cb539a mapper: add device_id to the NextDNS query
SaaS sends the node's stable ID with the other device metadata.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby bb6da35417 policy/v2: warn once at load about malformed nextdns attrs
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby edf448bf0d mapper: test that a hidden peer's policy change still sends filters 2026-10-27 21:32:33 +00:00
Kristoffer Dalby 0cee52ebdb state, change: send a deleted node's removal only to its peers
The removal went to every node, also those the policy hid the node from.
The delete now returns the node's peers from the snapshot it replaces.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby b9886dbf18 mapper: stop an older initial map removing peers newer streams hold
AddNode diffed its map against tracking after sending it, when a newer
stream may have recorded its own; it now sends the node a full instead.
2026-10-27 21:32:33 +00:00
Kristoffer Dalby 52d1a8a191 mapper: bound how long one node can block a batcher worker
A node that drained slower than it was sent to held the worker for its
whole bundle; once its sends have waited 50ms, the rest waits a tick.
2026-10-27 21:32:33 +00:00