Kristoffer Dalby
dd54370187
hscontrol: compare a waiting login when key expiry is turned off
...
SaaS answers a waiting login once an admin turns the device's key expiry
off, with the client's newest node key and no login. Headscale keeps
the login waiting.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
e6e1d9214c
hscontrol: compare a tag-limited token's untagged child client
...
SaaS lets a tag:ci token create an untagged all-scope client whose token
takes tag:prod and mints a tag:prod key. Headscale refuses the client,
so the step that mints its token and key is not replayed.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
89514afc81
hscontrol: compare a zero-length policy write
...
SaaS takes an empty POST /acl as a reset to its allow-all default, while
its validate refuses the same body. Headscale's v1 and v2 refuse both.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
848063b6d1
servertest: compare a single-use key presented by three devices
...
SaaS converts two live devices that keep their node key with one
single-use key, spends it only on a third with a new node key, and
keeps key expiry on for a same-key conversion. Headscale spends it once.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
bcb0199a80
policy/v2, servertest: compare router peers in tailnet overlap captures
...
SaaS gives each router every device as a peer, whatever the policy
links, and the devices do not list the router back.
Headscale peers a router only with what its policy links.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
e606c28608
policy/v2: add deny test captures that pass while access remains
...
SaaS passes a tests deny when one node of the dst alias, or one member
of a group source, is blocked, though another still gets in. Headscale
fails the dst case; it passes the group case as SaaS does.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
2afcbf6777
policy/v2, servertest: add group source split across rules captures
...
SaaS judges a tests or sshTests group source by one rule naming the
group: per-member rules fail a true accept and pass a false deny.
Headscale checks each member through its own rules.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
283a759107
policy/v2, servertest: add bare IPv6 sshTests destination capture
...
SaaS fails an accept to a bare IPv6 dst, checking the source at
::ffff:100.64.0.0, which no device holds; the IPv4 twin passes.
Headscale checks the source's own addresses and accepts.
2026-10-28 16:35:53 +00:00
Kristoffer Dalby
8b9d1385e1
gen/client/v2: regenerate for the acl/validate endpoint
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
92e90f657e
api/v2: add the acl/validate endpoint
...
It checks a policy as a write would, without storing it. As on
Tailscale, a refused policy answers 200 with its reason; only an empty
body is a 400.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
8d2360930f
docs: describe what OAuth scopes and tags limit
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
7ee430806f
api/v2: require a token to hold a device's current tags to retag it
...
SetNodeTags replaces the tag set, so the tags it removes need the grant
too. A tag outside the grant answers 400, as on Tailscale SaaS.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
c8e2908cb9
api/v2: name the token's tags in the token answer
...
Only a token that can assign tags names them, as Tailscale's answer
does.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
ca259fbfb7
api/v2: send empty route lists under fields=all
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
7f181a27b9
gen/client/v2: regenerate for the device's join key
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
f0df7e12ad
api/v2: name the join key in a device's oauthClientId
...
For a key a token made, Tailscale names the token's client, which is
not recorded, so the field is left out.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
01c296599a
api/v2: show a tagged device's creator as its user
...
A tagged device shows the login that made the key it joined with.
Its owner stays its tags.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
9b9c0161bf
gen/client/v2: regenerate for the key list without all=true
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
a148438619
api/v2: list token-made auth keys to a token without all=true
...
Keys an OAuth token makes are marked so. No listing holds an invalid
key.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
039856026f
db, types: add a credentials column for keys a token made
...
No released version made keys from tokens, so existing rows stay false.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
216105dffe
api/v2: show userId on admin-made tagged keys
...
An admin key's user is recorded as the creator of the tagged keys it
makes. A tagged key re-registers a machine by its tags, whoever made it.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
3fe677ea1c
api/v2: return a device name as its FQDN
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
01a88b9c20
api/v2: refuse an unknown keyType
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
0ca8952b46
api/v2: ignore unknown properties in request bodies
...
Tailscale's API ignores them.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
e2ddea6b4f
db: keep at most 1000 access tokens per OAuth client
...
Minting needs only the client secret, whatever its scopes, and
added one row per mint. Each mint now ends tokens past the newest 1000.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
14c4363030
api/v2: check the createKey scope before reading the body
...
createKey has no static scope, so any token got its body parsed
and validated before the handler's scope check.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
edc228a8cd
api/v2: stop echoing request values in error responses
...
huma sets an unexpected property's value to the whole request object.
A refused policy, or another 400, now carries its reason in message,
and a failed test run one data entry per failing test naming its src.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
01924fa8be
api/v2: bound every request body
...
huma gives RawBody no limit, and validates a whole body before
the handler runs. The token form is parsed before the secret check.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
7722e33a60
api/v2: keep a tagged all-scope client's tokens inside its tags
...
Only an untagged all-scope client may mint tokens for any tag, so a
tagged token may not create one.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
59629e7a9e
debug: refuse requests addressed to unknown host names
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
d87e789246
types: accept only lowercase hex in auth IDs
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
072bc83141
oidc: show requested tags on the registration confirmation page
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
2089d9b03f
oidc: show on the confirmation page whether the device is registered
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
2e99e5fdba
oidc: approve SSH checks on the confirmation page, not in the callback
...
Require an explicit click before recording the SSH verdict.
Recheck source ownership on the callback, confirmation page, and POST.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
c5fbc67726
policy/v2: match no user for a bare "@" token
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
c694c4a9ac
policy/v2: match no one for an ambiguous user outside policy writes
...
A change to user identifiers must not block startup or later logins.
Keep policy writes strict; log ambiguous references on load and refresh.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
f18748713b
policy/v2: prefer the user owning an email over a username match
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
1d0cc19913
policy/v2: check grant and nodeAttrs user references on write
...
Validation now refuses every input that reached the SetPolicy compile
failure, so restoring the previous policy there is defensive only.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
4a49d1af7c
cli: validate offline policy set like policy check
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
8278e001d9
types: reject non-boolean values for boolean settings
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
58a9391acf
oidc: send the change from the user update in the callback
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
3b2d393d82
state: refresh the NodeStore copies of a user in UpdateUser
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
5437ce88ef
types: drop a stored OIDC email the login no longer vouches for
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
1cfc14360f
state: write every user column in UpdateUser
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
10e6ce6295
oidc: refuse logins whose subject the provider identifier would alter
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
f809e82fec
state: announce a node online only after it was offline
...
A stream back within the reconnect grace sent peers an online patch,
a router's sent every node a policy response, and a relogin on
unchanged keys sent a key patch; nothing had changed.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
1a92777b4f
change: do not echo a node's own report back to it
...
An endpoint or DERP report came back to the node as a self update;
SaaS sends it to the node's peers only.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
c3b61f6d58
mapper: add device_id to the NextDNS query
...
SaaS sends the node's stable ID with the other device metadata.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
134829322b
policy/v2: warn once at load about malformed nextdns attrs
...
SaaS loads them and its resolver skips them, as headscale does, but the
mapper also logged a warning per node on every DNS build.
2026-10-28 16:35:22 +00:00
Kristoffer Dalby
d203f23620
mapper: test that a hidden peer's policy change still sends filters
2026-10-28 16:35:22 +00:00