fix(web): clear unsaved asset description when changing asset (#26255)
Some checks failed
CodeQL / Analyze (javascript) (push) Has been cancelled
CodeQL / Analyze (python) (push) Has been cancelled
Docker / pre-job (push) Has been cancelled
Docker / Re-Tag ML () (push) Has been cancelled
Docker / Re-Tag ML (-armnn) (push) Has been cancelled
Docker / Re-Tag ML (-cuda) (push) Has been cancelled
Docker / Re-Tag ML (-openvino) (push) Has been cancelled
Docker / Re-Tag ML (-rknn) (push) Has been cancelled
Docker / Re-Tag ML (-rocm) (push) Has been cancelled
Docker / Re-Tag Server () (push) Has been cancelled
Docker / Build and Push ML (armnn, linux/arm64, -armnn) (push) Has been cancelled
Docker / Build and Push ML (cpu) (push) Has been cancelled
Docker / Build and Push ML (cuda, linux/amd64, -cuda) (push) Has been cancelled
Docker / Build and Push ML (openvino, linux/amd64, -openvino) (push) Has been cancelled
Docker / Build and Push ML (rknn, linux/arm64, -rknn) (push) Has been cancelled
Docker / Build and Push ML (rocm, linux/amd64, {"linux/amd64": "pokedex-giant"}, -rocm) (push) Has been cancelled
Docker / Build and Push Server (push) Has been cancelled
Docker / Docker Build & Push Server Success (push) Has been cancelled
Docker / Docker Build & Push ML Success (push) Has been cancelled
Docs build / pre-job (push) Has been cancelled
Docs build / Docs Build (push) Has been cancelled
Zizmor / Zizmor (push) Has been cancelled
Manage release PR / bump (push) Has been cancelled
Static Code Analysis / pre-job (push) Has been cancelled
Static Code Analysis / Run Dart Code Analysis (push) Has been cancelled
Test / pre-job (push) Has been cancelled
Test / Test & Lint Server (push) Has been cancelled
Test / Unit Test CLI (push) Has been cancelled
Test / Unit Test CLI (Windows) (push) Has been cancelled
Test / Lint Web (push) Has been cancelled
Test / Test Web (push) Has been cancelled
Test / Test i18n (push) Has been cancelled
Test / End-to-End Lint (push) Has been cancelled
Test / Medium Tests (Server) (push) Has been cancelled
Test / End-to-End Tests (Server & CLI) (ubuntu-24.04-arm) (push) Has been cancelled
Test / End-to-End Tests (Server & CLI) (ubuntu-latest) (push) Has been cancelled
Test / End-to-End Tests (Web) (ubuntu-24.04-arm) (push) Has been cancelled
Test / End-to-End Tests (Web) (ubuntu-latest) (push) Has been cancelled
Test / End-to-End Tests Success (push) Has been cancelled
Test / Unit Test Mobile (push) Has been cancelled
Test / Unit Test ML (push) Has been cancelled
Test / .github Files Formatting (push) Has been cancelled
Test / ShellCheck (push) Has been cancelled
Test / OpenAPI Clients (push) Has been cancelled
Test / SQL Schema Checks (push) Has been cancelled

* fix(web): clear unsaved asset description when changing asset

* remove unneeded $derived
This commit is contained in:
Michel Heusschen
2026-02-16 18:25:13 +01:00
committed by GitHub
parent cc9c261fd0
commit 0da74569f2
2 changed files with 67 additions and 2 deletions

View File

@@ -0,0 +1,65 @@
import { assetFactory } from '@test-data/factories/asset-factory';
import '@testing-library/jest-dom';
import { render, screen } from '@testing-library/svelte';
import userEvent from '@testing-library/user-event';
import DetailPanelDescription from './detail-panel-description.svelte';
describe('DetailPanelDescription', () => {
it('clears unsaved draft on asset change', async () => {
const user = userEvent.setup();
const assetA = assetFactory.build({
id: 'asset-a',
exifInfo: { description: '' },
});
const assetB = assetFactory.build({
id: 'asset-b',
exifInfo: { description: '' },
});
const { rerender } = render(DetailPanelDescription, {
props: {
asset: assetA,
isOwner: true,
},
});
const textarea = screen.getByTestId('autogrow-textarea') as HTMLTextAreaElement;
await user.type(textarea, 'unsaved draft');
expect(textarea).toHaveValue('unsaved draft');
await rerender({
asset: assetB,
isOwner: true,
});
expect(screen.getByTestId('autogrow-textarea')).toHaveValue('');
});
it('updates description on asset switch', async () => {
const assetA = assetFactory.build({
id: 'asset-a',
exifInfo: { description: 'first description' },
});
const assetB = assetFactory.build({
id: 'asset-b',
exifInfo: { description: 'second description' },
});
const { rerender } = render(DetailPanelDescription, {
props: {
asset: assetA,
isOwner: true,
},
});
expect(screen.getByTestId('autogrow-textarea')).toHaveValue('first description');
await rerender({
asset: assetB,
isOwner: true,
});
expect(screen.getByTestId('autogrow-textarea')).toHaveValue('second description');
});
});

View File

@@ -13,10 +13,10 @@
let { asset, isOwner }: Props = $props();
let currentDescription = $derived(asset.exifInfo?.description ?? '');
let description = $derived(currentDescription);
let description = $derived(asset.exifInfo?.description ?? '');
const handleFocusOut = async () => {
const currentDescription = asset.exifInfo?.description ?? '';
if (description === currentDescription) {
return;
}