Read the password digest past the query cache

A digest cached earlier in the request would let the check pass on a password that has since changed.

(cherry picked from commit c3faccb0f4)
This commit is contained in:
Jeremy Daer authored and Jeremy Daer committed 2026-10-20 20:45:36 -07:00
1 parent 48da2b4e4e
commit 09402c7752
1 file changed
+3 -3
+3 -3
View File
@@ -18,10 +18,10 @@ class Session < ApplicationRecord
private
# A password change ends every session, so one can't start on a password checked before the change. Validated in
# the save's transaction, which holds the database's write lock from the start, so a change commits either before
# this check, and fails it, or after the insert, and ends this session with the others. Compared here rather than in
# the query, which logs its values.
# this check, and fails it, or after the insert, and ends this session with the others. Read past the query cache,
# and compared here rather than in the query, which logs its values.
def user_password_unchanged
unless User.where(id: user_id).pick(:password_digest) == user.password_digest
unless User.uncached { User.where(id: user_id).pick(:password_digest) } == user.password_digest
errors.add :user, :invalid
end
end