public/once-campfire
1
0
Fork 0
mirror of https://github.com/basecamp/once-campfire.git synced 2026-10-08 15:50:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #323: Count unread rooms for push badges once per batch

Browse Source 
Reviewed and merged by GPT on behalf of DHH.
This commit is contained in:
GPT on behalf of DHH
2026-10-07 10:32:12 +02:00
parent b6d307537e d485db6038
commit 819b3896fb
4 changed files with 72 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/models/push/subscription_test.rb
+9
View File
@@ -125,6 +125,15 @@ class Push::SubscriptionTest < ActiveSupport::TestCase
subscription.notification(title: "t", body: "b", path: "/").deliver
end
test "the badge defaults to the subscriber's unread room count" do
memberships(:david_pets).update! unread_at: Time.current
memberships(:david_hq).update! unread_at: Time.current
subscription = build_subscription(endpoint: "https://fcm.googleapis.com/fcm/send/abc123")
WebPush.expects(:payload_send).with { |options| JSON.parse(options[:message]).dig("options", "data", "badge") == 2 }
subscription.notification(title: "t", body: "b", path: "/").deliver
end
test "delivery sends with the pinned endpoint_ip" do
subscription = build_subscription(endpoint: "https://fcm.googleapis.com/fcm/send/abc123")