mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-28 00:16:48 +09:00
Compare commits
35
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d1376a97ee | ||
|
|
d3f22d78e1 | ||
|
|
2aa4141077 | ||
|
|
27e9257b2a | ||
|
|
dd247a623b | ||
|
|
3b509f55ca | ||
|
|
ee37809220 | ||
|
|
5c5c82b27a | ||
|
|
2d749057f9 | ||
|
|
d28ab55bf4 | ||
|
|
50f25cea80 | ||
|
|
d79225ecd1 | ||
|
|
b065b40a34 | ||
|
|
69e8cd7885 | ||
|
|
c0cade51a1 | ||
|
|
80fdd44622 | ||
|
|
4cfcc2a370 | ||
|
|
9085adcbb3 | ||
|
|
0de302c977 | ||
|
|
9fb419e469 | ||
|
|
df5ed25e14 | ||
|
|
048ef90ae7 | ||
|
|
ea994053ea | ||
|
|
018a0b5dd9 | ||
|
|
38741c53f1 | ||
|
|
cf0a67fcaf | ||
|
|
e945d4217b | ||
|
|
cccfb8f774 | ||
|
|
55fbf16629 | ||
|
|
9ebc47a8f0 | ||
|
|
962c48af13 | ||
|
|
0920ceab6b | ||
|
|
12bb943af8 | ||
|
|
e4f88b425a | ||
|
|
bfa9f66633 |
No files matched your search
@@ -67,6 +67,17 @@ jobs:
|
|||||||
CANONICAL_IMAGE="${REGISTRY}/${IMAGE_REF,,}"
|
CANONICAL_IMAGE="${REGISTRY}/${IMAGE_REF,,}"
|
||||||
echo "canonical=${CANONICAL_IMAGE}" >> "$GITHUB_OUTPUT"
|
echo "canonical=${CANONICAL_IMAGE}" >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
|
- name: Compute app version
|
||||||
|
id: version
|
||||||
|
shell: bash
|
||||||
|
run: |
|
||||||
|
set -eu
|
||||||
|
if [[ "${GITHUB_REF}" == refs/tags/v* ]]; then
|
||||||
|
echo "version=${GITHUB_REF#refs/tags/v}" >> "$GITHUB_OUTPUT"
|
||||||
|
else
|
||||||
|
echo "version=${GITHUB_SHA::7}" >> "$GITHUB_OUTPUT"
|
||||||
|
fi
|
||||||
|
|
||||||
- name: Extract Docker metadata (tags, labels) with arch suffix
|
- name: Extract Docker metadata (tags, labels) with arch suffix
|
||||||
id: meta
|
id: meta
|
||||||
uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f # v5.8.0
|
uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f # v5.8.0
|
||||||
@@ -94,6 +105,8 @@ jobs:
|
|||||||
build-args: |
|
build-args: |
|
||||||
OCI_SOURCE=${{ env.SOURCE_URL }}
|
OCI_SOURCE=${{ env.SOURCE_URL }}
|
||||||
OCI_DESCRIPTION=${{ env.IMAGE_DESCRIPTION }}
|
OCI_DESCRIPTION=${{ env.IMAGE_DESCRIPTION }}
|
||||||
|
APP_VERSION=${{ steps.version.outputs.version }}
|
||||||
|
GIT_REVISION=${{ github.sha }}
|
||||||
platforms: ${{ matrix.platform }}
|
platforms: ${{ matrix.platform }}
|
||||||
push: ${{ github.event_name != 'pull_request' }}
|
push: ${{ github.event_name != 'pull_request' }}
|
||||||
tags: ${{ steps.meta.outputs.tags }}
|
tags: ${{ steps.meta.outputs.tags }}
|
||||||
|
|||||||
@@ -66,6 +66,9 @@ ENV HTTP_WRITE_TIMEOUT=300
|
|||||||
COPY --from=build --chown=rails:rails /usr/local/bundle /usr/local/bundle
|
COPY --from=build --chown=rails:rails /usr/local/bundle /usr/local/bundle
|
||||||
COPY --from=build --chown=rails:rails /rails /rails
|
COPY --from=build --chown=rails:rails /rails /rails
|
||||||
|
|
||||||
|
# Install ONCE backup/restore hooks
|
||||||
|
COPY --chmod=755 hooks /hooks
|
||||||
|
|
||||||
# Set version and revision
|
# Set version and revision
|
||||||
ARG APP_VERSION
|
ARG APP_VERSION
|
||||||
ENV APP_VERSION=$APP_VERSION
|
ENV APP_VERSION=$APP_VERSION
|
||||||
|
|||||||
+23
-23
@@ -137,7 +137,7 @@ GEM
|
|||||||
bcrypt (3.1.22)
|
bcrypt (3.1.22)
|
||||||
benchmark (0.5.0)
|
benchmark (0.5.0)
|
||||||
bigdecimal (3.3.1)
|
bigdecimal (3.3.1)
|
||||||
brakeman (8.0.4)
|
brakeman (8.0.5)
|
||||||
racc
|
racc
|
||||||
builder (3.3.0)
|
builder (3.3.0)
|
||||||
bundler-audit (0.9.3)
|
bundler-audit (0.9.3)
|
||||||
@@ -153,13 +153,13 @@ GEM
|
|||||||
regexp_parser (>= 1.5, < 3.0)
|
regexp_parser (>= 1.5, < 3.0)
|
||||||
xpath (~> 3.2)
|
xpath (~> 3.2)
|
||||||
chunky_png (1.4.0)
|
chunky_png (1.4.0)
|
||||||
concurrent-ruby (1.3.5)
|
concurrent-ruby (1.3.7)
|
||||||
connection_pool (2.5.5)
|
connection_pool (2.5.5)
|
||||||
crack (1.0.0)
|
crack (1.0.0)
|
||||||
bigdecimal
|
bigdecimal
|
||||||
rexml
|
rexml
|
||||||
crass (1.0.6)
|
crass (1.0.7)
|
||||||
date (3.5.0)
|
date (3.5.1)
|
||||||
debug (1.11.0)
|
debug (1.11.0)
|
||||||
irb (~> 1.10)
|
irb (~> 1.10)
|
||||||
reline (>= 0.3.8)
|
reline (>= 0.3.8)
|
||||||
@@ -191,7 +191,7 @@ GEM
|
|||||||
jbuilder (2.14.1)
|
jbuilder (2.14.1)
|
||||||
actionview (>= 7.0.0)
|
actionview (>= 7.0.0)
|
||||||
activesupport (>= 7.0.0)
|
activesupport (>= 7.0.0)
|
||||||
json (2.13.2)
|
json (2.20.0)
|
||||||
jwt (3.2.0)
|
jwt (3.2.0)
|
||||||
base64
|
base64
|
||||||
kredis (1.8.0)
|
kredis (1.8.0)
|
||||||
@@ -201,7 +201,7 @@ GEM
|
|||||||
language_server-protocol (3.17.0.5)
|
language_server-protocol (3.17.0.5)
|
||||||
lint_roller (1.1.0)
|
lint_roller (1.1.0)
|
||||||
logger (1.7.0)
|
logger (1.7.0)
|
||||||
loofah (2.24.1)
|
loofah (2.25.2)
|
||||||
crass (~> 1.0.2)
|
crass (~> 1.0.2)
|
||||||
nokogiri (>= 1.12.0)
|
nokogiri (>= 1.12.0)
|
||||||
mail (2.9.0)
|
mail (2.9.0)
|
||||||
@@ -224,7 +224,7 @@ GEM
|
|||||||
ruby2_keywords (~> 0.0.1)
|
ruby2_keywords (~> 0.0.1)
|
||||||
net-http-persistent (4.0.6)
|
net-http-persistent (4.0.6)
|
||||||
connection_pool (~> 2.2, >= 2.2.4)
|
connection_pool (~> 2.2, >= 2.2.4)
|
||||||
net-imap (0.6.4)
|
net-imap (0.6.4.1)
|
||||||
date
|
date
|
||||||
net-protocol
|
net-protocol
|
||||||
net-pop (0.1.2)
|
net-pop (0.1.2)
|
||||||
@@ -234,13 +234,13 @@ GEM
|
|||||||
net-smtp (0.5.1)
|
net-smtp (0.5.1)
|
||||||
net-protocol
|
net-protocol
|
||||||
nio4r (2.7.5)
|
nio4r (2.7.5)
|
||||||
nokogiri (1.19.3-aarch64-linux-gnu)
|
nokogiri (1.19.4-aarch64-linux-gnu)
|
||||||
racc (~> 1.4)
|
racc (~> 1.4)
|
||||||
nokogiri (1.19.3-arm64-darwin)
|
nokogiri (1.19.4-arm64-darwin)
|
||||||
racc (~> 1.4)
|
racc (~> 1.4)
|
||||||
nokogiri (1.19.3-x86_64-darwin)
|
nokogiri (1.19.4-x86_64-darwin)
|
||||||
racc (~> 1.4)
|
racc (~> 1.4)
|
||||||
nokogiri (1.19.3-x86_64-linux-gnu)
|
nokogiri (1.19.4-x86_64-linux-gnu)
|
||||||
racc (~> 1.4)
|
racc (~> 1.4)
|
||||||
openssl (3.3.0)
|
openssl (3.3.0)
|
||||||
ostruct (0.6.3)
|
ostruct (0.6.3)
|
||||||
@@ -278,8 +278,8 @@ GEM
|
|||||||
activesupport (>= 5.0.0)
|
activesupport (>= 5.0.0)
|
||||||
minitest
|
minitest
|
||||||
nokogiri (>= 1.6)
|
nokogiri (>= 1.6)
|
||||||
rails-html-sanitizer (1.6.2)
|
rails-html-sanitizer (1.7.1)
|
||||||
loofah (~> 2.21)
|
loofah (~> 2.25, >= 2.25.2)
|
||||||
nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
|
nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
|
||||||
rails_autolink (1.1.8)
|
rails_autolink (1.1.8)
|
||||||
actionview (> 3.1)
|
actionview (> 3.1)
|
||||||
@@ -367,20 +367,20 @@ GEM
|
|||||||
rack-protection (= 4.2.1)
|
rack-protection (= 4.2.1)
|
||||||
rack-session (>= 2.0.0, < 3)
|
rack-session (>= 2.0.0, < 3)
|
||||||
tilt (~> 2.0)
|
tilt (~> 2.0)
|
||||||
sqlite3 (2.7.3-aarch64-linux-gnu)
|
sqlite3 (2.9.5-aarch64-linux-gnu)
|
||||||
sqlite3 (2.7.3-arm64-darwin)
|
sqlite3 (2.9.5-arm64-darwin)
|
||||||
sqlite3 (2.7.3-x86_64-darwin)
|
sqlite3 (2.9.5-x86_64-darwin)
|
||||||
sqlite3 (2.7.3-x86_64-linux-gnu)
|
sqlite3 (2.9.5-x86_64-linux-gnu)
|
||||||
stimulus-rails (1.3.4)
|
stimulus-rails (1.3.4)
|
||||||
railties (>= 6.0.0)
|
railties (>= 6.0.0)
|
||||||
stringio (3.1.8)
|
stringio (3.1.8)
|
||||||
thor (1.4.0)
|
thor (1.4.0)
|
||||||
thruster (0.1.15-aarch64-linux)
|
thruster (0.1.23-aarch64-linux)
|
||||||
thruster (0.1.15-arm64-darwin)
|
thruster (0.1.23-arm64-darwin)
|
||||||
thruster (0.1.15-x86_64-darwin)
|
thruster (0.1.23-x86_64-darwin)
|
||||||
thruster (0.1.15-x86_64-linux)
|
thruster (0.1.23-x86_64-linux)
|
||||||
tilt (2.6.1)
|
tilt (2.6.1)
|
||||||
timeout (0.4.4)
|
timeout (0.6.1)
|
||||||
tsort (0.2.0)
|
tsort (0.2.0)
|
||||||
tzinfo (2.0.6)
|
tzinfo (2.0.6)
|
||||||
concurrent-ruby (~> 1.0)
|
concurrent-ruby (~> 1.0)
|
||||||
@@ -397,7 +397,7 @@ GEM
|
|||||||
crack (>= 0.3.2)
|
crack (>= 0.3.2)
|
||||||
hashdiff (>= 0.4.0, < 2.0.0)
|
hashdiff (>= 0.4.0, < 2.0.0)
|
||||||
websocket (1.2.11)
|
websocket (1.2.11)
|
||||||
websocket-driver (0.8.0)
|
websocket-driver (0.8.2)
|
||||||
base64
|
base64
|
||||||
websocket-extensions (>= 0.1.0)
|
websocket-extensions (>= 0.1.0)
|
||||||
websocket-extensions (0.1.5)
|
websocket-extensions (0.1.5)
|
||||||
|
|||||||
@@ -11,51 +11,49 @@ expect, including:
|
|||||||
- @mentions
|
- @mentions
|
||||||
- API, with support for bot integrations
|
- API, with support for bot integrations
|
||||||
|
|
||||||
## Deploying with Docker
|
## Running your own Campfire instance
|
||||||
|
|
||||||
Campfire's Docker image contains everything needed for a fully-functional,
|
Campfire's Docker image contains everything needed for a fully-functional,
|
||||||
single-machine deployment. This includes the web app, background jobs, caching,
|
single-machine deployment. This includes the web app, background jobs, caching,
|
||||||
file serving, and SSL.
|
file serving, and SSL. You can use our pre-built image at
|
||||||
|
`ghcr.io/basecamp/once-campfire:latest`, or build your own from this repo.
|
||||||
|
|
||||||
To persist storage of the database and file attachments, map a volume to `/rails/storage`.
|
### Deploying with ONCE
|
||||||
|
|
||||||
To configure additional features, you can set the following environment variables:
|
The easiest way to self-host Campfire is with [ONCE](https://github.com/basecamp/once).
|
||||||
|
It will guide you through the initial set up and then keep your instance up to date automatically.
|
||||||
|
|
||||||
- `SSL_DOMAIN` - enable automatic SSL via Let's Encrypt for the given domain name
|
If you don't already have `once` installed, run this on the machine you want to run Campfire on:
|
||||||
- `DISABLE_SSL` - alternatively, set `DISABLE_SSL` to serve over plain HTTP
|
|
||||||
- `VAPID_PUBLIC_KEY`/`VAPID_PRIVATE_KEY` - set these to a valid keypair to
|
|
||||||
allow sending Web Push notifications. You can generate a new keypair by running
|
|
||||||
`/script/admin/create-vapid-key`
|
|
||||||
- `SENTRY_DSN` - to enable error reporting to sentry in production, supply your
|
|
||||||
DSN here
|
|
||||||
|
|
||||||
For example:
|
```sh
|
||||||
|
curl https://get.once.com | sh
|
||||||
|
```
|
||||||
|
|
||||||
docker build -t campfire .
|
`once` will launch as soon as the install is finished.
|
||||||
|
|
||||||
docker run \
|
Choose Campfire from the list of applications, follow the instructions, and ONCE will take care of the rest.
|
||||||
--publish 80:80 --publish 443:443 \
|
|
||||||
--restart unless-stopped \
|
|
||||||
--volume campfire:/rails/storage \
|
|
||||||
--env SECRET_KEY_BASE=$YOUR_SECRET_KEY_BASE \
|
|
||||||
--env VAPID_PUBLIC_KEY=$YOUR_PUBLIC_KEY \
|
|
||||||
--env VAPID_PRIVATE_KEY=$YOUR_PRIVATE_KEY \
|
|
||||||
--env TLS_DOMAIN=chat.example.com \
|
|
||||||
campfire
|
|
||||||
|
|
||||||
## Running in development
|
If you prefer the command line to the dashboard, you can deploy directly:
|
||||||
|
|
||||||
bin/setup
|
```sh
|
||||||
bin/rails server
|
once deploy ghcr.io/basecamp/once-campfire --host chat.example.com
|
||||||
|
```
|
||||||
|
|
||||||
## Worth Noting
|
### Deploying with Docker
|
||||||
|
|
||||||
When you start Campfire for the first time, you’ll be guided through
|
If you'd rather run the Docker image yourself, you can read more about that in the [self-hosting guide](docs/self-hosting.md).
|
||||||
creating an admin account.
|
|
||||||
The email address of this admin account will be shown on the login page
|
|
||||||
so that people who forget their password know who to contact for help.
|
|
||||||
(You can change this email later in the settings)
|
|
||||||
|
|
||||||
Campfire is single-tenant: any rooms designated "public" will be accessible by
|
> [!TIP]
|
||||||
all users in the system. To support entirely distinct groups of customers, you
|
> When you start Campfire for the first time, you'll be guided through a wizard to create an admin account.
|
||||||
would deploy multiple instances of the application.
|
> The email address that you enter for the admin account will be visible on the sign-in page, it's there so
|
||||||
|
> that people have someone to contact if they need help with their account. If that bothers you, put in any
|
||||||
|
> email address you want and create yourself a new admin account.
|
||||||
|
|
||||||
|
## Development
|
||||||
|
|
||||||
|
You are welcome - and encouraged - to modify Campfire to your liking.
|
||||||
|
Please see our [development guide](docs/development.md) for how to get Campfire set up for local development.
|
||||||
|
|
||||||
|
## Security
|
||||||
|
|
||||||
|
See [SECURITY.md](SECURITY.md) for how to report a vulnerability and a description of our trust model.
|
||||||
+22
@@ -0,0 +1,22 @@
|
|||||||
|
# Security
|
||||||
|
|
||||||
|
Report vulnerabilities through our [HackerOne program](https://hackerone.com/basecamp) or at
|
||||||
|
https://github.com/basecamp/once-campfire/security. Note that Campfire is in scope for our security
|
||||||
|
program, but is not bounty eligible.
|
||||||
|
|
||||||
|
## Trust model
|
||||||
|
|
||||||
|
Campfire is self-hosted and single-tenant, so the administrator is the server operator,
|
||||||
|
with shell, network, and database access already. Anything requiring the administrator
|
||||||
|
role grants nothing they do not already have, and is not a vulnerability.
|
||||||
|
|
||||||
|
We do want reports of anything a **non-administrator** can reach, and of any credential or
|
||||||
|
network path held by the Campfire process but not by the operator's own shell.
|
||||||
|
|
||||||
|
## Intentional behavior
|
||||||
|
|
||||||
|
Bot webhook URLs are unrestricted: an administrator can point one at any address,
|
||||||
|
including internal ones, because operators legitimately wire bots to their own services.
|
||||||
|
Link unfurling is different because any member can trigger it by pasting a URL, so it
|
||||||
|
validates destinations through `RestrictedHTTP::PrivateNetworkGuard`. The difference is who
|
||||||
|
picks the destination.
|
||||||
@@ -0,0 +1,13 @@
|
|||||||
|
# Prepended onto Turbo::StreamsChannel. The subscriber names the channel it wants, so
|
||||||
|
# authorizing room messages only in RoomMessagesChannel would leave the stock channel as
|
||||||
|
# a way around it: same signed stream name, no membership check. Turn those names away
|
||||||
|
# here and RoomMessagesChannel becomes the only door.
|
||||||
|
module RoomStreamsAreAuthorized
|
||||||
|
def subscribed
|
||||||
|
if RoomMessagesChannel.guarded_stream?(verified_stream_name_from_params)
|
||||||
|
reject
|
||||||
|
else
|
||||||
|
super
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -0,0 +1,55 @@
|
|||||||
|
# Authorizes the room message stream when the subscription is made, so that revoking a
|
||||||
|
# membership actually stops delivery.
|
||||||
|
#
|
||||||
|
# Turbo's stock channel verifies only the signature on the stream name. That name carries
|
||||||
|
# no expiry and no binding to a user, so one harvested while a member keeps working after
|
||||||
|
# the membership is gone. Reconnecting makes it worse rather than better: revoking a
|
||||||
|
# membership disconnects the user with reconnect: true, and the client then replays its
|
||||||
|
# subscriptions on the fresh socket.
|
||||||
|
#
|
||||||
|
# The room is derived from the verified stream name rather than taken as a parameter, so
|
||||||
|
# there's nothing for a subscriber to point somewhere else. The subscriber also doesn't
|
||||||
|
# get to choose the channel: Turbo::StreamsChannel turns these stream names away, so this
|
||||||
|
# is the only way onto them. See config/initializers/turbo_streams_authorization.rb.
|
||||||
|
class RoomMessagesChannel < ApplicationCable::Channel
|
||||||
|
extend Turbo::Streams::StreamName
|
||||||
|
include Turbo::Streams::StreamName::ClassMethods
|
||||||
|
|
||||||
|
STREAM_SUFFIX = "messages"
|
||||||
|
|
||||||
|
class << self
|
||||||
|
# True for the stream names this channel exists to guard, whoever is asking.
|
||||||
|
def guarded_stream?(stream_name)
|
||||||
|
stream_name.to_s.split(":", 2).second == STREAM_SUFFIX
|
||||||
|
end
|
||||||
|
|
||||||
|
def subscribable_room(user, stream_name)
|
||||||
|
gid_param, suffix = stream_name.to_s.split(":", 2)
|
||||||
|
|
||||||
|
if suffix == STREAM_SUFFIX && room = room_from(gid_param)
|
||||||
|
user.rooms.find_by(id: room.id)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
def room_from(gid_param)
|
||||||
|
GlobalID::Locator.locate gid_param, only: Room
|
||||||
|
rescue ActiveRecord::RecordNotFound
|
||||||
|
nil
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
def subscribed
|
||||||
|
if stream_name = authorized_stream_name
|
||||||
|
stream_from stream_name
|
||||||
|
else
|
||||||
|
reject
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
def authorized_stream_name
|
||||||
|
stream_name = verified_stream_name_from_params
|
||||||
|
stream_name if stream_name.present? && self.class.subscribable_room(current_user, stream_name)
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -1,5 +1,12 @@
|
|||||||
class UnreadRoomsChannel < ApplicationCable::Channel
|
class UnreadRoomsChannel < ApplicationCable::Channel
|
||||||
|
# Scoped per user, like ReadRoomsChannel. A single global stream would tell every
|
||||||
|
# authenticated connection when any room on the account is active, including closed
|
||||||
|
# rooms and direct conversations they're not part of.
|
||||||
|
def self.stream_name_for(user_id)
|
||||||
|
"user_#{user_id}_unreads"
|
||||||
|
end
|
||||||
|
|
||||||
def subscribed
|
def subscribed
|
||||||
stream_from "unread_rooms"
|
stream_from self.class.stream_name_for(current_user.id)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
@@ -8,9 +8,8 @@ class Accounts::LogosController < ApplicationController
|
|||||||
if stale?(etag: Current.account)
|
if stale?(etag: Current.account)
|
||||||
expires_in 5.minutes, public: true, stale_while_revalidate: 1.week
|
expires_in 5.minutes, public: true, stale_while_revalidate: 1.week
|
||||||
|
|
||||||
if Current.account&.logo&.attached?
|
if (logo_variant = Current.account&.logo_variant(logo_size))
|
||||||
logo = Current.account.logo.variant(logo_variant).processed
|
send_png_file ActiveStorage::Blob.service.path_for(logo_variant.key)
|
||||||
send_png_file ActiveStorage::Blob.service.path_for(logo.key)
|
|
||||||
else
|
else
|
||||||
send_stock_icon
|
send_stock_icon
|
||||||
end
|
end
|
||||||
@@ -23,9 +22,6 @@ class Accounts::LogosController < ApplicationController
|
|||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
LARGE_SQUARE_PNG_VARIANT = { resize_to_limit: [ 512, 512 ], format: :png }
|
|
||||||
SMALL_SQUARE_PNG_VARIANT = { resize_to_limit: [ 192, 192 ], format: :png }
|
|
||||||
|
|
||||||
def send_png_file(path)
|
def send_png_file(path)
|
||||||
send_file path, content_type: "image/png", disposition: :inline
|
send_file path, content_type: "image/png", disposition: :inline
|
||||||
end
|
end
|
||||||
@@ -38,8 +34,8 @@ class Accounts::LogosController < ApplicationController
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def logo_variant
|
def logo_size
|
||||||
small_logo? ? SMALL_SQUARE_PNG_VARIANT : LARGE_SQUARE_PNG_VARIANT
|
small_logo? ? :small : :large
|
||||||
end
|
end
|
||||||
|
|
||||||
def small_logo?
|
def small_logo?
|
||||||
|
|||||||
@@ -42,6 +42,12 @@ class Rooms::ClosedsController < RoomsController
|
|||||||
@room = @room.becomes!(Rooms::Closed)
|
@room = @room.becomes!(Rooms::Closed)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
# Open and closed rooms convert into each other, so both are in reach here. Direct
|
||||||
|
# rooms never are: converting one would let its creator revise who's in it.
|
||||||
|
def room_scope
|
||||||
|
Current.user.rooms.without_directs
|
||||||
|
end
|
||||||
|
|
||||||
def grantees
|
def grantees
|
||||||
User.where(id: grantee_ids)
|
User.where(id: grantee_ids)
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -29,8 +29,13 @@ class Rooms::DirectsController < RoomsController
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
# All users in a direct room can administer it
|
# All users in a direct room can administer it. Only direct rooms, though: this
|
||||||
|
# relaxation is why room_scope below has to keep every other type out of reach.
|
||||||
def ensure_can_administer
|
def ensure_can_administer
|
||||||
true
|
true
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def room_scope
|
||||||
|
Current.user.rooms.directs
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -40,6 +40,12 @@ class Rooms::OpensController < RoomsController
|
|||||||
@room = @room.becomes!(Rooms::Open)
|
@room = @room.becomes!(Rooms::Open)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
# Open and closed rooms convert into each other, so both are in reach here. Direct
|
||||||
|
# rooms never are: promoting one would republish its history to the whole account.
|
||||||
|
def room_scope
|
||||||
|
Current.user.rooms.without_directs
|
||||||
|
end
|
||||||
|
|
||||||
def broadcast_create_room(room)
|
def broadcast_create_room(room)
|
||||||
broadcast_prepend_to :rooms, target: :shared_rooms, partial: "users/sidebars/rooms/shared", locals: { room: room }
|
broadcast_prepend_to :rooms, target: :shared_rooms, partial: "users/sidebars/rooms/shared", locals: { room: room }
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -20,13 +20,19 @@ class RoomsController < ApplicationController
|
|||||||
|
|
||||||
private
|
private
|
||||||
def set_room
|
def set_room
|
||||||
if room = Current.user.rooms.find_by(id: params[:room_id] || params[:id])
|
if room = room_scope.find_by(id: params[:room_id] || params[:id])
|
||||||
@room = room
|
@room = room
|
||||||
else
|
else
|
||||||
redirect_to root_url, alert: "Room not found or inaccessible"
|
redirect_to root_url, alert: "Room not found or inaccessible"
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
# Subclasses narrow this to the room types they're allowed to act on, so that one
|
||||||
|
# room namespace can't be used to reach another's rooms.
|
||||||
|
def room_scope
|
||||||
|
Current.user.rooms
|
||||||
|
end
|
||||||
|
|
||||||
def ensure_can_administer
|
def ensure_can_administer
|
||||||
head :forbidden unless Current.user.can_administer?(@room)
|
head :forbidden unless Current.user.can_administer?(@room)
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -9,8 +9,7 @@ class Users::AvatarsController < ApplicationController
|
|||||||
if stale?(etag: @user)
|
if stale?(etag: @user)
|
||||||
expires_in 30.minutes, public: true, stale_while_revalidate: 1.week
|
expires_in 30.minutes, public: true, stale_while_revalidate: 1.week
|
||||||
|
|
||||||
if @user.avatar.attached?
|
if (avatar_variant = @user.avatar_variant)
|
||||||
avatar_variant = @user.avatar.variant(SQUARE_WEBP_VARIANT).processed
|
|
||||||
send_webp_blob_file avatar_variant.key
|
send_webp_blob_file avatar_variant.key
|
||||||
elsif @user.bot?
|
elsif @user.bot?
|
||||||
render_default_bot
|
render_default_bot
|
||||||
@@ -26,8 +25,6 @@ class Users::AvatarsController < ApplicationController
|
|||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
SQUARE_WEBP_VARIANT = { resize_to_limit: [ 512, 512 ], format: :webp }
|
|
||||||
|
|
||||||
def send_webp_blob_file(key)
|
def send_webp_blob_file(key)
|
||||||
send_file ActiveStorage::Blob.service.path_for(key), content_type: "image/webp", disposition: :inline
|
send_file ActiveStorage::Blob.service.path_for(key), content_type: "image/webp", disposition: :inline
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -1,3 +1,3 @@
|
|||||||
module ContentFilters
|
module ContentFilters
|
||||||
TextMessagePresentationFilters = ActionText::Content::Filters.new(RemoveSoloUnfurledLinkText, StyleUnfurledTwitterAvatars, SanitizeTags)
|
TextMessagePresentationFilters = ActionText::Content::Filters.new(RemoveSoloUnfurledLinkText, StyleUnfurledTwitterAvatars, SanitizeTags, SanitizeAttributes)
|
||||||
end
|
end
|
||||||
@@ -0,0 +1,47 @@
|
|||||||
|
class ContentFilters::SanitizeAttributes < ActionText::Content::Filter
|
||||||
|
def applicable?
|
||||||
|
true
|
||||||
|
end
|
||||||
|
|
||||||
|
# Scrub attributes on the tags that SanitizeTags allows, using Rails' safe-list
|
||||||
|
# sanitizer so unsafe URI schemes and event-handler attributes are stripped.
|
||||||
|
# Runs after SanitizeTags, so passing the same allowed tags makes the tag pass
|
||||||
|
# a no-op and only attributes are scrubbed.
|
||||||
|
def apply
|
||||||
|
sanitizer.sanitize fragment.to_html, tags: allowed_tags, attributes: allowed_attributes
|
||||||
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
# Presentation styling relies on class attributes (e.g. unfurled link embeds),
|
||||||
|
# which the standard ActionText set doesn't include.
|
||||||
|
EXTRA_ALLOWED_ATTRIBUTES = %w[ class ]
|
||||||
|
|
||||||
|
# ActionText::ContentHelper.sanitizer is a single process-wide instance, and
|
||||||
|
# rails-html-sanitizer reuses one mutable permit scrubber that it reconfigures
|
||||||
|
# from the tags/attributes on every #sanitize call. Sharing it here would race
|
||||||
|
# our stricter tag set against ActionText's default rendering on concurrent
|
||||||
|
# requests, so use a dedicated instance of the same sanitizer class to keep the
|
||||||
|
# scrubber isolated.
|
||||||
|
def sanitizer
|
||||||
|
sanitizer_class.new
|
||||||
|
end
|
||||||
|
|
||||||
|
def sanitizer_class
|
||||||
|
ActionText::ContentHelper.sanitizer.class
|
||||||
|
end
|
||||||
|
|
||||||
|
def allowed_tags
|
||||||
|
ContentFilters::SanitizeTags::ALLOWED_TAGS
|
||||||
|
end
|
||||||
|
|
||||||
|
def allowed_attributes
|
||||||
|
standard_allowed_attributes + EXTRA_ALLOWED_ATTRIBUTES
|
||||||
|
end
|
||||||
|
|
||||||
|
# Mirrors ActionText::ContentHelper#sanitizer_allowed_attributes, which isn't
|
||||||
|
# exposed at the module level.
|
||||||
|
def standard_allowed_attributes
|
||||||
|
ActionText::ContentHelper.allowed_attributes ||
|
||||||
|
(sanitizer_class.allowed_attributes + ActionText::Attachment::ATTRIBUTES).to_a
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -1,6 +1,14 @@
|
|||||||
class Account < ApplicationRecord
|
class Account < ApplicationRecord
|
||||||
include Joinable
|
include Joinable
|
||||||
|
|
||||||
has_one_attached :logo
|
has_one_attached :logo do |attachable|
|
||||||
|
attachable.variant :large, resize_to_limit: [ 512, 512 ], format: :png
|
||||||
|
attachable.variant :small, resize_to_limit: [ 192, 192 ], format: :png
|
||||||
|
end
|
||||||
|
|
||||||
has_json :settings, restrict_room_creation_to_administrators: false
|
has_json :settings, restrict_room_creation_to_administrators: false
|
||||||
|
|
||||||
|
def logo_variant(size)
|
||||||
|
logo.variant(size).processed if logo.variable?
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -1,10 +1,19 @@
|
|||||||
module Message::Broadcasts
|
module Message::Broadcasts
|
||||||
def broadcast_create
|
def broadcast_create
|
||||||
broadcast_append_to room, :messages, target: [ room, :messages ]
|
broadcast_append_to room, :messages, target: [ room, :messages ]
|
||||||
ActionCable.server.broadcast("unread_rooms", { roomId: room.id })
|
broadcast_unread_room
|
||||||
end
|
end
|
||||||
|
|
||||||
def broadcast_remove
|
def broadcast_remove
|
||||||
broadcast_remove_to room, :messages
|
broadcast_remove_to room, :messages
|
||||||
end
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
# Fanned out to the room's members rather than published on one global stream, so
|
||||||
|
# that the timing of activity in a room only reaches people who are in it.
|
||||||
|
def broadcast_unread_room
|
||||||
|
room.memberships.pluck(:user_id).each do |user_id|
|
||||||
|
ActionCable.server.broadcast UnreadRoomsChannel.stream_name_for(user_id), { roomId: room.id }
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -22,6 +22,8 @@ class Room < ApplicationRecord
|
|||||||
|
|
||||||
belongs_to :creator, class_name: "User", default: -> { Current.user }
|
belongs_to :creator, class_name: "User", default: -> { Current.user }
|
||||||
|
|
||||||
|
validate :direct_rooms_keep_their_type, on: :update
|
||||||
|
|
||||||
scope :opens, -> { where(type: "Rooms::Open") }
|
scope :opens, -> { where(type: "Rooms::Open") }
|
||||||
scope :closeds, -> { where(type: "Rooms::Closed") }
|
scope :closeds, -> { where(type: "Rooms::Closed") }
|
||||||
scope :directs, -> { where(type: "Rooms::Direct") }
|
scope :directs, -> { where(type: "Rooms::Direct") }
|
||||||
@@ -65,6 +67,15 @@ class Room < ApplicationRecord
|
|||||||
end
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
# Open and closed rooms convert into each other freely. A direct room can't become
|
||||||
|
# either: its participants agreed to a private conversation, not to one whose
|
||||||
|
# audience someone else gets to widen afterwards.
|
||||||
|
def direct_rooms_keep_their_type
|
||||||
|
if type_changed? && type_was == "Rooms::Direct"
|
||||||
|
errors.add :type, "can't be changed for a direct room"
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
def unread_memberships(message)
|
def unread_memberships(message)
|
||||||
memberships.visible.disconnected.where.not(user: message.creator).update_all(unread_at: message.created_at, updated_at: Time.current)
|
memberships.visible.disconnected.where.not(user: message.creator).update_all(unread_at: message.created_at, updated_at: Time.current)
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -2,7 +2,9 @@ module User::Avatar
|
|||||||
extend ActiveSupport::Concern
|
extend ActiveSupport::Concern
|
||||||
|
|
||||||
included do
|
included do
|
||||||
has_one_attached :avatar
|
has_one_attached :avatar do |attachable|
|
||||||
|
attachable.variant :square, resize_to_limit: [ 512, 512 ], format: :webp
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
class_methods do
|
class_methods do
|
||||||
@@ -14,4 +16,8 @@ module User::Avatar
|
|||||||
def avatar_token
|
def avatar_token
|
||||||
signed_id(purpose: :avatar)
|
signed_id(purpose: :avatar)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def avatar_variant
|
||||||
|
avatar.variant(:square).processed if avatar.variable?
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -24,6 +24,8 @@ class Webhook < ApplicationRecord
|
|||||||
Net::HTTP::Post.new(uri, "Content-Type" => "application/json").tap { |request| request.body = payload }
|
Net::HTTP::Post.new(uri, "Content-Type" => "application/json").tap { |request| request.body = payload }
|
||||||
end
|
end
|
||||||
|
|
||||||
|
# No PrivateNetworkGuard, unlike Opengraph::Fetch: only an administrator sets this URL,
|
||||||
|
# and operators legitimately point bots at their own internal services.
|
||||||
def http
|
def http
|
||||||
Net::HTTP.new(uri.host, uri.port).tap do |http|
|
Net::HTTP.new(uri.host, uri.port).tap do |http|
|
||||||
http.use_ssl = (uri.scheme == "https")
|
http.use_ssl = (uri.scheme == "https")
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
<%# Be sure to check/update messages/_template.html.erb when changing this file %>
|
<%# Be sure to check/update messages/_template.html.erb when changing this file %>
|
||||||
|
|
||||||
<% cache message do %>
|
<%# Bump this version when the message presentation filters change what they emit. Editing this line changes the template digest, which busts BOTH this fragment cache and the collection cache that keys on this partial's digest (helper Ruby changes alone don't). %>
|
||||||
|
<% cache [ message, "presentation-v2" ] do %>
|
||||||
<%= message_tag message do %>
|
<%= message_tag message do %>
|
||||||
<h2 class="message__day-separator"><%= local_datetime_tag message.created_at, style: :date %></h2>
|
<h2 class="message__day-separator"><%= local_datetime_tag message.created_at, style: :date %></h2>
|
||||||
|
|
||||||
|
|||||||
@@ -17,7 +17,7 @@
|
|||||||
<%= render partial: "messages/message", collection: @messages, cached: true %>
|
<%= render partial: "messages/message", collection: @messages, cached: true %>
|
||||||
<% end %>
|
<% end %>
|
||||||
|
|
||||||
<%= turbo_stream_from @room, :messages %>
|
<%= turbo_stream_from @room, :messages, channel: "RoomMessagesChannel" %>
|
||||||
<%= button_to_jump_to_newest_message %>
|
<%= button_to_jump_to_newest_message %>
|
||||||
<% end %>
|
<% end %>
|
||||||
|
|
||||||
|
|||||||
+17
-10
@@ -15,6 +15,7 @@ include SSHKit::DSL
|
|||||||
ARCH = "linux/amd64,linux/arm64"
|
ARCH = "linux/amd64,linux/arm64"
|
||||||
BUILDER_NAME = "campfire-builder"
|
BUILDER_NAME = "campfire-builder"
|
||||||
GIT_SHA = `git rev-parse HEAD`.strip
|
GIT_SHA = `git rev-parse HEAD`.strip
|
||||||
|
MANUAL_NOTES = ARGV.delete("--notes")
|
||||||
VERSION = ARGV[0]
|
VERSION = ARGV[0]
|
||||||
|
|
||||||
DOCKER_IMAGE_NAME = "registry.once.com/campfire"
|
DOCKER_IMAGE_NAME = "registry.once.com/campfire"
|
||||||
@@ -28,7 +29,7 @@ EXPORT_REMOTE_USER = "app"
|
|||||||
EXPORT_DEPLOY_HOSTS = %w[ once-store-app-101 once-store-app-102 ]
|
EXPORT_DEPLOY_HOSTS = %w[ once-store-app-101 once-store-app-102 ]
|
||||||
EXPORT_DEPLOY_LOCATION = "/local/app/product_releases/"
|
EXPORT_DEPLOY_LOCATION = "/local/app/product_releases/"
|
||||||
|
|
||||||
abort "You must specify a version, e.g. `bin/release 1.0.0`" unless VERSION
|
abort "You must specify a version, e.g. `bin/release 1.0.0` (pass --notes to write release notes manually)" unless VERSION
|
||||||
|
|
||||||
current_branch = `git rev-parse --abbrev-ref HEAD`.strip
|
current_branch = `git rev-parse --abbrev-ref HEAD`.strip
|
||||||
if current_branch != "main"
|
if current_branch != "main"
|
||||||
@@ -57,19 +58,25 @@ on(:local) do
|
|||||||
end
|
end
|
||||||
|
|
||||||
announcing "Creating GitHub release v#{VERSION}..." do
|
announcing "Creating GitHub release v#{VERSION}..." do
|
||||||
notes_file = "tmp/release_notes.md"
|
|
||||||
|
|
||||||
on(:local) do
|
on(:local) do
|
||||||
execute :mkdir, "-p", "tmp"
|
if MANUAL_NOTES
|
||||||
|
notes_file = "tmp/release_notes.md"
|
||||||
|
|
||||||
File.write(notes_file, "# What's Changed\n\n- \n")
|
execute :mkdir, "-p", "tmp"
|
||||||
system ENV["EDITOR"] || "vim", notes_file
|
|
||||||
|
|
||||||
unless system "gh", "release", "create", "v#{VERSION}", "--title", "v#{VERSION}", "--notes-file", notes_file
|
File.write(notes_file, "# What's Changed\n\n- \n")
|
||||||
abort "Failed to create release; check that the version doesn't already exist"
|
system ENV["EDITOR"] || "vim", notes_file
|
||||||
|
|
||||||
|
unless system "gh", "release", "create", "v#{VERSION}", "--title", "v#{VERSION}", "--notes-file", notes_file
|
||||||
|
abort "Failed to create release; check that the version doesn't already exist"
|
||||||
|
end
|
||||||
|
|
||||||
|
execute :rm, notes_file
|
||||||
|
else
|
||||||
|
unless system "gh", "release", "create", "v#{VERSION}", "--title", "v#{VERSION}", "--generate-notes"
|
||||||
|
abort "Failed to create release; check that the version doesn't already exist"
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
execute :rm, notes_file
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -5,7 +5,7 @@ pin "@hotwired/stimulus-loading", to: "stimulus-loading.js"
|
|||||||
pin "@hotwired/turbo-rails", to: "turbo.js"
|
pin "@hotwired/turbo-rails", to: "turbo.js"
|
||||||
pin "@rails/actioncable", to: "actioncable.esm.js"
|
pin "@rails/actioncable", to: "actioncable.esm.js"
|
||||||
pin "@rails/request.js", to: "@rails--request.js" # @0.0.8
|
pin "@rails/request.js", to: "@rails--request.js" # @0.0.8
|
||||||
pin "trix", to: "trix.esm.min.js" # @2.1.19
|
pin "trix", to: "trix.js"
|
||||||
pin "@rails/actiontext", to: "actiontext.js"
|
pin "@rails/actiontext", to: "actiontext.js"
|
||||||
pin "highlight.js", to: "highlight.js/core.js"
|
pin "highlight.js", to: "highlight.js/core.js"
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,3 @@
|
|||||||
|
Rails.application.config.to_prepare do
|
||||||
|
Turbo::StreamsChannel.prepend RoomStreamsAreAuthorized
|
||||||
|
end
|
||||||
@@ -1,2 +1,2 @@
|
|||||||
Rails.application.config.app_version = ENV.fetch("APP_VERSION", "0")
|
Rails.application.config.app_version = ENV["APP_VERSION"].presence || ENV["GIT_REVISION"].presence || "0"
|
||||||
Rails.application.config.git_revision = ENV["GIT_REVISION"]
|
Rails.application.config.git_revision = ENV["GIT_REVISION"]
|
||||||
@@ -0,0 +1,9 @@
|
|||||||
|
# Disable unfuzzed libvips operations.
|
||||||
|
#
|
||||||
|
# To block loaders we need to call `Vips.block` after Rails and image_processing set their
|
||||||
|
# defaults. Force the order of operations by autoloading the file now.
|
||||||
|
ActiveStorage::Transformers::Vips
|
||||||
|
Vips.block_untrusted(true)
|
||||||
|
Vips.block("VipsForeignLoadOpenslide", true) # prevent sqlite segfault in forked parallel workers
|
||||||
|
Rails.application.config.active_storage.variable_content_types -=
|
||||||
|
%w[ image/bmp image/vnd.microsoft.icon image/vnd.adobe.photoshop ]
|
||||||
@@ -0,0 +1,69 @@
|
|||||||
|
## Development
|
||||||
|
|
||||||
|
### Setting up
|
||||||
|
|
||||||
|
First, get everything installed and configured with:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
bin/setup
|
||||||
|
```
|
||||||
|
|
||||||
|
This installs the system packages Campfire needs (SQLite, ffmpeg), the right Ruby version (via [mise](https://mise.jdx.dev)), and the app's gems; prepares the database; and starts Redis (in a Docker container called `campfire-redis`, if it isn't already running locally).
|
||||||
|
|
||||||
|
If you want to start over at any point, run:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
bin/setup --reset
|
||||||
|
```
|
||||||
|
|
||||||
|
### Running the server
|
||||||
|
|
||||||
|
Start the development server with:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
bin/dev
|
||||||
|
```
|
||||||
|
|
||||||
|
You'll be able to access the app at http://localhost:3000.
|
||||||
|
|
||||||
|
On first run you'll be guided through creating your admin account, and you can sign in with that account from then on.
|
||||||
|
|
||||||
|
Note that Campfire needs Redis (for Action Cable, caching, and background jobs), so if you've restarted your machine or stopped the container, `docker start campfire-redis` will bring it back.
|
||||||
|
|
||||||
|
### Web Push notifications
|
||||||
|
|
||||||
|
Campfire uses VAPID (Voluntary Application Server Identification) keys to send browser push notifications. For notifications to work in development you'll need to generate a key pair and set these environment variables:
|
||||||
|
|
||||||
|
- `VAPID_PRIVATE_KEY`
|
||||||
|
- `VAPID_PUBLIC_KEY`
|
||||||
|
|
||||||
|
You can generate a fresh pair (along with a secret key base, which you can ignore in development) by running:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
script/admin/generate-secrets
|
||||||
|
```
|
||||||
|
|
||||||
|
### Running tests
|
||||||
|
|
||||||
|
Run the unit tests with:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
bin/rails test
|
||||||
|
```
|
||||||
|
|
||||||
|
And the browser-based system tests with:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
bin/rails test:system
|
||||||
|
```
|
||||||
|
|
||||||
|
Before pushing your changes, you can run the full CI suite locally - style checks, security audits, and all the tests - with a single command:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
bin/ci
|
||||||
|
```
|
||||||
|
|
||||||
|
### Contributing
|
||||||
|
|
||||||
|
You are welcome - and encouraged - to modify Campfire to your liking.
|
||||||
|
If you'd like to contribute your changes back, please read our [contributing guide](../CONTRIBUTING.md) first.
|
||||||
@@ -0,0 +1,213 @@
|
|||||||
|
## Self-hosting Campfire
|
||||||
|
|
||||||
|
Campfire's Docker image contains everything needed for a fully-functional, single-machine deployment.
|
||||||
|
This includes the web app, background jobs, caching, file serving, and SSL.
|
||||||
|
|
||||||
|
> [!TIP]
|
||||||
|
> The easiest way to self-host Campfire is with [ONCE](https://github.com/basecamp/once), which handles installation, updates, and backups for you. See the [README](../README.md#deploying-with-once) for details. This guide covers running the Docker image by hand.
|
||||||
|
|
||||||
|
We recommend using `ghcr.io/basecamp/once-campfire:latest`, which always points to the most recent tagged release - the most stable and battle-tested version of Campfire.
|
||||||
|
|
||||||
|
We provide a tagged release for every major, minor and patch version of Campfire, so you can also pin your deployment to a specific version if you want to avoid unexpected changes. For example:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# exactly version 1.4.4
|
||||||
|
ghcr.io/basecamp/once-campfire:1.4.4
|
||||||
|
|
||||||
|
# any 1.4.x version
|
||||||
|
# e.g. 1.4.4 or 1.4.5
|
||||||
|
# the last number is usually changed for bug fixes
|
||||||
|
ghcr.io/basecamp/once-campfire:1.4
|
||||||
|
|
||||||
|
# any 1.x version
|
||||||
|
# e.g. 1.4.4 or 1.5.0
|
||||||
|
# the middle number is usually changed for changes to, or addition of, features
|
||||||
|
ghcr.io/basecamp/once-campfire:1
|
||||||
|
```
|
||||||
|
|
||||||
|
If you want to live on the bleeding edge, the `main` tag tracks the main release branch instead.
|
||||||
|
It changes with every merged pull request, so it's the newest - but least battle-tested - version of Campfire.
|
||||||
|
|
||||||
|
To run it you'll need three things:
|
||||||
|
1. a machine that runs Docker
|
||||||
|
2. a mounted volume (so that your database and file attachments are kept around between restarts)
|
||||||
|
3. some environment variables for configuration
|
||||||
|
|
||||||
|
If you'd rather build the image yourself from your own copy of the source, you can do that too:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker build -t campfire .
|
||||||
|
```
|
||||||
|
|
||||||
|
### Mounting a storage volume
|
||||||
|
|
||||||
|
Campfire keeps all of its storage - the database and uploaded file attachments - inside the path `/rails/storage`.
|
||||||
|
By default Docker containers don't persist storage between runs, so you'll want to mount a persistent volume into that location.
|
||||||
|
|
||||||
|
The simplest way to do this is with the `--volume` flag with `docker run`. For example:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run --volume campfire:/rails/storage ghcr.io/basecamp/once-campfire:latest
|
||||||
|
```
|
||||||
|
|
||||||
|
That will create a named volume (called `campfire`) and mount it into the correct path.
|
||||||
|
Docker will manage where that volume is actually stored on your server.
|
||||||
|
|
||||||
|
You can also specify the data location yourself, mount a network drive, and more.
|
||||||
|
Check the Docker documentation to find out more about what's available.
|
||||||
|
|
||||||
|
### Configuring with environment variables
|
||||||
|
|
||||||
|
To configure your Campfire installation, you can use environment variables.
|
||||||
|
At a minimum you'll want to configure your secret key and your SSL domain.
|
||||||
|
|
||||||
|
#### Secrets
|
||||||
|
|
||||||
|
Campfire needs a few secret values that are specific to your instance:
|
||||||
|
|
||||||
|
- `SECRET_KEY_BASE` - the basis for cryptographic features like signed cookies. This should be a long, unguessable random string.
|
||||||
|
- `VAPID_PRIVATE_KEY`/`VAPID_PUBLIC_KEY` - a key pair used for sending Web Push notifications.
|
||||||
|
|
||||||
|
You can generate them by running:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run --rm ghcr.io/basecamp/once-campfire:latest script/admin/generate-secrets
|
||||||
|
```
|
||||||
|
|
||||||
|
It prints a fresh set of values ready to set as environment variables:
|
||||||
|
|
||||||
|
```
|
||||||
|
SECRET_KEY_BASE=...
|
||||||
|
VAPID_PRIVATE_KEY=...
|
||||||
|
VAPID_PUBLIC_KEY=...
|
||||||
|
```
|
||||||
|
|
||||||
|
Keep them safe and reuse the same values across restarts and upgrades - changing them later will invalidate sessions and push notification subscriptions.
|
||||||
|
|
||||||
|
#### SSL
|
||||||
|
|
||||||
|
If you want the Campfire container to handle its own SSL (HTTPS) automatically (via Let's Encrypt), you just need to specify the domain name that you're running it on.
|
||||||
|
You can do that with the `TLS_DOMAIN` environment variable.
|
||||||
|
|
||||||
|
> [!NOTE]
|
||||||
|
> If you're using SSL, you'll want to allow traffic on ports 80 and 443.
|
||||||
|
|
||||||
|
So if you were running on `chat.example.com` you could enable SSL like this:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run --publish 80:80 --publish 443:443 --env TLS_DOMAIN=chat.example.com ...
|
||||||
|
```
|
||||||
|
|
||||||
|
If you are terminating SSL in some other proxy in front of Campfire, or aren't using SSL at all (for example, if you want to run it locally on your laptop), then you should set `DISABLE_SSL=true` instead and just publish port 80:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run --publish 80:80 --env DISABLE_SSL=true ...
|
||||||
|
```
|
||||||
|
|
||||||
|
#### Error reporting (optional)
|
||||||
|
|
||||||
|
To enable error reporting to Sentry in production, supply your DSN in the `SENTRY_DSN` environment variable.
|
||||||
|
To disable Sentry initialization entirely, set `SKIP_TELEMETRY=true`.
|
||||||
|
|
||||||
|
### Example
|
||||||
|
|
||||||
|
Putting it all together, here's a complete `docker run` invocation:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run \
|
||||||
|
--name campfire \
|
||||||
|
--publish 80:80 --publish 443:443 \
|
||||||
|
--restart unless-stopped \
|
||||||
|
--volume campfire:/rails/storage \
|
||||||
|
--env SECRET_KEY_BASE=$YOUR_SECRET_KEY_BASE \
|
||||||
|
--env VAPID_PUBLIC_KEY=$YOUR_PUBLIC_KEY \
|
||||||
|
--env VAPID_PRIVATE_KEY=$YOUR_PRIVATE_KEY \
|
||||||
|
--env TLS_DOMAIN=chat.example.com \
|
||||||
|
ghcr.io/basecamp/once-campfire:latest
|
||||||
|
```
|
||||||
|
|
||||||
|
And here's an equivalent `docker-compose.yml` that you could use to run Campfire via `docker compose up`:
|
||||||
|
|
||||||
|
```yaml
|
||||||
|
services:
|
||||||
|
web:
|
||||||
|
image: ghcr.io/basecamp/once-campfire:latest
|
||||||
|
restart: unless-stopped
|
||||||
|
ports:
|
||||||
|
- "80:80"
|
||||||
|
- "443:443"
|
||||||
|
environment:
|
||||||
|
- SECRET_KEY_BASE=abcdefabcdef
|
||||||
|
- TLS_DOMAIN=chat.example.com
|
||||||
|
- VAPID_PRIVATE_KEY=myvapidprivatekey
|
||||||
|
- VAPID_PUBLIC_KEY=myvapidpublickey
|
||||||
|
volumes:
|
||||||
|
- campfire:/rails/storage
|
||||||
|
|
||||||
|
volumes:
|
||||||
|
campfire:
|
||||||
|
```
|
||||||
|
|
||||||
|
### First run
|
||||||
|
|
||||||
|
When you start Campfire for the first time, you'll be guided through creating an admin account.
|
||||||
|
|
||||||
|
> [!TIP]
|
||||||
|
> The email address of this admin account will be shown on the login page so that people who forget their password know who to contact for help.
|
||||||
|
> (You can change this email later in the settings.)
|
||||||
|
|
||||||
|
Campfire is single-tenant: any rooms designated "public" will be accessible by all users in the system.
|
||||||
|
To support entirely distinct groups of customers, you would deploy multiple instances of the application.
|
||||||
|
|
||||||
|
### Upgrading
|
||||||
|
|
||||||
|
All of Campfire's state lives in the mounted volume, so upgrading is a matter of pulling a newer image and recreating the container:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker pull ghcr.io/basecamp/once-campfire:latest
|
||||||
|
```
|
||||||
|
|
||||||
|
Any pending database migrations run automatically when the container boots.
|
||||||
|
|
||||||
|
### Backups
|
||||||
|
|
||||||
|
To back up your instance, back up the contents of the `/rails/storage` volume.
|
||||||
|
|
||||||
|
Because the SQLite database may be written to at any moment, you shouldn't copy its files directly while Campfire is running.
|
||||||
|
Instead, first run `script/admin/prepare-backup` inside the running container to produce a consistent snapshot of the database (it's written to `storage/backups/` inside the volume):
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker exec campfire script/admin/prepare-backup
|
||||||
|
```
|
||||||
|
|
||||||
|
(If you're using Docker Compose, replace `docker exec campfire` with `docker compose exec web`)
|
||||||
|
|
||||||
|
Then archive the whole storage volume to a file on the host:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run --rm \
|
||||||
|
--user root \
|
||||||
|
--volume campfire:/rails/storage \
|
||||||
|
--volume "$PWD":/backup \
|
||||||
|
ghcr.io/basecamp/once-campfire:latest \
|
||||||
|
tar czf "/backup/campfire-backup.tar.gz" -C /rails storage
|
||||||
|
```
|
||||||
|
|
||||||
|
This gives you a `campfire-backup.tar.gz` in your current directory containing the database snapshot and all uploaded files.
|
||||||
|
Copy it somewhere safe, ideally off the machine.
|
||||||
|
|
||||||
|
To restore, extract the archive back into a (stopped) instance's volume, and replace the live database with the snapshot:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
docker run --rm \
|
||||||
|
--user root \
|
||||||
|
--volume campfire:/rails/storage \
|
||||||
|
--volume "$PWD":/backup \
|
||||||
|
ghcr.io/basecamp/once-campfire:latest \
|
||||||
|
bash -c "tar xzf /backup/campfire-backup.tar.gz -C /rails &&
|
||||||
|
cp /rails/storage/backups/production.sqlite3 /rails/storage/db/production.sqlite3 &&
|
||||||
|
rm -f /rails/storage/db/production.sqlite3-wal /rails/storage/db/production.sqlite3-shm &&
|
||||||
|
chown -R rails:rails /rails/storage"
|
||||||
|
```
|
||||||
|
|
||||||
|
Then start Campfire again.
|
||||||
Executable
+12
@@ -0,0 +1,12 @@
|
|||||||
|
#!/bin/bash
|
||||||
|
set -euo pipefail
|
||||||
|
|
||||||
|
db_name="${RAILS_ENV:-production}.sqlite3"
|
||||||
|
snapshot="/rails/storage/backups/$db_name"
|
||||||
|
db="/rails/storage/db/$db_name"
|
||||||
|
|
||||||
|
if [ -f "$snapshot" ]; then
|
||||||
|
mkdir -p "$(dirname "$db")"
|
||||||
|
cp "$snapshot" "$db"
|
||||||
|
rm -f "$db-wal" "$db-shm"
|
||||||
|
fi
|
||||||
Executable
+2
@@ -0,0 +1,2 @@
|
|||||||
|
#!/bin/bash
|
||||||
|
exec /rails/script/admin/prepare-backup
|
||||||
@@ -1,3 +1,4 @@
|
|||||||
|
require "ipaddr"
|
||||||
require "resolv"
|
require "resolv"
|
||||||
|
|
||||||
module RestrictedHTTP
|
module RestrictedHTTP
|
||||||
@@ -6,7 +7,32 @@ module RestrictedHTTP
|
|||||||
module PrivateNetworkGuard
|
module PrivateNetworkGuard
|
||||||
extend self
|
extend self
|
||||||
|
|
||||||
LOCAL_IP = IPAddr.new("0.0.0.0/8") # "This" network
|
# IPv4 special-use ranges (RFC 5735/6890) not already covered by the
|
||||||
|
# private?/loopback?/link_local? predicates in #disallowed_ipv4?.
|
||||||
|
DISALLOWED_IPV4 = %w[
|
||||||
|
0.0.0.0/8 100.64.0.0/10 192.0.0.0/24 192.0.2.0/24 192.88.99.0/24
|
||||||
|
198.18.0.0/15 198.51.100.0/24 203.0.113.0/24 224.0.0.0/4 240.0.0.0/4
|
||||||
|
].map { |cidr| IPAddr.new(cidr) }.freeze
|
||||||
|
|
||||||
|
# IPv6 special-use ranges not caught by the predicates. 6to4 (2002::/16) and
|
||||||
|
# Teredo (2001::/32) are deprecated transition mechanisms with no legitimate
|
||||||
|
# fetch target, so they are blocked outright. ULA (fc00::/7, incl. the AWS
|
||||||
|
# IMDSv6 address fd00:ec2::254), link-local, and loopback are covered by the
|
||||||
|
# predicates in #disallowed_ipv6?.
|
||||||
|
DISALLOWED_IPV6 = %w[
|
||||||
|
::/128 100::/64 2001::/32 2001:2::/48 2001:db8::/32 2002::/16
|
||||||
|
fec0::/10 ff00::/8
|
||||||
|
].map { |cidr| IPAddr.new(cidr) }.freeze
|
||||||
|
|
||||||
|
# NAT64 prefixes: the well-known prefix (RFC 6052/6146) and the local-use
|
||||||
|
# prefix (RFC 8215). An address here embeds an IPv4 target in its low 32
|
||||||
|
# bits; we extract it and re-check against the IPv4 rules so NAT64 to a
|
||||||
|
# public address still resolves while NAT64 to an internal address is
|
||||||
|
# blocked.
|
||||||
|
NAT64_PREFIXES = [
|
||||||
|
IPAddr.new("64:ff9b::/96"),
|
||||||
|
IPAddr.new("64:ff9b:1::/48")
|
||||||
|
].freeze
|
||||||
|
|
||||||
def resolve(hostname)
|
def resolve(hostname)
|
||||||
Resolv.getaddress(hostname).tap do |ip|
|
Resolv.getaddress(hostname).tap do |ip|
|
||||||
@@ -15,11 +41,36 @@ module RestrictedHTTP
|
|||||||
end
|
end
|
||||||
|
|
||||||
def private_ip?(ip)
|
def private_ip?(ip)
|
||||||
IPAddr.new(ip).then do |ipaddr|
|
ipaddr = IPAddr.new(ip)
|
||||||
ipaddr.private? || ipaddr.loopback? || ipaddr.link_local? || ipaddr.ipv4_mapped? || ipaddr.ipv4_compat? || LOCAL_IP.include?(ipaddr)
|
|
||||||
|
# DNS never legitimately returns these embedded forms, so block them all
|
||||||
|
# regardless of the address they wrap.
|
||||||
|
if ipaddr.ipv4_mapped? || ipaddr.ipv4_compat?
|
||||||
|
true
|
||||||
|
elsif ipaddr.ipv4?
|
||||||
|
disallowed_ipv4?(ipaddr)
|
||||||
|
elsif NAT64_PREFIXES.any? { |prefix| prefix.include?(ipaddr) }
|
||||||
|
disallowed_ipv4?(embedded_ipv4(ipaddr))
|
||||||
|
else
|
||||||
|
disallowed_ipv6?(ipaddr)
|
||||||
end
|
end
|
||||||
rescue IPAddr::InvalidAddressError
|
rescue IPAddr::InvalidAddressError
|
||||||
true
|
true
|
||||||
end
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
def disallowed_ipv4?(ipaddr)
|
||||||
|
ipaddr.private? || ipaddr.loopback? || ipaddr.link_local? ||
|
||||||
|
DISALLOWED_IPV4.any? { |range| range.include?(ipaddr) }
|
||||||
|
end
|
||||||
|
|
||||||
|
def disallowed_ipv6?(ipaddr)
|
||||||
|
ipaddr.private? || ipaddr.loopback? || ipaddr.link_local? ||
|
||||||
|
DISALLOWED_IPV6.any? { |range| range.include?(ipaddr) }
|
||||||
|
end
|
||||||
|
|
||||||
|
def embedded_ipv4(ipaddr)
|
||||||
|
IPAddr.new([ ipaddr.to_i & 0xffffffff ].pack("N").unpack("C4").join("."))
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
Executable
+10
@@ -0,0 +1,10 @@
|
|||||||
|
#!/usr/bin/env ruby
|
||||||
|
require "bundler/setup"
|
||||||
|
require "securerandom"
|
||||||
|
require "web_push"
|
||||||
|
|
||||||
|
vapid_key = WebPush.generate_key
|
||||||
|
|
||||||
|
puts "SECRET_KEY_BASE=#{SecureRandom.hex(64)}"
|
||||||
|
puts "VAPID_PRIVATE_KEY=#{vapid_key.private_key}"
|
||||||
|
puts "VAPID_PUBLIC_KEY=#{vapid_key.public_key}"
|
||||||
@@ -0,0 +1,86 @@
|
|||||||
|
require "test_helper"
|
||||||
|
|
||||||
|
class RoomMessagesChannelTest < ActionCable::Channel::TestCase
|
||||||
|
tests RoomMessagesChannel
|
||||||
|
|
||||||
|
setup do
|
||||||
|
@room = rooms(:designers)
|
||||||
|
@signed_stream_name = Turbo::StreamsChannel.signed_stream_name [ @room, :messages ]
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a member may subscribe to a room's message stream" do
|
||||||
|
stub_connection(current_user: users(:kevin))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: @signed_stream_name
|
||||||
|
|
||||||
|
assert subscription.confirmed?
|
||||||
|
assert_has_stream Turbo.signed_stream_verifier.verified(@signed_stream_name)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a user who was never a member may not subscribe" do
|
||||||
|
stub_connection(current_user: users(:bender))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: @signed_stream_name
|
||||||
|
|
||||||
|
assert subscription.rejected?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a revoked member may not re-subscribe with a stream name harvested while a member" do
|
||||||
|
stub_connection(current_user: users(:kevin))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: @signed_stream_name
|
||||||
|
assert subscription.confirmed?, "kevin must start out able to subscribe"
|
||||||
|
|
||||||
|
@room.memberships.revoke_from users(:kevin)
|
||||||
|
|
||||||
|
subscribe signed_stream_name: @signed_stream_name
|
||||||
|
|
||||||
|
assert subscription.rejected?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "an unsigned stream name is rejected" do
|
||||||
|
stub_connection(current_user: users(:kevin))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: Turbo.signed_stream_verifier.verified(@signed_stream_name)
|
||||||
|
|
||||||
|
assert subscription.rejected?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a missing stream name is rejected" do
|
||||||
|
stub_connection(current_user: users(:kevin))
|
||||||
|
|
||||||
|
subscribe
|
||||||
|
|
||||||
|
assert subscription.rejected?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a validly signed stream name for another room the user isn't in is rejected" do
|
||||||
|
stub_connection(current_user: users(:bender))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: Turbo::StreamsChannel.signed_stream_name([ rooms(:hq), :messages ])
|
||||||
|
|
||||||
|
assert subscription.rejected?
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
class RoomMessagesViaStockTurboChannelTest < ActionCable::Channel::TestCase
|
||||||
|
tests Turbo::StreamsChannel
|
||||||
|
|
||||||
|
# The subscriber picks the channel, so the stock channel has to turn these names away
|
||||||
|
# too. Otherwise a revoked member just names Turbo::StreamsChannel instead.
|
||||||
|
test "the stock turbo channel refuses to serve a room message stream" do
|
||||||
|
stub_connection(current_user: users(:kevin))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: Turbo::StreamsChannel.signed_stream_name([ rooms(:designers), :messages ])
|
||||||
|
|
||||||
|
assert subscription.rejected?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "the stock turbo channel still serves the room list stream" do
|
||||||
|
stub_connection(current_user: users(:kevin))
|
||||||
|
|
||||||
|
subscribe signed_stream_name: Turbo::StreamsChannel.signed_stream_name([ :rooms ])
|
||||||
|
|
||||||
|
assert subscription.confirmed?
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -0,0 +1,47 @@
|
|||||||
|
require "test_helper"
|
||||||
|
|
||||||
|
class UnreadRoomsChannelTest < ActionCable::Channel::TestCase
|
||||||
|
test "streams only the subscriber's own unread stream" do
|
||||||
|
stub_connection(current_user: users(:jz))
|
||||||
|
|
||||||
|
subscribe
|
||||||
|
|
||||||
|
assert subscription.confirmed?
|
||||||
|
assert_has_stream "user_#{users(:jz).id}_unreads"
|
||||||
|
assert_not_includes subscription.streams, "unread_rooms"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "an outsider is not told about activity in a room they can't see" do
|
||||||
|
direct = rooms(:bender_and_kevin)
|
||||||
|
assert_not direct.users.include?(users(:jz)), "jz must be an outsider for this test to mean anything"
|
||||||
|
|
||||||
|
broadcasts = capture_unread_broadcasts_for(users(:jz)) do
|
||||||
|
direct.messages.create!(body: "Private", creator: users(:kevin), client_message_id: "outsider").broadcast_create
|
||||||
|
end
|
||||||
|
|
||||||
|
assert_empty broadcasts
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a member is told about activity in their own room" do
|
||||||
|
direct = rooms(:bender_and_kevin)
|
||||||
|
|
||||||
|
broadcasts = capture_unread_broadcasts_for(users(:kevin)) do
|
||||||
|
direct.messages.create!(body: "Private", creator: users(:bender), client_message_id: "member").broadcast_create
|
||||||
|
end
|
||||||
|
|
||||||
|
assert_equal [ direct.id ], broadcasts.collect { |broadcast| broadcast["roomId"] }
|
||||||
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
def capture_unread_broadcasts_for(user)
|
||||||
|
stub_connection(current_user: user)
|
||||||
|
subscribe
|
||||||
|
|
||||||
|
stream = subscription.streams.sole
|
||||||
|
before = ActionCable.server.pubsub.broadcasts(stream).size
|
||||||
|
|
||||||
|
yield
|
||||||
|
|
||||||
|
ActionCable.server.pubsub.broadcasts(stream).drop(before).collect { |broadcast| JSON.parse(broadcast) }
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -30,6 +30,13 @@ class Accounts::LogosControllerTest < ActionDispatch::IntegrationTest
|
|||||||
assert_valid_png_response size: 192
|
assert_valid_png_response size: 192
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "show stock when custom logo cannot be resized" do
|
||||||
|
accounts(:signal).update! logo: fixture_file_upload("pixel.bmp", "image/bmp")
|
||||||
|
|
||||||
|
get account_logo_url
|
||||||
|
assert_valid_png_response size: 512
|
||||||
|
end
|
||||||
|
|
||||||
test "destroy" do
|
test "destroy" do
|
||||||
accounts(:signal).update! logo: fixture_file_upload("moon.jpg", "image/jpeg")
|
accounts(:signal).update! logo: fixture_file_upload("moon.jpg", "image/jpeg")
|
||||||
|
|
||||||
|
|||||||
@@ -57,9 +57,22 @@ class MessagesControllerTest < ActionDispatch::IntegrationTest
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
test "creating a message broadcasts unread room" do
|
test "creating a message broadcasts unread room to each member" do
|
||||||
assert_broadcasts "unread_rooms", 1 do
|
@room.users.each do |member|
|
||||||
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
|
assert_broadcasts UnreadRoomsChannel.stream_name_for(member.id), 1 do
|
||||||
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one #{member.id}", client_message_id: member.id } }
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
test "creating a message doesn't broadcast unread room to non-members" do
|
||||||
|
outsiders = User.where.not(id: @room.users.map(&:id))
|
||||||
|
assert outsiders.any?, "need someone outside the room for this test to mean anything"
|
||||||
|
|
||||||
|
outsiders.each do |outsider|
|
||||||
|
assert_no_broadcasts UnreadRoomsChannel.stream_name_for(outsider.id) do
|
||||||
|
post room_messages_url(@room, format: :turbo_stream), params: { message: { body: "New one", client_message_id: 999 } }
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
@@ -66,6 +66,18 @@ class Rooms::ClosedsControllerTest < ActionDispatch::IntegrationTest
|
|||||||
assert rooms(:designers).reload.name, "Designers"
|
assert rooms(:designers).reload.name, "Designers"
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "a direct room can't be converted to closed and have its participants revised" do
|
||||||
|
sign_in :kevin
|
||||||
|
direct = rooms(:bender_and_kevin)
|
||||||
|
|
||||||
|
put rooms_closed_url(direct), params: {
|
||||||
|
room: { name: "Watercooler" }, user_ids: [ users(:kevin).id, users(:jz).id ]
|
||||||
|
}
|
||||||
|
|
||||||
|
assert_equal "Rooms::Direct", Room.find(direct.id).type
|
||||||
|
assert_equal [ users(:bender).id, users(:kevin).id ].sort, Room.find(direct.id).user_ids.sort
|
||||||
|
end
|
||||||
|
|
||||||
test "remove yourself" do
|
test "remove yourself" do
|
||||||
assert_difference -> { users(:david).rooms.count }, -1 do
|
assert_difference -> { users(:david).rooms.count }, -1 do
|
||||||
put rooms_closed_url(rooms(:designers), params: { room: { name: "Designers" }, user_ids: [ users(:jason).id, users(:jz).id ] })
|
put rooms_closed_url(rooms(:designers), params: { room: { name: "Designers" }, user_ids: [ users(:jason).id, users(:jz).id ] })
|
||||||
|
|||||||
@@ -29,4 +29,34 @@ class Rooms::DirectsControllerTest < ActionDispatch::IntegrationTest
|
|||||||
assert_redirected_to root_url
|
assert_redirected_to root_url
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "destroy can't reach a closed room the member didn't create" do
|
||||||
|
sign_in :kevin
|
||||||
|
|
||||||
|
assert_no_difference -> { Room.count } do
|
||||||
|
delete rooms_direct_url(rooms(:designers))
|
||||||
|
end
|
||||||
|
|
||||||
|
assert rooms(:designers).reload.persisted?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "destroy can't reach an open room the member didn't create" do
|
||||||
|
sign_in :kevin
|
||||||
|
|
||||||
|
assert_no_difference -> { Room.count } do
|
||||||
|
delete rooms_direct_url(rooms(:hq))
|
||||||
|
end
|
||||||
|
|
||||||
|
assert rooms(:hq).reload.persisted?
|
||||||
|
end
|
||||||
|
|
||||||
|
test "destroy can't reach a room the member isn't in at all" do
|
||||||
|
sign_in :jz
|
||||||
|
|
||||||
|
assert_no_difference -> { Room.count } do
|
||||||
|
delete rooms_direct_url(rooms(:david_and_kevin))
|
||||||
|
end
|
||||||
|
|
||||||
|
assert rooms(:david_and_kevin).reload.persisted?
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -57,4 +57,23 @@ class Rooms::OpensControllerTest < ActionDispatch::IntegrationTest
|
|||||||
put rooms_open_url(rooms(:designers)), params: { room: { name: "Doesn't matter" } }
|
put rooms_open_url(rooms(:designers)), params: { room: { name: "Doesn't matter" } }
|
||||||
assert_equal rooms(:designers).memberships.count, User.count
|
assert_equal rooms(:designers).memberships.count, User.count
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "a direct room can't be promoted to open by its creator" do
|
||||||
|
sign_in :kevin
|
||||||
|
direct = rooms(:bender_and_kevin)
|
||||||
|
|
||||||
|
put rooms_open_url(direct), params: { room: { name: "Watercooler" } }
|
||||||
|
|
||||||
|
assert_equal "Rooms::Direct", Room.find(direct.id).type
|
||||||
|
assert_equal [ users(:bender).id, users(:kevin).id ].sort, Room.find(direct.id).user_ids.sort
|
||||||
|
end
|
||||||
|
|
||||||
|
test "a direct room can't be promoted to open by an administrator either" do
|
||||||
|
direct = rooms(:david_and_kevin)
|
||||||
|
|
||||||
|
put rooms_open_url(direct), params: { room: { name: "Watercooler" } }
|
||||||
|
|
||||||
|
assert_equal "Rooms::Direct", Room.find(direct.id).type
|
||||||
|
assert_equal [ users(:david).id, users(:kevin).id ].sort, Room.find(direct.id).user_ids.sort
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -18,6 +18,14 @@ class Users::AvatarsControllerTest < ActionDispatch::IntegrationTest
|
|||||||
assert_equal "image/webp", @response.content_type
|
assert_equal "image/webp", @response.content_type
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "show initials when image cannot be resized" do
|
||||||
|
users(:kevin).update! avatar: fixture_file_upload("pixel.bmp", "image/bmp")
|
||||||
|
get user_avatar_url(users(:kevin).avatar_token)
|
||||||
|
|
||||||
|
assert_response :success
|
||||||
|
assert_select "text", text: "K"
|
||||||
|
end
|
||||||
|
|
||||||
test "show image with invalid token responds 404" do
|
test "show image with invalid token responds 404" do
|
||||||
get user_avatar_url("not-a-valid-token")
|
get user_avatar_url("not-a-valid-token")
|
||||||
|
|
||||||
|
|||||||
Vendored
BIN
Binary file not shown.
|
After Width: | Height: | Size: 58 B |
@@ -61,6 +61,75 @@ class ContentFiltersTest < ActionView::TestCase
|
|||||||
assert_equal "Hello World", filtered.to_html
|
assert_equal "Hello World", filtered.to_html
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "message with a link using an unsafe URI scheme" do
|
||||||
|
message = Message.create! room: rooms(:pets), body: '<div><a href="javascript:alert(1)">x</a></div>', client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
filtered = ContentFilters::TextMessagePresentationFilters.apply(message.body.body)
|
||||||
|
assert_no_match /javascript:/, filtered.to_html
|
||||||
|
assert_match /<a>x<\/a>/, filtered.to_html
|
||||||
|
end
|
||||||
|
|
||||||
|
test "message with an event handler attribute on an allowed tag" do
|
||||||
|
message = Message.create! room: rooms(:pets), body: '<div><a href="/x" onmouseover="alert(1)">x</a> <span onclick="alert(2)">y</span></div>', client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
filtered = ContentFilters::TextMessagePresentationFilters.apply(message.body.body)
|
||||||
|
assert_no_match /onmouseover/, filtered.to_html
|
||||||
|
assert_no_match /onclick/, filtered.to_html
|
||||||
|
assert_match /<a href="\/x">x<\/a>/, filtered.to_html
|
||||||
|
assert_match /<span>y<\/span>/, filtered.to_html
|
||||||
|
end
|
||||||
|
|
||||||
|
test "message with a data URI link" do
|
||||||
|
message = Message.create! room: rooms(:pets), body: '<div><a href="data:text/html,pwned">x</a></div>', client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
filtered = ContentFilters::TextMessagePresentationFilters.apply(message.body.body)
|
||||||
|
assert_no_match /data:/, filtered.to_html
|
||||||
|
assert_match /<a>x<\/a>/, filtered.to_html
|
||||||
|
end
|
||||||
|
|
||||||
|
test "message with a safe link and formatting is preserved" do
|
||||||
|
body = '<div><a href="https://example.com">example</a> <strong>bold</strong> <code>code</code><ul><li>one</li><li>two</li></ul></div>'
|
||||||
|
message = Message.create! room: rooms(:pets), body: body, client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
filtered = ContentFilters::TextMessagePresentationFilters.apply(message.body.body)
|
||||||
|
assert_match /<a href="https:\/\/example\.com">example<\/a>/, filtered.to_html
|
||||||
|
assert_match /<strong>bold<\/strong>/, filtered.to_html
|
||||||
|
assert_match /<code>code<\/code>/, filtered.to_html
|
||||||
|
assert_match /<ul>\s*<li>one<\/li>\s*<li>two<\/li>\s*<\/ul>/, filtered.to_html
|
||||||
|
end
|
||||||
|
|
||||||
|
test "SanitizeAttributes uses an isolated sanitizer rather than the shared ActionText instance" do
|
||||||
|
filter = ContentFilters::SanitizeAttributes.new(ActionText::Content.new("<div>x</div>"))
|
||||||
|
|
||||||
|
isolated = filter.send(:sanitizer)
|
||||||
|
assert_not_same ActionText::ContentHelper.sanitizer, isolated,
|
||||||
|
"must not reuse the process-wide ActionText sanitizer, whose permit scrubber is mutated per call"
|
||||||
|
assert_not_same isolated, filter.send(:sanitizer),
|
||||||
|
"each call must build a fresh sanitizer so concurrent requests never share scrubber state"
|
||||||
|
assert_kind_of ActionText::ContentHelper.sanitizer.class, isolated
|
||||||
|
end
|
||||||
|
|
||||||
|
test "SanitizeAttributes neutralizes unsafe input and preserves benign content on its isolated sanitizer" do
|
||||||
|
body = <<~HTML.squish
|
||||||
|
<div><a href="javascript:alert(1)" onclick="x()">link</a>
|
||||||
|
<a href="data:text/html,pwned">data</a>
|
||||||
|
<span class="cf-twitter-avatar" onmouseover="y()">avatar</span>
|
||||||
|
<img src="https://evil.example/x.svg"> Hey #{mention_attachment_for(:david)}</div>
|
||||||
|
HTML
|
||||||
|
message = Message.create! room: rooms(:pets), body: body, client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
filtered = ContentFilters::SanitizeAttributes.apply(message.body.body).to_html
|
||||||
|
|
||||||
|
assert_no_match /javascript:/, filtered
|
||||||
|
assert_no_match /data:text\/html/, filtered
|
||||||
|
assert_no_match /onclick/, filtered
|
||||||
|
assert_no_match /onmouseover/, filtered
|
||||||
|
assert_no_match /evil\.example/, filtered
|
||||||
|
assert_match /<span class="cf-twitter-avatar">avatar<\/span>/, filtered
|
||||||
|
assert_match />link</, filtered
|
||||||
|
assert_match /<action-text-attachment sgid="#{users(:david).attachable_sgid}"/, filtered
|
||||||
|
end
|
||||||
|
|
||||||
test "message with a mention attachment" do
|
test "message with a mention attachment" do
|
||||||
message = Message.create! room: rooms(:pets), body: "<div>Hey #{mention_attachment_for(:david)}</div>", creator: users(:jason)
|
message = Message.create! room: rooms(:pets), body: "<div>Hey #{mention_attachment_for(:david)}</div>", creator: users(:jason)
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,27 @@
|
|||||||
|
require "test_helper"
|
||||||
|
|
||||||
|
class MessagesHelperTest < ActionView::TestCase
|
||||||
|
test "message_presentation neutralizes unsafe URI schemes in links" do
|
||||||
|
message = Message.create! room: rooms(:pets), body: '<div><a href="javascript:alert(1)">x</a></div>', client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
presentation = view.message_presentation(message)
|
||||||
|
assert_no_match /javascript:/, presentation
|
||||||
|
assert_match /<a>x<\/a>/, presentation
|
||||||
|
end
|
||||||
|
|
||||||
|
test "message_presentation strips event handler attributes from allowed tags" do
|
||||||
|
message = Message.create! room: rooms(:pets), body: '<div><a href="/x" onmouseover="alert(1)">x</a></div>', client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
presentation = view.message_presentation(message)
|
||||||
|
assert_no_match /onmouseover/, presentation
|
||||||
|
assert_match /<a href="\/x">x<\/a>/, presentation
|
||||||
|
end
|
||||||
|
|
||||||
|
test "message_presentation preserves safe links and formatting" do
|
||||||
|
message = Message.create! room: rooms(:pets), body: '<div><a href="https://example.com">example</a> <strong>bold</strong></div>', client_message_id: "0015", creator: users(:jason)
|
||||||
|
|
||||||
|
presentation = view.message_presentation(message)
|
||||||
|
assert_match /<a href="https:\/\/example\.com"[^>]*>example<\/a>/, presentation
|
||||||
|
assert_match /<strong>bold<\/strong>/, presentation
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -64,6 +64,50 @@ class RestrictedHTTP::PrivateNetworkGuardTest < ActiveSupport::TestCase
|
|||||||
assert_private_ip "::93.184.216.34"
|
assert_private_ip "::93.184.216.34"
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns true for carrier-grade NAT addresses (RFC6598)" do
|
||||||
|
assert_private_ip "100.64.0.1"
|
||||||
|
assert_private_ip "100.127.255.255"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns true for NAT64 addresses embedding a private IPv4" do
|
||||||
|
assert_private_ip "64:ff9b::a9fe:a9fe" # NAT64 -> 169.254.169.254 (AWS metadata)
|
||||||
|
assert_private_ip "64:ff9b::a00:5" # NAT64 -> 10.0.0.5
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns true for local-use NAT64 addresses embedding a private IPv4 (RFC8215)" do
|
||||||
|
assert_private_ip "64:ff9b:1::a00:1" # local-use NAT64 -> 10.0.0.1
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns false for local-use NAT64 addresses embedding a public IPv4 (RFC8215)" do
|
||||||
|
assert_not RestrictedHTTP::PrivateNetworkGuard.private_ip?("64:ff9b:1::808:808") # -> 8.8.8.8
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns false for NAT64 addresses embedding a public IPv4" do
|
||||||
|
# DNS64 legitimately synthesizes these for public sites on IPv6-only hosts.
|
||||||
|
assert_not RestrictedHTTP::PrivateNetworkGuard.private_ip?("64:ff9b::808:808") # -> 8.8.8.8
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns true for 6to4 and Teredo transition addresses" do
|
||||||
|
assert_private_ip "2002:a9fe:a9fe::" # 6to4 embedding 169.254.169.254
|
||||||
|
assert_private_ip "2001::1" # Teredo
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns true for IPv6 loopback, ULA, and link-local" do
|
||||||
|
assert_private_ip "::1"
|
||||||
|
assert_private_ip "fd00:ec2::254" # AWS IMDSv6 (ULA)
|
||||||
|
assert_private_ip "fe80::1"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns true for IPv6 multicast, documentation, and benchmarking ranges" do
|
||||||
|
assert_private_ip "ff02::1"
|
||||||
|
assert_private_ip "2001:db8::1"
|
||||||
|
assert_private_ip "2001:2::1" # benchmarking (RFC5180), matches 198.18.0.0/15
|
||||||
|
end
|
||||||
|
|
||||||
|
test "private_ip? returns false for public IPv6 addresses" do
|
||||||
|
assert_not RestrictedHTTP::PrivateNetworkGuard.private_ip?("2606:4700:4700::1111")
|
||||||
|
end
|
||||||
|
|
||||||
test "private_ip? returns true for invalid addresses" do
|
test "private_ip? returns true for invalid addresses" do
|
||||||
assert RestrictedHTTP::PrivateNetworkGuard.private_ip?("not-an-ip")
|
assert RestrictedHTTP::PrivateNetworkGuard.private_ip?("not-an-ip")
|
||||||
assert RestrictedHTTP::PrivateNetworkGuard.private_ip?("")
|
assert RestrictedHTTP::PrivateNetworkGuard.private_ip?("")
|
||||||
|
|||||||
@@ -0,0 +1,118 @@
|
|||||||
|
require "test_helper"
|
||||||
|
require "vips"
|
||||||
|
require "tempfile"
|
||||||
|
|
||||||
|
# libvips selects a loader from a file's actual bytes, not from its declared content type. These
|
||||||
|
# tests pin which loader is selected for each file type under the app's configured loader policy
|
||||||
|
# (config/initializers/vips.rb).
|
||||||
|
class VipsLoaderPolicyTest < ActiveSupport::TestCase
|
||||||
|
# Header bytes are enough for libvips to identify a format; native types are encoded live, exotic
|
||||||
|
# ones are represented by their magic bytes.
|
||||||
|
FTYP_AVIF = "\x00\x00\x00\x1cftypavif\x00\x00\x00\x00avifmif1miaf".b
|
||||||
|
FTYP_HEIC = "\x00\x00\x00\x1cftypheic\x00\x00\x00\x00heicmif1miaf".b
|
||||||
|
BMP = "BM" + [ 0, 0, 54 ].pack("V3") + "\x00" * 40
|
||||||
|
PSD = "8BPS" + [ 1 ].pack("n") + "\x00" * 26
|
||||||
|
ICO = "\x00\x00\x01\x00\x01\x00" + "\x00" * 16
|
||||||
|
SVG = %q(<svg xmlns="http://www.w3.org/2000/svg" width="8" height="8"/>)
|
||||||
|
|
||||||
|
test "loads PNG" do
|
||||||
|
assert_equal "VipsForeignLoadPngFile", loader_for(encode("png"))
|
||||||
|
end
|
||||||
|
|
||||||
|
test "loads GIF" do
|
||||||
|
assert_equal "VipsForeignLoadNsgifFile", loader_for(encode("gif"))
|
||||||
|
end
|
||||||
|
|
||||||
|
test "loads JPEG" do
|
||||||
|
assert_equal "VipsForeignLoadJpegFile", loader_for(encode("jpg"))
|
||||||
|
end
|
||||||
|
|
||||||
|
test "loads TIFF" do
|
||||||
|
assert_equal "VipsForeignLoadTiffFile", loader_for(encode("tif"))
|
||||||
|
end
|
||||||
|
|
||||||
|
test "loads WebP" do
|
||||||
|
assert_equal "VipsForeignLoadWebpFile", loader_for(encode("webp"))
|
||||||
|
end
|
||||||
|
|
||||||
|
test "loads AVIF" do
|
||||||
|
assert_equal "VipsForeignLoadHeifFile", loader_for(FTYP_AVIF)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "loads HEIC" do
|
||||||
|
assert_equal "VipsForeignLoadHeifFile", loader_for(FTYP_HEIC)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies BMP through magickload" do
|
||||||
|
assert_nil loader_for(BMP)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies PSD through magickload" do
|
||||||
|
assert_nil loader_for(PSD)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies ICO through magickload" do
|
||||||
|
assert_nil loader_for(ICO)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies SVG through svgload" do
|
||||||
|
assert_nil loader_for(SVG)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies OpenSlide files through openslideload" do
|
||||||
|
# OpenSlide files can segfault the embedded sqlite in forked parallel workers
|
||||||
|
assert_loader_blocked :openslideload, ".svs"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies FITS files through fitsload" do
|
||||||
|
assert_loader_blocked :fitsload, ".fits"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies MATLAB files through matload" do
|
||||||
|
assert_loader_blocked :matload, ".mat"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies NIFTI files through niftiload" do
|
||||||
|
assert_loader_blocked :niftiload, ".nii"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies RAW files through dcrawload" do
|
||||||
|
assert_loader_blocked :dcrawload, ".raw"
|
||||||
|
end
|
||||||
|
|
||||||
|
test "denies VIPS files through vipsload" do
|
||||||
|
assert_loader_blocked :vipsload, ".vips"
|
||||||
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
# Invoke a specific libvips loader directly and assert it is refused because the
|
||||||
|
# operation is blocked (rather than because the bytes are not a valid image).
|
||||||
|
def assert_loader_blocked(operation, extension)
|
||||||
|
Tempfile.create([ "blocked_loader", extension ], binmode: true) do |file|
|
||||||
|
file.write "not an image"
|
||||||
|
file.flush
|
||||||
|
|
||||||
|
error = assert_raises(Vips::Error) { Vips::Image.public_send(operation, file.path) }
|
||||||
|
actual = error.message.chomp
|
||||||
|
|
||||||
|
# note that exception message may include multiple errors on separate lines,
|
||||||
|
# so `^` and `$` anchors are used instead of `\A` and `\z`.
|
||||||
|
if actual =~ /^VipsOperation: class \"#{operation}\" not found$/
|
||||||
|
skip "libvips does not support #{operation} on this system"
|
||||||
|
end
|
||||||
|
assert_match(/^#{operation}: operation is blocked$/, actual)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
def encode(ext)
|
||||||
|
Vips::Image.black(8, 8).add(128).cast("uchar").write_to_buffer(".#{ext}")
|
||||||
|
end
|
||||||
|
|
||||||
|
def loader_for(bytes)
|
||||||
|
Tempfile.create(%w[loader_probe .img], binmode: true) do |file|
|
||||||
|
file.write bytes
|
||||||
|
file.flush
|
||||||
|
Vips.vips_foreign_find_load(file.path)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
@@ -15,4 +15,20 @@ class AccountTest < ActiveSupport::TestCase
|
|||||||
accounts(:signal).update!(settings: { "restrict_room_creation_to_administrators" => "false" })
|
accounts(:signal).update!(settings: { "restrict_room_creation_to_administrators" => "false" })
|
||||||
assert_not accounts(:signal).reload.settings.restrict_room_creation_to_administrators?
|
assert_not accounts(:signal).reload.settings.restrict_room_creation_to_administrators?
|
||||||
end
|
end
|
||||||
|
|
||||||
|
test "logo_variant is a resized variant of a variable logo" do
|
||||||
|
accounts(:signal).logo.attach io: file_fixture("moon.jpg").open, filename: "moon.jpg", content_type: "image/jpeg"
|
||||||
|
|
||||||
|
assert_kind_of ActiveStorage::VariantWithRecord, accounts(:signal).logo_variant(:large)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "logo_variant is nil when the logo cannot be resized" do
|
||||||
|
accounts(:signal).logo.attach io: file_fixture("pixel.bmp").open, filename: "pixel.bmp", content_type: "image/bmp"
|
||||||
|
|
||||||
|
assert_nil accounts(:signal).logo_variant(:large)
|
||||||
|
end
|
||||||
|
|
||||||
|
test "logo_variant is nil without a logo" do
|
||||||
|
assert_nil accounts(:signal).logo_variant(:large)
|
||||||
|
end
|
||||||
end
|
end
|
||||||
@@ -49,8 +49,8 @@ class Opengraph::FetchTest < ActiveSupport::TestCase
|
|||||||
# to a resolved IP, not a hostname to re-resolve.
|
# to a resolved IP, not a hostname to re-resolve.
|
||||||
WebMock.disable_net_connect! allow: [ @url.host ]
|
WebMock.disable_net_connect! allow: [ @url.host ]
|
||||||
Resolv.stubs(:getaddress).with(@url.host).returns("1.2.3.4", "127.0.0.1")
|
Resolv.stubs(:getaddress).with(@url.host).returns("1.2.3.4", "127.0.0.1")
|
||||||
TCPSocket.expects(:open).with(@url.host, 443, nil, nil).never
|
TCPSocket.expects(:open).with { |*args, **| args.first == @url.host }.never
|
||||||
TCPSocket.expects(:open).with("1.2.3.4", 443, nil, nil).throws(:dns_not_rebound)
|
TCPSocket.expects(:open).with { |*args, **| args.first == "1.2.3.4" && args[1] == 443 }.throws(:dns_not_rebound)
|
||||||
|
|
||||||
assert_throws :dns_not_rebound do
|
assert_throws :dns_not_rebound do
|
||||||
@fetch.fetch_document(@url)
|
@fetch.fetch_document(@url)
|
||||||
@@ -66,8 +66,8 @@ class Opengraph::FetchTest < ActiveSupport::TestCase
|
|||||||
# to a resolved IP, not a hostname to re-resolve.
|
# to a resolved IP, not a hostname to re-resolve.
|
||||||
WebMock.disable_net_connect! allow: [ @url.host ]
|
WebMock.disable_net_connect! allow: [ @url.host ]
|
||||||
Resolv.stubs(:getaddress).with(@url.host).returns("1.2.3.4", "127.0.0.1")
|
Resolv.stubs(:getaddress).with(@url.host).returns("1.2.3.4", "127.0.0.1")
|
||||||
TCPSocket.expects(:open).with(@url.host, 443, nil, nil).never
|
TCPSocket.expects(:open).with { |*args, **| args.first == @url.host }.never
|
||||||
TCPSocket.expects(:open).with("1.2.3.4", 443, nil, nil).throws(:dns_not_rebound)
|
TCPSocket.expects(:open).with { |*args, **| args.first == "1.2.3.4" && args[1] == 443 }.throws(:dns_not_rebound)
|
||||||
|
|
||||||
assert_throws :dns_not_rebound do
|
assert_throws :dns_not_rebound do
|
||||||
@fetch.fetch_document(URI.parse("https://www.other.com/"), ip: "1.2.3.4")
|
@fetch.fetch_document(URI.parse("https://www.other.com/"), ip: "1.2.3.4")
|
||||||
|
|||||||
@@ -0,0 +1,19 @@
|
|||||||
|
require "test_helper"
|
||||||
|
|
||||||
|
class User::AvatarTest < ActiveSupport::TestCase
|
||||||
|
test "avatar_variant is a resized variant of a variable avatar" do
|
||||||
|
users(:kevin).avatar.attach io: file_fixture("moon.jpg").open, filename: "moon.jpg", content_type: "image/jpeg"
|
||||||
|
|
||||||
|
assert_kind_of ActiveStorage::VariantWithRecord, users(:kevin).avatar_variant
|
||||||
|
end
|
||||||
|
|
||||||
|
test "avatar_variant is nil when the avatar cannot be resized" do
|
||||||
|
users(:kevin).avatar.attach io: file_fixture("pixel.bmp").open, filename: "pixel.bmp", content_type: "image/bmp"
|
||||||
|
|
||||||
|
assert_nil users(:kevin).avatar_variant
|
||||||
|
end
|
||||||
|
|
||||||
|
test "avatar_variant is nil without an avatar" do
|
||||||
|
assert_nil users(:kevin).avatar_variant
|
||||||
|
end
|
||||||
|
end
|
||||||
Vendored
-7
@@ -1,7 +0,0 @@
|
|||||||
/*
|
|
||||||
Trix 2.1.19
|
|
||||||
Copyright © 2026 37signals, LLC
|
|
||||||
*/
|
|
||||||
var t="2.1.19";const e="[data-trix-attachment]",i={preview:{presentation:"gallery",caption:{name:!0,size:!0}},file:{caption:{size:!0}}},n={default:{tagName:"div",parse:!1},quote:{tagName:"blockquote",nestable:!0},heading1:{tagName:"h1",terminal:!0,breakOnReturn:!0,group:!1},code:{tagName:"pre",terminal:!0,htmlAttributes:["language"],text:{plaintext:!0}},bulletList:{tagName:"ul",parse:!1},bullet:{tagName:"li",listAttribute:"bulletList",group:!1,nestable:!0,test(t){return r(t.parentNode)===n[this.listAttribute].tagName}},numberList:{tagName:"ol",parse:!1},number:{tagName:"li",listAttribute:"numberList",group:!1,nestable:!0,test(t){return r(t.parentNode)===n[this.listAttribute].tagName}},attachmentGallery:{tagName:"div",exclusive:!0,terminal:!0,parse:!1,group:!1}},r=t=>{var e;return null==t||null===(e=t.tagName)||void 0===e?void 0:e.toLowerCase()},o=navigator.userAgent.match(/android\s([0-9]+.*Chrome)/i),s=o&&parseInt(o[1]);var a={composesExistingText:/Android.*Chrome/.test(navigator.userAgent),recentAndroid:s&&s>12,samsungAndroid:s&&navigator.userAgent.match(/Android.*SM-/),forcesObjectResizing:/Trident.*rv:11/.test(navigator.userAgent),supportsInputEvents:"undefined"!=typeof InputEvent&&["data","getTargetRanges","inputType"].every((t=>t in InputEvent.prototype))},l={ADD_ATTR:["language"],SAFE_FOR_XML:!1,RETURN_DOM:!0},c={attachFiles:"Attach Files",bold:"Bold",bullets:"Bullets",byte:"Byte",bytes:"Bytes",captionPlaceholder:"Add a caption…",code:"Code",heading1:"Heading",indent:"Increase Level",italic:"Italic",link:"Link",numbers:"Numbers",outdent:"Decrease Level",quote:"Quote",redo:"Redo",remove:"Remove",strike:"Strikethrough",undo:"Undo",unlink:"Unlink",url:"URL",urlPlaceholder:"Enter a URL…",GB:"GB",KB:"KB",MB:"MB",PB:"PB",TB:"TB"};const u=[c.bytes,c.KB,c.MB,c.GB,c.TB,c.PB];var h={prefix:"IEC",precision:2,formatter(t){switch(t){case 0:return"0 ".concat(c.bytes);case 1:return"1 ".concat(c.byte);default:let e;"SI"===this.prefix?e=1e3:"IEC"===this.prefix&&(e=1024);const i=Math.floor(Math.log(t)/Math.log(e)),n=(t/Math.pow(e,i)).toFixed(this.precision).replace(/0*$/,"").replace(/\.$/,"");return"".concat(n," ").concat(u[i])}}};const d="\ufeff",g=" ",m=function(t){for(const e in t){const i=t[e];this[e]=i}return this},p=document.documentElement,f=p.matches,b=function(t){let{onElement:e,matchingSelector:i,withCallback:n,inPhase:r,preventDefault:o,times:s}=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};const a=e||p,l=i,c="capturing"===r,u=function(t){null!=s&&0==--s&&u.destroy();const e=x(t.target,{matchingSelector:l});null!=e&&(null==n||n.call(e,t,e),o&&t.preventDefault())};return u.destroy=()=>a.removeEventListener(t,u,c),a.addEventListener(t,u,c),u},v=function(t){let{bubbles:e,cancelable:i,attributes:n}=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};e=!1!==e,i=!1!==i;const r=document.createEvent("Events");return r.initEvent(t,e,i),null!=n&&m.call(r,n),r},A=function(t){let{onElement:e,bubbles:i,cancelable:n,attributes:r}=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};const o=null!=e?e:p,s=v(t,{bubbles:i,cancelable:n,attributes:r});return o.dispatchEvent(s)},y=function(t,e){if(1===(null==t?void 0:t.nodeType))return f.call(t,e)},x=function(t){let{matchingSelector:e,untilNode:i}=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};for(;t&&t.nodeType!==Node.ELEMENT_NODE;)t=t.parentNode;if(null!=t){if(null==e)return t;if(t.closest&&null==i)return t.closest(e);for(;t&&t!==i;){if(y(t,e))return t;t=t.parentNode}}},C=t=>document.activeElement!==t&&E(t,document.activeElement),E=function(t,e){if(t&&e)for(;e;){if(e===t)return!0;e=e.parentNode}},S=function(t){var e;if(null===(e=t)||void 0===e||!e.parentNode)return;let i=0;for(t=t.previousSibling;t;)i++,t=t.previousSibling;return i},R=t=>{var e;return null==t||null===(e=t.parentNode)||void 0===e?void 0:e.removeChild(t)},T=function(t){let{onlyNodesOfType:e,usingFilter:i,expandEntityReferences:n}=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};const r=(()=>{switch(e){case"element":return NodeFilter.SHOW_ELEMENT;case"text":return NodeFilter.SHOW_TEXT;case"comment":return NodeFilter.SHOW_COMMENT;default:return NodeFilter.SHOW_ALL}})();return document.createTreeWalker(t,r,null!=i?i:null,!0===n)},k=t=>{var e;return null==t||null===(e=t.tagName)||void 0===e?void 0:e.toLowerCase()},w=function(t){let e,i,n=arguments.length>1&&void 0!==arguments[1]?arguments[1]:{};"object"==typeof t?(n=t,t=n.tagName):n={attributes:n};const r=document.createElement(t);if(null!=n.editable&&(null==n.attributes&&(n.attributes={}),n.attributes.contenteditable=n.editable),n.attributes)for(e in n.attributes)i=n.attributes[e],r.setAttribute(e,i);if(n.style)for(e in n.style)i=n.style[e],r.style[e]=i;if(n.data)for(e in n.data)i=n.data[e],r.dataset[e]=i;return n.className&&n.className.split(" ").forEach((t=>{r.classList.add(t)})),n.textContent&&(r.textContent=n.textContent),n.childNodes&&[].concat(n.childNodes).forEach((t=>{r.appendChild(t)})),r};let D;const L=funLine truncated
|
|
||||||
/*! @license DOMPurify 3.4.2 | (c) Cure53 and other contributors | Released under the Apache license 2.0 and Mozilla Public License 2.0 | github.com/cure53/DOMPurify/blob/3.4.2/LICENSE */const{entries:oe,setPrototypeOf:se,isFrozen:ae,getPrototypeOf:le,getOwnPropertyDescriptor:ce}=Object;let{freeze:ue,seal:he,create:de}=Object,{apply:ge,construct:me}="undefined"!=typeof Reflect&&Reflect;ue||(ue=function(t){return t}),he||(he=function(t){return t}),ge||(ge=function(t,e){for(var i=arguments.length,n=new Array(i>2?i-2:0),r=2;r<i;r++)n[r-2]=arguments[r];return t.apply(e,n)}),me||(me=function(t){for(var e=arguments.length,i=new Array(e>1?e-1:0),n=1;n<e;n++)i[n-1]=arguments[n];return new t(...i)});const pe=Me(Array.prototype.forEach),fe=Me(Array.prototype.lastIndexOf),be=Me(Array.prototype.pop),ve=Me(Array.prototype.push),Ae=Me(Array.prototype.splice),ye=Array.isArray,xe=Me(String.prototype.toLowerCase),Ce=Me(String.prototype.toString),Ee=Me(String.prototype.match),Se=Me(String.prototype.replace),Re=Me(String.prototype.indexOf),Te=Me(String.prototype.trim),ke=Me(Number.prototype.toString),we=Me(Boolean.prototype.toString),De="undefined"==typeof BigInt?null:Me(BigInt.prototype.toString),Le="undefined"==typeof Symbol?null:Me(Symbol.prototype.toString),Ne=Me(Object.prototype.hasOwnProperty),Ie=Me(Object.prototype.toString),Oe=Me(RegExp.prototype.test),Fe=(Pe=TypeError,function(){for(var t=arguments.length,e=new Array(t),i=0;i<t;i++)e[i]=arguments[i];return me(Pe,e)});var Pe;function Me(t){return function(e){e instanceof RegExp&&(e.lastIndex=0);for(var i=arguments.length,n=new Array(i>1?i-1:0),r=1;r<i;r++)n[r-1]=arguments[r];return ge(t,e,n)}}function Be(t,e){let i=arguments.length>2&&void 0!==arguments[2]?arguments[2]:xe;if(se&&se(t,null),!ye(e))return t;let n=e.length;for(;n--;){let r=e[n];if("string"==typeof r){const t=i(r);t!==r&&(ae(e)||(e[n]=t),r=t)}t[r]=!0}return t}function _e(t){for(let e=0;e<t.length;e++){Ne(t,e)||(t[e]=null)}return t}function je(t){const e=de(null);for(const[i,n]of oe(t)){Ne(t,i)&&(ye(n)?e[i]=_e(n):n&&"object"==typeof n&&n.constructor===Object?e[i]=je(n):e[i]=n)}return e}function We(t,e){for(;null!==t;){const i=ce(t,e);if(i){if(i.get)return Me(i.get);if("function"==typeof i.value)return Me(i.value)}t=le(t)}return function(){return null}}const Ue=ue(["a","abbr","acronym","address","area","article","aside","audio","b","bdi","bdo","big","blink","blockquote","body","br","button","canvas","caption","center","cite","code","col","colgroup","content","data","datalist","dd","decorator","del","details","dfn","dialog","dir","div","dl","dt","element","em","fieldset","figcaption","figure","font","footer","form","h1","h2","h3","h4","h5","h6","head","header","hgroup","hr","html","i","img","input","ins","kbd","label","legend","li","main","map","mark","marquee","menu","menuitem","meter","nav","nobr","ol","optgroup","option","output","p","picture","pre","progress","q","rp","rt","ruby","s","samp","search","section","select","shadow","slot","small","source","spacer","span","strike","strong","style","sub","summary","sup","table","tbody","td","template","textarea","tfoot","th","thead","time","tr","track","tt","u","ul","var","video","wbr"]),Ve=ue(["svg","a","altglyph","altglyphdef","altglyphitem","animatecolor","animatemotion","animatetransform","circle","clippath","defs","desc","ellipse","enterkeyhint","exportparts","filter","font","g","glyph","glyphref","hkern","image","inputmode","line","lineargradient","marker","mask","metadata","mpath","part","path","pattern","polygon","polyline","radialgradient","rect","stop","style","switch","symbol","text","textpath","title","tref","tspan","view","vkern"]),ze=ue(["feBlend","feColorMatrix","feComponentTransfer","feComposite","feConvolveMatrix","feDiffuseLighting","feDisplacementMap","feDistantLight","feDropShadow","feFlood","feFuncA","feFuncB","feFuncG","feFuncR","feGaussianBlur","feImage","feMerge","feMergeNode","feMorphology","feOffset","fePointLight","feSpecularLighting","feSpotLight","feTile","feTurbulence"]),He=ue(["animate","color-profile","cursor","discard","font-face","font-face-format","font-face-name","font-face-src","font-face-uri","foreignobject","hatch","hatchpath","mesh","meshgradient","meshpatch","meshrow","missing-glyph","script","set","solidcolor","unknown","use"]),qe=ue(["math","menclose","merror","mfenced","mfrac","mglyph","mi","mlabeledtr","mmultiscripts","mn","mo","mover","mpadded","mphantom","mroot","mrow","ms","mspace","msqrt","mstyle","msub","msup","msubsup","mtable","mtd","mtext","mtr","munder","munderover","mprescripts"]),Je=ue(["maction","maligngroup","malignmark","mlongdiv","mscarries","mscarry","msgroup","mstack","msline","msrow","semantics","annotation","annotation-xml","mprescripts","none"]),Ke=ue(["#text"]),Ge=ue(["accept","action","align","alt","autocapitalize","autocomplete","autopictureinpicture","autoplay","background","bgcolor","border","capture","cellpadding","cellspacing","checked","cite","class","clear","color","cols","colspan","contLine truncated
|
|
||||||
//# sourceMappingURL=trix.esm.min.js.map
|
|
||||||
Reference in new issue
Block a user