mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-09 00:00:12 +09:00
Cursor Agent
88fbeedc75
Chaining without_direct_rooms with with_ordered_room joined rooms as `room` while still ordering on `rooms.name`. Load shared rooms in one scope instead. Co-authored-by: Thomas Klemm <github@tklemm.eu>
22 lines
815 B
Ruby
22 lines
815 B
Ruby
class Users::SidebarsController < ApplicationController
|
|
DIRECT_PLACEHOLDERS = 20
|
|
|
|
def show
|
|
visible_memberships = Current.user.memberships.visible
|
|
@direct_memberships = visible_memberships.with_direct_rooms
|
|
@other_memberships = visible_memberships.with_ordered_shared_rooms
|
|
|
|
@direct_placeholder_users = find_direct_placeholder_users
|
|
end
|
|
|
|
private
|
|
def find_direct_placeholder_users
|
|
exclude_user_ids = user_ids_already_in_direct_rooms_with_current_user.including(Current.user.id)
|
|
User.active.where.not(id: exclude_user_ids).order(:created_at).limit([ DIRECT_PLACEHOLDERS - exclude_user_ids.count, 0 ].max)
|
|
end
|
|
|
|
def user_ids_already_in_direct_rooms_with_current_user
|
|
Membership.where(room_id: Current.user.rooms.directs.pluck(:id)).pluck(:user_id).uniq
|
|
end
|
|
end
|