mirror of
https://github.com/basecamp/once-campfire.git
synced 2026-10-09 00:00:12 +09:00
Marcello Costagliola
e6de359872
The thumbnail or video preview is generated while the message is posted. When ffmpeg or libvips can't decode the file (a truncated upload, an .mp4 holding only audio), the error escaped after the message had been saved: the request failed with a 500, the message was never broadcast, and the sender's upload stayed at 100% while the rest of the files in that drop were never sent. Posting the message without a preview keeps the file and lets everyone see it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVFo3Lt9T8M5NR7KxVvsZ2
45 lines
1.2 KiB
Ruby
45 lines
1.2 KiB
Ruby
module Message::Attachment
|
|
extend ActiveSupport::Concern
|
|
|
|
THUMBNAIL_MAX_WIDTH = 1200
|
|
THUMBNAIL_MAX_HEIGHT = 800
|
|
|
|
included do
|
|
has_one_attached :attachment do |attachable|
|
|
attachable.variant :thumb, resize_to_limit: [ THUMBNAIL_MAX_WIDTH, THUMBNAIL_MAX_HEIGHT ]
|
|
end
|
|
end
|
|
|
|
module ClassMethods
|
|
def create_with_attachment!(attributes)
|
|
create!(attributes).tap(&:process_attachment)
|
|
end
|
|
end
|
|
|
|
def attachment?
|
|
attachment.attached?
|
|
end
|
|
|
|
def process_attachment
|
|
ensure_attachment_analyzed
|
|
process_attachment_thumbnail
|
|
end
|
|
|
|
private
|
|
def ensure_attachment_analyzed
|
|
attachment&.analyze
|
|
end
|
|
|
|
# A file that ffmpeg or libvips can't decode is still the message: post it without a preview.
|
|
def process_attachment_thumbnail
|
|
case
|
|
when attachment.video?
|
|
attachment.preview(format: :webp).processed
|
|
when attachment.representable?
|
|
attachment.representation(:thumb).processed
|
|
end
|
|
rescue ActiveStorage::PreviewError, Vips::Error => error
|
|
Rails.logger.warn "Posted #{attachment.filename} without a preview: #{error.class}: #{error.message.lines.first&.chomp}"
|
|
end
|
|
end
|