tools/capver: exit non-zero on failure

A failed tag fetch left the generated files untouched, which is
indistinguishable from no drift: check-generated passed on stale output.
This commit is contained in:
Kristoffer Dalby
2026-09-04 14:11:15 +00:00
parent e40f47abbf
commit 507046bb7d
+6 -6
View File
@@ -458,8 +458,10 @@ func main() {
versions, err := getCapabilityVersions(ctx)
if err != nil {
log.Println("Error:", err)
return
// Fatal, not a soft return: leaving the generated files untouched is
// indistinguishable from "no drift", so check-generated would pass on
// stale output and an automated bump could not tell the two apart.
log.Fatalln("Error:", err)
}
// Calculate the minimum supported capability version
@@ -467,14 +469,12 @@ func main() {
err = writeCapabilityVersionsToFile(versions, minSupportedCapVer)
if err != nil {
log.Println("Error writing to file:", err)
return
log.Fatalln("Error writing to file:", err)
}
err = writeTestDataFile(versions, minSupportedCapVer)
if err != nil {
log.Println("Error writing test data file:", err)
return
log.Fatalln("Error writing test data file:", err)
}
log.Println("Capability versions written to", outputFile)