Kristoffer Dalby
7d934b1d8e
policy/v2: limit the destination and port pairs a policy declares
...
A grant lists dst and ip apart, so its filter grows with their product.
Refuse a policy over 100,000 pairs, on every parse.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
e0f59bc13a
policy/v2: refuse a port list in a grant ip entry
...
Tailscale SaaS takes one port range per ip entry; a list was accepted
and expanded. Write each range as an entry of its own.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
f18501e8c6
policy/v2: evaluate policy tests before taking the write lock
...
SetPolicy ran the policy's tests under the lock every map response and
node write needs. Run them on a snapshot of users and nodes first.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
4452b058ef
policy/v2: index compiled SSH rules by source for sshTests
...
Each check scanned every rule and parsed every principal per login name,
destination and source address. Compile once per run, key each
destination's rules by principal address, and evaluate a name once.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
76cdabaef2
policy/v2: parse the compiled filter once per tests run
...
The tests evaluator parsed every SrcIPs and DstPorts entry again for
each assertion, source prefix and rule. Parse the filter once per run.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
8a59373631
policy/v2: need every dst node for a tests accept, no range sources
...
An accept passes only when each node behind the dst is reached, as on
Tailscale SaaS; a deny keeps its rule. A CIDR, "*" or autogroup:tagged
src names no user or host, so its test fails.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
77db4da87d
policy/v2: label sshTests failures with the dst alias
...
The report goes back to the policy author: name src and dst as written,
one line per dst occurrence, and a dst with no node as not reached.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
89c26d0628
policy/v2: bound the tests and sshTests failure report
...
The report printed every failure with the full labels, so its size was
labels times failures. Print 100 lines of 256-byte labels, then a count.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
5e2a04d34a
policy/v2: refuse autogroup:member as an sshTests destination
...
Tailscale SaaS refuses it when parsing; headscale evaluated it.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
4554bd5b9c
policy/v2: refuse address ranges as sshTests sources
...
A CIDR, or a hosts entry holding one, as an sshTests src is refused,
as on Tailscale SaaS. Destinations share the range check.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
bd8a1f0bb6
policy/v2: map login 0 to no local user in SSH rules
...
Every rule that maps root now carries "0": "", as Tailscale SaaS writes
it, also when the policy lists "0".
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
52f19dac0b
policy/v2: write an ACL's repeated destination once
...
An ACL that names a destination and port twice wrote the pair twice.
Grants keep their repeats, as on Tailscale SaaS.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
2e7c677841
policy/v2: write a single-address via destination bare
...
Via rules wrote every destination with its prefix bits; ACL and grant
rules already drop them for a single address. Both use one formatter.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
9b46f8f1fc
db: keep only the current policy
...
Every write inserted a row and nothing deleted one, while every reader
takes only the newest. Writers store and install under one lock, so an
uncommitted insert cannot outlive the newer row that pruned the rest.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
a9024e564d
state: install a written policy only after it is stored
...
Writers validated by installing the policy live, so a store failure
left a refused or unstored policy enforced. Validate on a throwaway
manager, store, then reload from the stored row.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
837ede3fbc
policy/v2: refuse an empty policy
...
SetPolicy returned a nil error for empty input it ignored, so the v1
API stored it as valid. Reload skips only the nil "no policy" case.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
34b564354c
policy/v2: resolve tag owners one hop deep
...
A user claims only the tags it owns directly, and a tag owns only the
tags that list it, as on Tailscale SaaS. With no walk left, validate
names an undefined owner once, with the tag that lists it.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
dfaf494ab3
policy/v2: evaluate sshTests sources through the nodes they cover
...
A src was expanded to every address it names, so "*" or ::/0 never
finished. Principals are node addresses: keep those plus one stand-in.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
41d84aaf69
policy/v2: resolve each group once per policy compile
...
Group.resolve walked users and nodes for every member at every mention.
Resolve all groups once on a copy of the policy and compile from it.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
a581c971be
policy/v2: compile SSH rules once and share them across nodes
...
SSHPolicy re-resolved every rule and built private principals per node.
Compile the rules once per policy, users and nodes; per node, only
select.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
56dac9098f
policy/v2: merge rules sharing a source slice without rejoining it
...
The rules of one ACL now share one SrcIPs slice; key it once instead of
joining it again for every rule, globally and per node.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
7fc586e7d3
policy/v2: resolve an ACL's sources once for all its destinations
...
An ACL compiles to one grant per destination, and each resolved and
rendered the same sources. ViaRoutesForPeer only needs one grant per
ACL.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
17cf9441ce
policy/v2: bound via route steering by the peer's routes
...
Include and Exclude held one entry per overlapping dst, and the election
walked them per dst. Keep one entry per route; a peer without routes
returns at once.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
f6ec374c23
policy/v2: refresh clients when a user change drops the last via grant
...
SetUsers read needsPerNodeFilter after the recompile cleared it, so
the change was reported as empty and clients kept the via rules.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
1b724a5bb9
state: serialise policy reloads
...
Load and install the stored policy as one step, so an older
reload cannot install its document over a newer one.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
026d2b718c
integration: keep HA cable-pull routers off each other's routes
...
A router holding the other's route for its docker subnet in table 52
cannot be reattached: docker resolves the gateway through tailscale0.
Replaces the phase 4a wait that covered one case of it.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
8ee9980b96
mapper: count only the batcher's goroutines in lifecycle tests
...
runtime.NumGoroutine deltas moved when goroutines left by earlier
tests exited mid-test. Label the batcher's goroutines and count those.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
062bfff33d
policy/v2: recapture SSH data captures
...
Every ssh_results row captured again from SaaS. SaaS now maps login "0"
to no local user in rules that map root, quotes a refused checkPeriod as
written and rewords its tailnet-domain refusal.
2026-10-28 19:06:04 +00:00
Kristoffer Dalby
54f8030acc
hscontrol, servertest: add key list scope golden data
...
Read-only and key-making OAuth tokens of each tag set list auth keys
with and without all=true, over admin- and token-made keys of every tag
relation, one admin key made after the token-made ones.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
8662eaeb8e
servertest: add user role dispatch golden data
...
An admin role change under autogroup:admin, mirrored as a user rename;
peers, filter and frames per node per step, and v2 device users.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
18cbaf6f2a
servertest, state: add node name golden data
...
Labels under taken hostnames, case-only renames, hostname changes, long
hostnames and a Service's name; API, peer and self per step, and State
labels as a restart would load them.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
8bb0454fce
policy/v2, servertest: add policy generation golden data
...
One policy over joins, a via router swap, an admin tag, a delete and a
group edit; filter, SSH, peers and routes per step, and the manager
against a fresh one.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
98fe8f2935
servertest: add hidden peer and route announcement golden data
...
What a node hears of peers it cannot see, and what a router's peers hear
of routes it announces; presence, removals, peers and routes per step.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
67b37ac32e
servertest: count map frames per client
...
Counts ControlTime events, so frames that leave the netmap as it was,
or that a delta client applies in place, still show.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
9d138868b3
servertest: recapture map delivery golden data
...
The probe now bounds snapshot reads and keeps feature refusals as data.
SaaS now sends appc and sshd laptop's unchanged entry on the restore.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
9793ff0c9b
servertest: wait for each replayed join before the next
...
Polls start in the background, so a later router could come online
first and keep the global primary SaaS gave the first.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
b2c4fb9ebf
servertest: count deleted nodes in replayed peer views
...
Only nodes still in State resolved to an alias, so a client that kept
a deleted peer passed the peers and route owner checks.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
123407bf2c
servertest: recapture via HA failover golden data
...
The probe now bounds its reads and stops when a step loses data.
Route owners and peers match the first capture at every step.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
94a14565ed
hscontrol, servertest: fail on any unread pending login or expiry entry
...
Each map serves one capture, so a misspelled capture name never went
stale.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
5555a52eca
servertest: require a map on each stream an expiry replay opens
...
The cached netmap outlives a stream, so a refused re-poll passed.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
9e20ec77e1
servertest: compare filter and SSH rules in expiry replays
...
Changed-or-not alone let empty rules pass for SaaS's new ones.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
d8db2b6eff
servertest: recapture ephemeral, expiry and pending login golden data
...
The expiry file now holds the shared policy, DNS and observer setup.
Outcomes match the first capture; collection was seen one poll earlier.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
de68d0b464
servertest: judge ephemeral collection apart from the poll that saw it
...
Killed nodes are checked once at the last read, for devices left and
whether the observer lost them since the kill.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
995029798e
hscontrol: compare API replay fields per object
...
One aggregate per field hid a partial fix. Device users are compared,
and headscale's oauthClientId resolves to the SaaS label.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
95f21ce1f2
hscontrol: check API replay outcomes apart from status
...
A listed status hid a call flipping between allowed and refused, and
validate refusals SaaS answers with 200 went unchecked.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
635c41f8fe
servertest: recapture v2 OAuth and policy API golden data
...
Tag writes are read back once the tags hold, and both files carry a
baseline snapshot. Statuses and read-backs match the first capture.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
f9e54092db
servertest, policy/v2: replay tag owner chain joins through registration
...
A key login never asks the policy about requested tags, so the joins are
checked where headscale decides them. OAuth mints stay at
TagOwnedByTags.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
3992c1a729
servertest: recapture re-authentication golden data
...
The probe now stops a refused login's retries; the replay disconnects
there too. Outcomes match the first capture, and user IDs are labels.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
5df10d2019
servertest: fail on skip entries no lifecycle replay reads
...
Consumers check entries under their own capture only, so a bare or
misspelled key never went stale.
2026-10-28 19:06:03 +00:00
Kristoffer Dalby
97c2b06327
servertest: check route continuity in every streamed step
...
Removal and route drops were judged only on steps SaaS sent frames for;
silent steps and a clear-then-restore within a step went unchecked.
2026-10-28 19:06:03 +00:00